Fix AllTop-compose

Author: fabianbs96

include/phasar/DataFlow/IfdsIde/EdgeFunction.h

@@ -547,6 +547,17 @@ class [[clang::trivial_abi]] EdgeFunction final : EdgeFunctionBase {
     return this->template isa<ConcreteEF>() ? getPtr<ConcreteEF>(EF) : nullptr;
   }
 
+  template <typename ConcreteEF>
+  [[nodiscard]] std::optional<EdgeFunctionRef<ConcreteEF>>
+  asRef() const noexcept {
+    if (isa<ConcreteEF>()) {
+      return EdgeFunctionRef<ConcreteEF>(
+          EF, getAllocationPolicy() == AllocationPolicy::CustomHeapAllocated);
+    }
+
+    return std::nullopt;
+  }
+
   // -- misc
 
   /// True, iff this edge function is not small-object-optimized and thus its
@@ -738,17 +749,17 @@ class [[clang::trivial_abi]] EdgeFunction final : EdgeFunctionBase {
 namespace llvm {
 
 template <typename L> struct DenseMapInfo<psr::EdgeFunction<L>> {
-  static inline auto getEmptyKey() noexcept {
+  static auto getEmptyKey() noexcept {
     return psr::EdgeFunction<L>::getEmptyKey();
   }
-  static inline auto getTombstoneKey() noexcept {
+  static auto getTombstoneKey() noexcept {
     return psr::EdgeFunction<L>::getTombstoneKey();
   }
-  static inline auto getHashValue(const psr::EdgeFunction<L> &EF) noexcept {
+  static auto getHashValue(const psr::EdgeFunction<L> &EF) noexcept {
     return EF.getHashCode();
   }
-  static inline auto isEqual(const psr::EdgeFunction<L> &EF1,
-                             const psr::EdgeFunction<L> &EF2) noexcept {
+  static auto isEqual(const psr::EdgeFunction<L> &EF1,
+                      const psr::EdgeFunction<L> &EF2) noexcept {
     if (EF1.referenceEquals(EF2)) {
       return true;
     }

include/phasar/DataFlow/IfdsIde/EdgeFunctionUtils.h

@@ -173,7 +173,7 @@ template <typename L> struct AllTop final {
   [[nodiscard]] static EdgeFunction<l_t>
   compose(EdgeFunctionRef<AllTop> This,
           const EdgeFunction<l_t> &SecondFunction) {
-    return llvm::isa<EdgeIdentity<l_t>>(SecondFunction) ? This : SecondFunction;
+    return SecondFunction.isConstant() ? SecondFunction : This;
   }
 
   [[nodiscard]] static EdgeFunction<l_t>
@@ -211,13 +211,16 @@ defaultComposeOrNull(const EdgeFunction<L> &This,
   if (llvm::isa<EdgeIdentity<L>>(SecondFunction)) {
     return This;
   }
-  if (SecondFunction.isConstant() || llvm::isa<AllTop<L>>(This) ||
-      llvm::isa<EdgeIdentity<L>>(This)) {
+  if (SecondFunction.isConstant() || llvm::isa<EdgeIdentity<L>>(This)) {
     return SecondFunction;
   }
-  if (llvm::isa<AllBottom<L>>(This)) {
+  if (llvm::isa<AllTop<L>>(This)) {
     return This;
   }
+  if (auto BotEF = This.template asRef<AllBottom<L>>()) {
+    return AllBottom<L>::compose(*BotEF, SecondFunction);
+  }
+
   return nullptr;
 }
 
@@ -471,12 +474,10 @@ ConstantEdgeFunction<L>::compose(EdgeFunctionRef<ConcreteEF> This,
 
   if constexpr (AreEqualityComparable<decltype(JLattice::top()), L>) {
     if (JLattice::top() == ConstVal) {
-      /// TODO: Can this ever happen?
       return AllTop<L>{};
     }
   } else {
     if (L(JLattice::top()) == ConstVal) {
-      /// TODO: Can this ever happen?
       return AllTop<L>{};
     }
   }
@@ -505,7 +506,7 @@ ConstantEdgeFunction<L>::join(EdgeFunctionRef<ConcreteEF> This,
     return OtherFunction.joinWith(This);
   }
 
-  auto OtherVal = OtherFunction.computeTarget(JLattice::top());
+  auto OtherVal = OtherFunction.computeTarget(JLattice::bottom());
   auto JoinedVal = JLattice::join(This->Value, OtherVal);
 
   if constexpr (AreEqualityComparable<decltype(JLattice::bottom()), l_t>) {