Skip to content

Commit 1d2a2e8

Browse files
Same fix for http
1 parent 8573373 commit 1d2a2e8

2 files changed

Lines changed: 22 additions & 21 deletions

File tree

singlestoredb/connection.py

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1120,32 +1120,32 @@ def _convert_params(
11201120
params: Optional[Union[Sequence[Any], Dict[str, Any], Any]],
11211121
) -> Tuple[Any, ...]:
11221122
"""Convert query to correct parameter format."""
1123-
if params:
11241123

1125-
if cls._map_param_converter is None:
1126-
cls._map_param_converter = sqlparams.SQLParams(
1127-
map_paramstyle, cls.paramstyle, escape_char=True,
1128-
)
1129-
1130-
if cls._positional_param_converter is None:
1131-
cls._positional_param_converter = sqlparams.SQLParams(
1132-
positional_paramstyle, cls.paramstyle, escape_char=True,
1133-
)
1124+
if cls._map_param_converter is None:
1125+
cls._map_param_converter = sqlparams.SQLParams(
1126+
map_paramstyle, cls.paramstyle, escape_char=True,
1127+
)
11341128

1135-
is_sequence = isinstance(params, Sequence) \
1136-
and not isinstance(params, str) \
1137-
and not isinstance(params, bytes)
1138-
is_mapping = isinstance(params, Mapping)
1129+
if cls._positional_param_converter is None:
1130+
cls._positional_param_converter = sqlparams.SQLParams(
1131+
positional_paramstyle, cls.paramstyle, escape_char=True,
1132+
)
11391133

1140-
param_converter = cls._map_param_converter \
1141-
if is_mapping else cls._positional_param_converter
1134+
is_sequence = isinstance(params, Sequence) \
1135+
and not isinstance(params, str) \
1136+
and not isinstance(params, bytes)
1137+
is_mapping = isinstance(params, Mapping)
11421138

1143-
if not is_sequence and not is_mapping:
1144-
params = [params]
1139+
param_converter = cls._map_param_converter \
1140+
if is_mapping else cls._positional_param_converter
11451141

1146-
return param_converter.format(oper, params)
1142+
params_to_use = params
1143+
if not params:
1144+
params_to_use = ()
1145+
elif not is_sequence and not is_mapping:
1146+
params_to_use = [params]
11471147

1148-
return (oper, None)
1148+
return param_converter.format(oper, params_to_use)
11491149

11501150
def autocommit(self, value: bool = True) -> None:
11511151
"""Set autocommit mode."""

singlestoredb/tests/utils.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,8 @@ def load_sql(sql_file: str) -> str:
220220
cur.execute(f'USE {dbname};')
221221

222222
# Start HTTP server as needed.
223-
if http_port and not conn.driver.startswith('http'):
223+
if http_port and not conn.driver.startswith('http') and \
224+
'IS_HELIOS' not in os.environ:
224225
cur.execute(f'SET GLOBAL HTTP_PROXY_PORT={http_port};')
225226
cur.execute('SET GLOBAL HTTP_API=ON;')
226227
cur.execute('RESTART PROXY;')

0 commit comments

Comments
 (0)