Skip to content

Commit 414255d

Browse files
michalsekmdydekmaciejmakowski2003
authored
Invalid engine states on recording or playback start (#1005)
* fix: sloppified fix for engine/session management * fix: format with valid clang-format version * fix: cleanup hallucination v1 * fix: recorder host object missing function definition * fix: invalid engine state after session deactivation * fix: cleanup unnecessary code * fix: cleanup unnecessary code * feat: ios engine test coverage + small cleanups * feat: works * fix: re-create engine together with nodes * fix: remove tmp files, better recorder start error flow * fix: cleanup tests * fix: cleanup stress tests slop * chore: cleanup * ci: format * fix: ios recorder tests * fix: wants vs has (#1017) * fix: removed unnecesary screen * test: recorder restarts an engine * refactor: removed old todos and use resolved buffer size * fix: removed batchDurationSeconds --------- Co-authored-by: michal <dydmichal@gmail.com> Co-authored-by: maciejmakowski2003 <maciejmakowski2003@users.noreply.github.com>
1 parent 7a61289 commit 414255d

68 files changed

Lines changed: 7382 additions & 373 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/CODEOWNERS

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
/.github/CODEOWNERS @michalsek @maciejmakowski2003 @mdydek
2-
/.github/workflows @michalsek @maciejmakowski2003 @mdydek
1+
/.github/CODEOWNERS @maciejmakowski2003 @mdydek
2+
/.github/workflows @maciejmakowski2003 @mdydek

apps/common-app/src/demos/Record/Record.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ const Record: FC = () => {
240240
}, [onPauseRecording, onResumeRecording]);
241241

242242
useEffect(() => {
243-
Recorder.enableFileOutput({ rotateIntervalBytes: 1024 * 1024 });
243+
Recorder.enableFileOutput({ rotateIntervalBytes: 1_000_000 });
244244

245245
return () => {
246246
Recorder.disableFileOutput();

apps/common-app/src/examples/AudioFile/AudioPlayer.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import type {
44
} from 'react-native-audio-api';
55
import {
66
AudioContext,
7-
decodeAudioData,
87
PlaybackNotificationManager,
98
GainNode,
109
} from 'react-native-audio-api';
@@ -46,13 +45,17 @@ class AudioPlayer {
4645
await this.audioContext.resume();
4746
}
4847

49-
this.sourceNode = this.audioContext.createBufferSource({pitchCorrection: true});
48+
this.sourceNode = this.audioContext.createBufferSource({
49+
pitchCorrection: true,
50+
});
5051
this.sourceNode.buffer = this.audioBuffer;
5152
this.sourceNode.playbackRate.value = this.playbackRate;
5253
this.volumeNode = this.audioContext.createGain();
5354
this.volumeNode.gain.value = this.volume;
5455

55-
this.sourceNode.connect(this.volumeNode).connect(this.audioContext.destination);
56+
this.sourceNode
57+
.connect(this.volumeNode)
58+
.connect(this.audioContext.destination);
5659
this.sourceNode.onPositionChangedInterval = 1000;
5760
this.sourceNode.onPositionChanged = (event) => {
5861
PlaybackNotificationManager.show({

0 commit comments

Comments
 (0)