fix: wants vs has (#1017)

Author: michalsek

apps/common-app/src/examples/Record/Record.tsx

@@ -1,9 +1,10 @@
-import React, { FC, useCallback, useEffect, useState } from 'react';
+import React, { FC, useCallback, useEffect, useState, useRef } from 'react';
 import { Alert, Text, View } from 'react-native';
 import {
   AudioBuffer,
   AudioManager,
   useAudioInput,
+  AudioBufferSourceNode,
 } from 'react-native-audio-api';
 
 import { Button, Container, Select } from '../../components';
@@ -23,6 +24,7 @@ const Record: FC = () => {
 
   const [status, setStatus] = useState<Status>(Status.Idle);
   const [capturedBuffers, setCapturedBuffers] = useState<AudioBuffer[]>([]);
+  const sourceNodesRef = useRef<AudioBufferSourceNode[]>([]);
 
   const verifyPermissions = async () => {
     const recPerm = await AudioManager.requestRecordingPermissions();
@@ -197,6 +199,7 @@ const Record: FC = () => {
       source.connect(audioContext.destination);
       source.start(nextStartAt);
       nextStartAt += buffer.duration;
+      sourceNodesRef.current.push(source);
     });
 
     setStatus(Status.Playback);
@@ -225,6 +228,10 @@ const Record: FC = () => {
   useEffect(() => {
     return () => {
       audioRecorder.stop();
+      sourceNodesRef.current.forEach((source) => {
+        source.disconnect();
+      });
+      sourceNodesRef.current = [];
     };
   }, []);
 

apps/fabric-example/ios/FabricExampleTests/IOSAudioRecorderTests.mm

@@ -241,6 +241,36 @@ void setRecorderState(RecorderState state)
   {
     return filePath_;
   }
+
+  bool fileOutputEnabledIntent() const
+  {
+    return fileOutputEnabled_.load(std::memory_order_acquire);
+  }
+
+  bool fileOutputConfigured() const
+  {
+    return fileOutputConfigured_.load(std::memory_order_acquire);
+  }
+
+  bool callbackOutputEnabledIntent() const
+  {
+    return callbackOutputEnabled_.load(std::memory_order_acquire);
+  }
+
+  bool callbackOutputConfigured() const
+  {
+    return callbackOutputConfigured_.load(std::memory_order_acquire);
+  }
+
+  bool connectionEnabledIntent() const
+  {
+    return isConnected_.load(std::memory_order_acquire);
+  }
+
+  bool connectionConfigured() const
+  {
+    return connectedConfigured_.load(std::memory_order_acquire);
+  }
 };
 
 @interface IOSAudioRecorderTests : XCTestCase {
@@ -433,6 +463,43 @@ - (void)testStartPreparesMonoCallbackAgainstResolvedMultichannelInputFormat
   XCTAssertTrue(self.nativeRecorder.lastInputArmed);
 }
 
+- (void)testEnableFileOutputWhileIdleTracksIntentWithoutLiveWriter
+{
+  auto enableResult = _recorder->enableFileOutput([self validFileProperties]);
+
+  XCTAssertTrue(enableResult.is_ok());
+  XCTAssertTrue(_recorder->fileOutputEnabledIntent());
+  XCTAssertFalse(_recorder->fileOutputConfigured());
+  XCTAssertFalse(_recorder->usesFileOutput());
+  XCTAssertEqual(_recorder->getCurrentDuration(), 0.0);
+
+  _recorder->clearOnErrorCallback();
+}
+
+- (void)testSetOnAudioReadyWhileIdleTracksIntentWithoutLiveCallback
+{
+  auto callbackResult = _recorder->setOnAudioReadyCallback(48000, 256, 1, 99);
+
+  XCTAssertTrue(callbackResult.is_ok());
+  XCTAssertTrue(_recorder->callbackOutputEnabledIntent());
+  XCTAssertFalse(_recorder->callbackOutputConfigured());
+  XCTAssertFalse(_recorder->usesCallback());
+}
+
+- (void)testConnectWhileIdleTracksIntentWithoutLiveConnection
+{
+  auto context =
+      std::make_shared<OfflineAudioContext>(2, 512, 44100.0f, nullptr, RuntimeRegistry{});
+  context->initialize();
+  auto adapter = context->createRecorderAdapter();
+
+  _recorder->connect(adapter);
+
+  XCTAssertTrue(_recorder->connectionEnabledIntent());
+  XCTAssertFalse(_recorder->connectionConfigured());
+  XCTAssertFalse(_recorder->isConnected());
+}
+
 - (void)testStartDoesNotAttemptToManageSessionWhenOwnershipIsExternal
 {
   self.sessionManager.shouldManageSession = NO;
@@ -491,6 +558,38 @@ - (void)testStopSucceedsAfterStartAndResetsState
   XCTAssertEqual(std::get<2>(stopResult.unwrap()), 0);
 }
 
+- (void)testStopClearsConfiguredStateButPreservesConfiguredIntent
+{
+  self.audioEngine.state = AudioEngineStateRunning;
+  auto context =
+      std::make_shared<OfflineAudioContext>(2, 512, 44100.0f, nullptr, RuntimeRegistry{});
+  context->initialize();
+  auto adapter = context->createRecorderAdapter();
+
+  XCTAssertTrue(_recorder->enableFileOutput([self validFileProperties]).is_ok());
+  XCTAssertTrue(_recorder->setOnAudioReadyCallback(48000, 256, 1, 99).is_ok());
+  _recorder->connect(adapter);
+
+  auto startResult = _recorder->start("");
+  XCTAssertTrue(startResult.is_ok());
+  XCTAssertTrue(_recorder->fileOutputConfigured());
+  XCTAssertTrue(_recorder->callbackOutputConfigured());
+  XCTAssertTrue(_recorder->connectionConfigured());
+
+  auto stopResult = _recorder->stop();
+
+  XCTAssertTrue(stopResult.is_ok());
+  XCTAssertTrue(_recorder->fileOutputEnabledIntent());
+  XCTAssertFalse(_recorder->fileOutputConfigured());
+  XCTAssertFalse(_recorder->usesFileOutput());
+  XCTAssertTrue(_recorder->callbackOutputEnabledIntent());
+  XCTAssertFalse(_recorder->callbackOutputConfigured());
+  XCTAssertFalse(_recorder->usesCallback());
+  XCTAssertTrue(_recorder->connectionEnabledIntent());
+  XCTAssertFalse(_recorder->connectionConfigured());
+  XCTAssertFalse(_recorder->isConnected());
+}
+
 - (void)testFileOutputSmokeTest
 {
   self.audioEngine.state = AudioEngineStateRunning;

apps/fabric-example/ios/Podfile.lock

@@ -2476,7 +2476,7 @@ EXTERNAL SOURCES:
 
 SPEC CHECKSUMS:
   FBLazyVector: c00c20551d40126351a6783c47ce75f5b374851b
-  hermes-engine: 110b8efcd560ee96f1b25506f44de5dac81a8b7a
+  hermes-engine: 91023181d4bc5948b457de5314623fbfe4f8604e
   RCTDeprecation: 3bb167081b134461cfeb875ff7ae1945f8635257
   RCTRequired: 74839f55d5058a133a0bc4569b0afec750957f64
   RCTSwiftUI: 87a316382f3eab4dd13d2a0d0fd2adcce917361a
@@ -2485,7 +2485,7 @@ SPEC CHECKSUMS:
   React: 1b1536b9099195944034e65b1830f463caaa8390
   React-callinvoker: 6dff6d17d1d6cc8fdf85468a649bafed473c65f5
   React-Core: 00faa4d038298089a1d5a5b21dde8660c4f0820d
-  React-Core-prebuilt: 9484d565c2a73554e0ad6feaf2663d91044b7fed
+  React-Core-prebuilt: a6d614de037caff7898424dfc22915ec792de921
   React-CoreModules: a17807f849bfd86045b0b9a75ec8c19373b482f6
   React-cxxreact: c7b53ace5827be54048288bce5c55f337c41e95f
   React-debug: e1f00fcd2cef58a2897471a6d76a4ef5f5f90c74
@@ -2549,7 +2549,7 @@ SPEC CHECKSUMS:
   ReactAppDependencyProvider: 5787b37b8e2e51dfeab697ec031cc7c4080dcea2
   ReactCodegen: d07ee3c8db75b43d1cbe479ae6affebf9925c733
   ReactCommon: fe2a3af8975e63efa60f95fca8c34dc85deee360
-  ReactNativeDependencies: 9bccac470fdc394968cb9cba9b0e9bb9a1a38bf1
+  ReactNativeDependencies: 4d5ce2683b6d74f7c686bf90a88c7d381295cf3c
   RNAudioAPI: 6f6c369c1df31fc8205cbc6f0c3bcb7322e9cfa9
   RNGestureHandler: 187c5c7936abf427bc4d22d6c3b1ac80ad1f63c0
   RNReanimated: 64f4b3b33b48b19e0ba76a352571b52b1e931981