feat: use pip3 if available (#79)

Author: tjdevries

packages/pyright-scip/package-lock.json

@@ -24,6 +24,7 @@
     "@sourcegraph/eslint-config": "0.26.0",
     "@sourcegraph/prettierrc": "3.0.3",
     "@sourcegraph/tsconfig": "4.0.1",
+    "@types/command-exists": "^1.2.0",
     "@types/diff": "^5.0.2",
     "@types/glob": "^7.2.0",
     "@types/google-protobuf": "^3.15.5",
@@ -43,6 +44,7 @@
   },
   "dependencies": {
     "@iarna/toml": "2.2.5",
+    "command-exists": "^1.2.9",
     "commander": "^9.2.0",
     "diff": "^5.0.0",
     "glob": "^7.2.0",

packages/pyright-scip/package.json

@@ -3,6 +3,7 @@ import * as child_process from 'child_process';
 import PythonPackage from './PythonPackage';
 import PythonEnvironment from './PythonEnvironment';
 import { withStatus } from 'src/status';
+import { sync as commandExistsSync } from 'command-exists';
 
 // Some future improvements:
 //  - Could use `importlib` and execute some stuff from Python
@@ -12,14 +13,29 @@ interface PipInformation {
     version: string;
 }
 
+let pipCommand: string | undefined;
+let getPipCommand = () => {
+    if (pipCommand === undefined) {
+        if (commandExistsSync('pip3')) {
+            pipCommand = 'pip3';
+        } else if (commandExistsSync('pip')) {
+            pipCommand = 'pip';
+        } else {
+            throw new Error('Could not find valid pip command');
+        }
+    }
+
+    return pipCommand;
+};
+
 function pipList(): PipInformation[] {
-    return JSON.parse(child_process.execSync('pip list --format=json').toString()) as PipInformation[];
+    return JSON.parse(child_process.execSync(`${getPipCommand()} list --format=json`).toString()) as PipInformation[];
 }
 
 function pipBulkShow(names: string[]): string[] {
     // TODO: This probably breaks with enough names. Should batch them into 512 or whatever the max for bash would be
     return child_process
-        .execSync(`pip show -f ${names.join(' ')}`)
+        .execSync(`${getPipCommand()} show -f ${names.join(' ')}`)
         .toString()
         .split('---');
 }