use sentinel error

Author: burmudar

cmd/src/main_test.go

@@ -3,6 +3,7 @@ package main
 import (
 	"context"
 	"encoding/json"
+	"errors"
 	"io"
 	"net/url"
 	"os"
@@ -437,8 +438,8 @@ func TestConfigAPIClientCIAccessTokenGate(t *testing.T) {
 		client := (&config{endpointURL: endpointURL, inCI: true}).apiClient(nil, io.Discard)
 
 		_, err := client.NewHTTPRequest(context.Background(), "GET", ".api/src-cli/version", nil)
-		if err == nil || err.Error() != errCIAccessTokenRequired.Error() {
-			t.Fatalf("NewHTTPRequest() error = %v, want %q", err, errCIAccessTokenRequired)
+		if !errors.Is(err, api.ErrCIAccessTokenRequired) {
+			t.Fatalf("NewHTTPRequest() error = %v, want %v", err, api.ErrCIAccessTokenRequired)
 		}
 	})
 

internal/api/api.go

@@ -91,6 +91,9 @@ type ClientOpts struct {
 	OAuthToken *oauth.Token
 }
 
+// ErrCIAccessTokenRequired indicates SRC_ACCESS_TOKEN must be set when CI=true.
+var ErrCIAccessTokenRequired = errors.New("SRC_ACCESS_TOKEN must be set when CI=true")
+
 func buildTransport(opts ClientOpts, flags *Flags) http.RoundTripper {
 	var transport http.RoundTripper
 	{
@@ -153,7 +156,7 @@ func NewClient(opts ClientOpts) Client {
 
 func (c *client) checkIfCIAccessTokenRequired() error {
 	if c.opts.RequireAccessTokenInCI && c.opts.AccessToken == "" {
-		return errors.New("SRC_ACCESS_TOKEN must be set when CI=true")
+		return ErrCIAccessTokenRequired
 	}
 
 	return nil