-
Notifications
You must be signed in to change notification settings - Fork 7
Expand file tree
/
Copy pathsdkReadinessManager.spec.ts
More file actions
362 lines (275 loc) · 18.5 KB
/
sdkReadinessManager.spec.ts
File metadata and controls
362 lines (275 loc) · 18.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
// @ts-nocheck
import { loggerMock } from '../../logger/__tests__/sdkLogger.mock';
import SplitIO from '../../../types/splitio';
import { SDK_READY, SDK_READY_FROM_CACHE, SDK_READY_TIMED_OUT, SDK_UPDATE, SDK_SPLITS_ARRIVED, SDK_SEGMENTS_ARRIVED, SDK_SPLITS_CACHE_LOADED } from '../constants';
import { sdkReadinessManagerFactory } from '../sdkReadinessManager';
import { IReadinessManager } from '../types';
import { ERROR_CLIENT_LISTENER, CLIENT_READY_FROM_CACHE, CLIENT_READY, CLIENT_NO_LISTENER } from '../../logger/constants';
import { fullSettings } from '../../utils/settingsValidation/__tests__/settings.mocks';
import { EventEmitter } from '../../utils/MinEvents';
const EventEmitterMock = jest.fn(() => ({
on: jest.fn(),
once: jest.fn(),
emit: jest.fn(),
removeAllListeners: jest.fn(),
addListener: jest.fn(),
off: jest.fn(),
removeListener: jest.fn()
})) as new () => SplitIO.IEventEmitter;
// Makes readinessManager emit SDK_READY & update isReady flag
function emitReadyEvent(readinessManager: IReadinessManager) {
if (readinessManager.gate instanceof EventEmitter) {
readinessManager.splits.emit(SDK_SPLITS_ARRIVED);
readinessManager.segments.emit(SDK_SEGMENTS_ARRIVED);
return;
}
readinessManager.splits.once.mock.calls[0][1]();
readinessManager.splits.on.mock.calls[0][1]();
readinessManager.segments.once.mock.calls[0][1]();
readinessManager.segments.on.mock.calls[0][1]();
readinessManager.gate.once.mock.calls[0][1]();
if (readinessManager.gate.once.mock.calls[3]) readinessManager.gate.once.mock.calls[3][1](); // whenReady promise
}
const timeoutErrorMessage = 'Split SDK emitted SDK_READY_TIMED_OUT event.';
// Makes readinessManager emit SDK_READY_TIMED_OUT & update hasTimedout flag
function emitTimeoutEvent(readinessManager: IReadinessManager) {
if (readinessManager.gate instanceof EventEmitter) {
readinessManager.timeout();
return;
}
readinessManager.gate.once.mock.calls[1][1](timeoutErrorMessage);
readinessManager.hasTimedout = () => true;
if (readinessManager.gate.once.mock.calls[4]) readinessManager.gate.once.mock.calls[4][1](timeoutErrorMessage); // whenReady promise
}
describe('SDK Readiness Manager - Event emitter', () => {
beforeEach(() => { loggerMock.mockClear(); });
test('Providing the gate object to get the SDK status interface that manages events', () => {
expect(typeof sdkReadinessManagerFactory).toBe('function'); // The module exposes a function.
const sdkReadinessManager = sdkReadinessManagerFactory(EventEmitterMock, fullSettings);
expect(typeof sdkReadinessManager).toBe('object'); // The function result contains the readiness manager and a sdkStatus object.
const gateMock = sdkReadinessManager.readinessManager.gate;
const sdkStatus = sdkReadinessManager.sdkStatus;
Object.keys(new EventEmitterMock()).forEach(propName => {
expect(sdkStatus[propName]).toBeTruthy(); // The sdkStatus exposes all minimal EventEmitter functionality.
});
expect(typeof sdkStatus.whenReady).toBe('function'); // The sdkStatus exposes a .whenReady() function.
expect(typeof sdkStatus.whenReadyFromCache).toBe('function'); // The sdkStatus exposes a .whenReadyFromCache() function.
expect(sdkStatus.getStatus()).toEqual({ // The sdkStatus exposes a .getStatus() function.
isReady: false, isReadyFromCache: false, isTimedout: false, hasTimedout: false, isDestroyed: false, isOperational: false, lastUpdate: 0
});
expect(typeof sdkStatus.Event).toBe('object'); // It also exposes the Event map,
expect(sdkStatus.Event.SDK_READY).toBe(SDK_READY); // which contains the constants for the events, for backwards compatibility.
expect(sdkStatus.Event.SDK_READY_FROM_CACHE).toBe(SDK_READY_FROM_CACHE); // which contains the constants for the events, for backwards compatibility.
expect(sdkStatus.Event.SDK_READY_TIMED_OUT).toBe(SDK_READY_TIMED_OUT); // which contains the constants for the events, for backwards compatibility.
expect(sdkStatus.Event.SDK_UPDATE).toBe(SDK_UPDATE); // which contains the constants for the events, for backwards compatibility.
expect(gateMock.once).toBeCalledTimes(3); // It should make three one time only subscriptions
const sdkReadyResolvePromiseCall = gateMock.once.mock.calls[0];
const sdkReadyRejectPromiseCall = gateMock.once.mock.calls[1];
const sdkReadyFromCacheListenersCheckCall = gateMock.once.mock.calls[2];
expect(sdkReadyResolvePromiseCall[0]).toBe(SDK_READY); // A one time only subscription is on the SDK_READY event
expect(sdkReadyRejectPromiseCall[0]).toBe(SDK_READY_TIMED_OUT); // A one time only subscription is also on the SDK_READY_TIMED_OUT event
expect(sdkReadyFromCacheListenersCheckCall[0]).toBe(SDK_READY_FROM_CACHE); // A one time only subscription is on the SDK_READY_FROM_CACHE event
expect(gateMock.on).toBeCalledTimes(2); // It should also add two persistent listeners
const removeListenerSubCall = gateMock.on.mock.calls[0];
const addListenerSubCall = gateMock.on.mock.calls[1];
expect(removeListenerSubCall[0]).toBe('removeListener'); // First subscription should be made to the removeListener event.
expect(addListenerSubCall[0]).toBe('newListener'); // Second subscription should be made to the newListener event, after the removeListener one so we avoid an unnecessary trigger.
});
test('The event callbacks should work as expected - SDK_READY_FROM_CACHE', () => {
const sdkReadinessManager = sdkReadinessManagerFactory(EventEmitterMock, fullSettings);
const gateMock = sdkReadinessManager.readinessManager.gate;
const readyFromCacheEventCB = gateMock.once.mock.calls[2][1];
readyFromCacheEventCB();
expect(loggerMock.info).toBeCalledTimes(1); // If the SDK_READY_FROM_CACHE event fires, we get a info message.
expect(loggerMock.info).toBeCalledWith(CLIENT_READY_FROM_CACHE); // Telling us the SDK is ready to be used with data from cache.
});
test('The event callbacks should work as expected - SDK_READY emits with no callbacks', () => {
const sdkReadinessManager = sdkReadinessManagerFactory(EventEmitterMock, fullSettings);
// Get the callbacks
const addListenerCB = sdkReadinessManager.readinessManager.gate.on.mock.calls[1][1];
emitReadyEvent(sdkReadinessManager.readinessManager);
expect(loggerMock.warn).toBeCalledTimes(1); // If the SDK_READY event fires and we have no callbacks for it (neither event nor whenReady promise) we get a warning.
expect(loggerMock.warn).toBeCalledWith(CLIENT_NO_LISTENER); // Telling us there were no listeners and evaluations before this point may have been incorrect.
expect(loggerMock.info).toBeCalledTimes(1); // If the SDK_READY event fires, we get a info message.
expect(loggerMock.info).toBeCalledWith(CLIENT_READY); // Telling us the SDK is ready.
// Now it's marked as ready.
addListenerCB('this event we do not care');
expect(loggerMock.error).not.toBeCalled(); // Now if we add a listener to an event unrelated with readiness, we get no errors logged.
addListenerCB(SDK_READY);
expect(loggerMock.error).toBeCalledWith(ERROR_CLIENT_LISTENER, ['SDK_READY']); // If we try to add a listener for the already emitted SDK_READY event, we get the corresponding error.
loggerMock.error.mockClear();
addListenerCB(SDK_READY_TIMED_OUT);
expect(loggerMock.error).toBeCalledWith(ERROR_CLIENT_LISTENER, ['SDK_READY_TIMED_OUT']); // If we try to add a listener for the already emitted SDK_READY_TIMED_OUT event, we get the corresponding error.
});
test('The event callbacks should work as expected - SDK_READY emits with callbacks', () => {
const sdkReadinessManager = sdkReadinessManagerFactory(EventEmitterMock, fullSettings);
// Get the callbacks
const addListenerCB = sdkReadinessManager.readinessManager.gate.on.mock.calls[1][1];
addListenerCB(SDK_READY);
expect(loggerMock.warn).not.toBeCalled(); // We are adding a listener to the ready event before it is ready, so no warnings are logged.
expect(loggerMock.error).not.toBeCalled(); // We are adding a listener to the ready event before it is ready, so no errors are logged.
emitReadyEvent(sdkReadinessManager.readinessManager);
expect(loggerMock.warn).not.toBeCalled(); // As we had at least one listener, we get no warnings.
expect(loggerMock.error).not.toBeCalled(); // As we had at least one listener, we get no errors.
expect(loggerMock.info).toBeCalledTimes(1); // If the SDK_READY event fires, we get a info message.
expect(loggerMock.info).toBeCalledWith(CLIENT_READY); // Telling us the SDK is ready.
});
test('The event callbacks should work as expected - If we end up removing the listeners for SDK_READY, it behaves as if it had none', () => {
const sdkReadinessManager = sdkReadinessManagerFactory(EventEmitterMock, fullSettings);
const gateMock = sdkReadinessManager.readinessManager.gate;
// Get the callbacks
const addListenerCB = gateMock.on.mock.calls[1][1];
const removeListenerCB = gateMock.on.mock.calls[0][1];
// Fake adding two listeners
addListenerCB(SDK_READY);
addListenerCB(SDK_READY);
// And then fake remove them.
removeListenerCB(SDK_READY);
removeListenerCB(SDK_READY);
emitReadyEvent(sdkReadinessManager.readinessManager);
expect(loggerMock.warn).toBeCalledWith(CLIENT_NO_LISTENER); // We get the warning.
});
test('The event callbacks should work as expected - If we end up removing the listeners for SDK_READY, it behaves as if it had none', () => {
const sdkReadinessManager = sdkReadinessManagerFactory(EventEmitterMock, fullSettings);
const gateMock = sdkReadinessManager.readinessManager.gate;
// Get the callbacks
const removeListenerCB = gateMock.on.mock.calls[0][1];
const addListenerCB = gateMock.on.mock.calls[1][1];
// Fake adding two listeners
addListenerCB(SDK_READY);
addListenerCB(SDK_READY);
// And then fake remove only one of them. The rest are events that we don't care about so it should not affect the count.
removeListenerCB(SDK_READY);
removeListenerCB(SDK_READY_TIMED_OUT);
removeListenerCB('random event');
emitReadyEvent(sdkReadinessManager.readinessManager);
expect(loggerMock.warn).not.toBeCalled(); // No warning when the SDK is ready as we still have one listener.
});
test('The event callbacks should work as expected - SDK_READY emits with expected internal callbacks', () => {
// the sdkReadinessManager expects more than one SDK_READY callback to not log the "No listeners" warning
const sdkReadinessManager = sdkReadinessManagerFactory(EventEmitterMock, fullSettings);
sdkReadinessManager.incInternalReadyCbCount();
const gateMock = sdkReadinessManager.readinessManager.gate;
// Get the callbacks
const removeListenerCB = gateMock.on.mock.calls[0][1];
const addListenerCB = gateMock.on.mock.calls[1][1];
// Fake adding two listeners and removing one
addListenerCB(SDK_READY);
addListenerCB(SDK_READY);
removeListenerCB(SDK_READY);
expect(loggerMock.warn).not.toBeCalled(); // We are adding/removing listeners to the ready event before it is ready, so no warnings are logged.
expect(loggerMock.error).not.toBeCalled(); // We are adding/removing listeners to the ready event before it is ready, so no errors are logged.
emitReadyEvent(sdkReadinessManager.readinessManager);
expect(loggerMock.warn).toBeCalled(); // As we had the same amount of listeners that the expected, we get a warning.
expect(loggerMock.error).not.toBeCalled(); // As we had at least one listener, we get no errors.
});
});
describe('SDK Readiness Manager - Promises', () => {
test('.whenReady() and .whenReadyFromCache() promises resolves when SDK_READY is emitted', async () => {
const sdkReadinessManager = sdkReadinessManagerFactory(EventEmitter, fullSettings);
// make the SDK ready from cache
sdkReadinessManager.readinessManager.splits.emit(SDK_SPLITS_CACHE_LOADED, { initialCacheLoad: false, lastUpdateTimestamp: null });
expect(await sdkReadinessManager.sdkStatus.whenReadyFromCache()).toEqual({ initialCacheLoad: false, lastUpdateTimestamp: null });
// validate error log for SDK_READY_FROM_CACHE
expect(loggerMock.error).not.toBeCalled();
sdkReadinessManager.readinessManager.gate.on(SDK_READY_FROM_CACHE, () => { });
expect(loggerMock.error).toBeCalledWith(ERROR_CLIENT_LISTENER, ['SDK_READY_FROM_CACHE']);
const readyFromCache = sdkReadinessManager.sdkStatus.whenReadyFromCache();
const ready = sdkReadinessManager.sdkStatus.whenReady();
// make the SDK ready
emitReadyEvent(sdkReadinessManager.readinessManager);
expect(await sdkReadinessManager.sdkStatus.whenReadyFromCache()).toEqual({ initialCacheLoad: false, lastUpdateTimestamp: null });
expect(await sdkReadinessManager.sdkStatus.whenReady()).toEqual({ initialCacheLoad: false, lastUpdateTimestamp: null });
let testPassedCount = 0;
function incTestPassedCount() { testPassedCount++; }
function throwTestFailed() { throw new Error('It should be resolved, not rejected.'); }
await readyFromCache.then(incTestPassedCount, throwTestFailed);
await ready.then(incTestPassedCount, throwTestFailed);
// any subsequent call to .whenReady() and .whenReadyFromCache() must be a resolved promise
await sdkReadinessManager.sdkStatus.whenReady().then(incTestPassedCount, throwTestFailed);
await sdkReadinessManager.sdkStatus.whenReadyFromCache().then(incTestPassedCount, throwTestFailed);
expect(testPassedCount).toBe(4);
});
test('.whenReady() and .whenReadyFromCache() promises reject when SDK_READY_TIMED_OUT is emitted before SDK_READY', async () => {
const sdkReadinessManagerForTimedout = sdkReadinessManagerFactory(EventEmitter, fullSettings);
const readyFromCacheForTimeout = sdkReadinessManagerForTimedout.sdkStatus.whenReadyFromCache();
const readyForTimeout = sdkReadinessManagerForTimedout.sdkStatus.whenReady();
emitTimeoutEvent(sdkReadinessManagerForTimedout.readinessManager); // make the SDK timeout
let testPassedCount = 0;
function incTestPassedCount() { testPassedCount++; }
function throwTestFailed() { throw new Error('It should rejected, not resolved.'); }
await readyFromCacheForTimeout.then(throwTestFailed, incTestPassedCount);
await readyForTimeout.then(throwTestFailed, incTestPassedCount);
// any subsequent call to .whenReady() and .whenReadyFromCache() must be a rejected promise until the SDK is ready
await sdkReadinessManagerForTimedout.sdkStatus.whenReadyFromCache().then(throwTestFailed, incTestPassedCount);
await sdkReadinessManagerForTimedout.sdkStatus.whenReady().then(throwTestFailed, incTestPassedCount);
// make the SDK ready
emitReadyEvent(sdkReadinessManagerForTimedout.readinessManager);
// once SDK_READY, `.whenReady()` returns a resolved promise
await sdkReadinessManagerForTimedout.sdkStatus.whenReady().then(incTestPassedCount, throwTestFailed);
await sdkReadinessManagerForTimedout.sdkStatus.whenReadyFromCache().then(incTestPassedCount, throwTestFailed);
expect(testPassedCount).toBe(6);
});
test('whenReady promise counts as an SDK_READY listener', (done) => {
let sdkReadinessManager = sdkReadinessManagerFactory(EventEmitter, fullSettings);
emitReadyEvent(sdkReadinessManager.readinessManager);
expect(loggerMock.warn).toBeCalledWith(CLIENT_NO_LISTENER); // We should get a warning if the SDK get's ready before calling the whenReady method or attaching a listener to the ready event
loggerMock.warn.mockClear();
sdkReadinessManager = sdkReadinessManagerFactory(EventEmitter, fullSettings);
sdkReadinessManager.sdkStatus.whenReady().then(() => {
expect('whenReady promise is resolved when the gate emits SDK_READY.');
done();
}, () => {
throw new Error('This should not be called as the promise is being resolved.');
});
emitReadyEvent(sdkReadinessManager.readinessManager);
expect(loggerMock.warn).not.toBeCalled(); // But if we have a listener or call the whenReady method, we get no warnings.
});
});
// @TODO: remove in next major
describe('SDK Readiness Manager - Ready promise', () => {
beforeEach(() => { loggerMock.mockClear(); });
test('ready promise count as a callback and resolves on SDK_READY', (done) => {
const sdkReadinessManager = sdkReadinessManagerFactory(EventEmitterMock, fullSettings);
const readyPromise = sdkReadinessManager.sdkStatus.ready();
// Get the callback
const readyEventCB = sdkReadinessManager.readinessManager.gate.once.mock.calls[0][1];
readyEventCB();
expect(loggerMock.warn).toBeCalledWith(CLIENT_NO_LISTENER); // We would get the warning if the SDK get\'s ready before attaching any callbacks to ready promise.
loggerMock.warn.mockClear();
readyPromise.then(() => {
expect('The ready promise is resolved when the gate emits SDK_READY.');
done();
}, () => {
throw new Error('This should not be called as the promise is being resolved.');
});
readyEventCB();
expect(loggerMock.warn).not.toBeCalled(); // But if we have a listener there are no warnings.
});
test('.ready() rejected promises have a default onRejected handler that just logs the error', (done) => {
const sdkReadinessManager = sdkReadinessManagerFactory(EventEmitterMock, fullSettings);
let readyForTimeout = sdkReadinessManager.sdkStatus.ready();
emitTimeoutEvent(sdkReadinessManager.readinessManager); // make the SDK "timed out"
readyForTimeout.then(
() => { throw new Error('It should be a promise that was rejected on SDK_READY_TIMED_OUT, not resolved.'); }
);
expect(loggerMock.error).not.toBeCalled(); // not called until promise is rejected
setTimeout(() => {
expect(loggerMock.error.mock.calls).toEqual([[timeoutErrorMessage]]); // If we don\'t handle the rejected promise, an error is logged.
readyForTimeout = sdkReadinessManager.sdkStatus.ready();
setTimeout(() => {
expect(loggerMock.error).lastCalledWith('Split SDK has emitted SDK_READY_TIMED_OUT event.'); // If we don\'t handle a new .ready() rejected promise, an error is logged.
readyForTimeout = sdkReadinessManager.sdkStatus.ready();
readyForTimeout
.then(() => { throw new Error(); })
.then(() => { throw new Error(); })
.catch((error) => {
expect(error instanceof Error).toBe(true);
expect(error.message).toBe('Split SDK has emitted SDK_READY_TIMED_OUT event.');
expect(loggerMock.error).toBeCalledTimes(2); // If we provide an onRejected handler, even chaining several onFulfilled handlers, the error is not logged.
done();
});
}, 0);
}, 0);
});
});