Update logs

AI-Session-Id: 5273e4be-ae33-4f9e-9d3a-5bba29e624f2
AI-Tool: claude-code
AI-Model: unknown

Author: EmilianoSanchez

src/logger/constants.ts

@@ -19,9 +19,8 @@ export const RETRIEVE_CLIENT_DEFAULT = 27;
 export const RETRIEVE_CLIENT_EXISTING = 28;
 export const RETRIEVE_MANAGER = 29;
 export const SYNC_OFFLINE_DATA = 30;
-export const SYNC_SPLITS_FETCH = 31;
-export const SYNC_SPLITS_UPDATE = 32;
-export const SYNC_RBS_UPDATE = 33;
+export const SYNC_FETCH = 31;
+export const SYNC_UPDATE = 32;
 export const STREAMING_NEW_MESSAGE = 35;
 export const SYNC_TASK_START = 36;
 export const SYNC_TASK_EXECUTE = 37;
@@ -38,7 +37,6 @@ export const NEW_FACTORY = 105;
 export const POLLING_SMART_PAUSING = 106;
 export const POLLING_START = 107;
 export const POLLING_STOP = 108;
-export const SYNC_SPLITS_FETCH_RETRY = 109;
 export const STREAMING_REFRESH_TOKEN = 110;
 export const STREAMING_RECONNECT = 111;
 export const STREAMING_CONNECTING = 112;
@@ -60,8 +58,8 @@ export const ENGINE_VALUE_INVALID = 200;
 export const ENGINE_VALUE_NO_ATTRIBUTES = 201;
 export const CLIENT_NO_LISTENER = 202;
 export const CLIENT_NOT_READY_FROM_CACHE = 203;
-export const SYNC_MYSEGMENTS_FETCH_RETRY = 204;
-export const SYNC_SPLITS_FETCH_FAILS = 205;
+export const SYNC_FETCH_RETRY = 204;
+export const SYNC_FETCH_FAILS = 205;
 export const STREAMING_PARSING_ERROR_FAILS = 206;
 export const STREAMING_PARSING_MESSAGE_FAILS = 207;
 export const STREAMING_FALLBACK = 208;
@@ -124,15 +122,12 @@ export const LOG_PREFIX_ENGINE = 'engine';
 export const LOG_PREFIX_ENGINE_COMBINER = LOG_PREFIX_ENGINE + ':combiner: ';
 export const LOG_PREFIX_ENGINE_MATCHER = LOG_PREFIX_ENGINE + ':matcher: ';
 export const LOG_PREFIX_ENGINE_VALUE = LOG_PREFIX_ENGINE + ':value: ';
-export const LOG_PREFIX_SYNC = 'sync';
-export const LOG_PREFIX_SYNC_MANAGER = LOG_PREFIX_SYNC + ':sync-manager: ';
-export const LOG_PREFIX_SYNC_OFFLINE = LOG_PREFIX_SYNC + ':offline: ';
-export const LOG_PREFIX_SYNC_STREAMING = LOG_PREFIX_SYNC + ':streaming: ';
-export const LOG_PREFIX_SYNC_SPLITS = LOG_PREFIX_SYNC + ':featureflag-changes: ';
-export const LOG_PREFIX_SYNC_SEGMENTS = LOG_PREFIX_SYNC + ':segment-changes: ';
-export const LOG_PREFIX_SYNC_MYSEGMENTS = LOG_PREFIX_SYNC + ':my-segments: ';
-export const LOG_PREFIX_SYNC_POLLING = LOG_PREFIX_SYNC + ':polling-manager: ';
-export const LOG_PREFIX_SYNC_SUBMITTERS = LOG_PREFIX_SYNC + ':submitter: ';
+export const LOG_PREFIX_SYNC = 'sync: ';
+export const LOG_PREFIX_SYNC_MANAGER = 'sync:sync-manager: ';
+export const LOG_PREFIX_SYNC_OFFLINE = 'sync:offline: ';
+export const LOG_PREFIX_SYNC_STREAMING = 'sync:streaming: ';
+export const LOG_PREFIX_SYNC_POLLING = 'sync:polling-manager: ';
+export const LOG_PREFIX_SYNC_SUBMITTERS = 'sync:submitter: ';
 export const LOG_PREFIX_IMPRESSIONS_TRACKER = 'impressions-tracker: ';
 export const LOG_PREFIX_EVENTS_TRACKER = 'events-tracker: ';
 export const LOG_PREFIX_UNIQUE_KEYS_TRACKER = 'unique-keys-tracker: ';

src/logger/messages/debug.ts

@@ -21,13 +21,12 @@ export const codesDebug: [number, string][] = codesInfo.concat([
   [c.RETRIEVE_MANAGER, 'Retrieving manager instance.'],
   // synchronizer
   [c.SYNC_OFFLINE_DATA, c.LOG_PREFIX_SYNC_OFFLINE + 'Feature flags data: \n%s'],
-  [c.SYNC_SPLITS_FETCH, c.LOG_PREFIX_SYNC_SPLITS + 'Spin up feature flags update using since = %s and rbSince = %s.'],
-  [c.SYNC_SPLITS_UPDATE, c.LOG_PREFIX_SYNC_SPLITS + 'New feature flags: %s. Removed feature flags: %s.'],
-  [c.SYNC_RBS_UPDATE, c.LOG_PREFIX_SYNC_SPLITS + 'New rule-based segments: %s. Removed rule-based segments: %s.'],
+  [c.SYNC_FETCH, c.LOG_PREFIX_SYNC + 'Spin up %s updates using since = %s and rbSince = %s.'],
+  [c.SYNC_UPDATE, c.LOG_PREFIX_SYNC + 'New %s: %s. Removed: %s.'],
   [c.STREAMING_NEW_MESSAGE, c.LOG_PREFIX_SYNC_STREAMING + 'New SSE message received, with data: %s.'],
-  [c.SYNC_TASK_START, c.LOG_PREFIX_SYNC + ': Starting %s. Running each %s millis'],
-  [c.SYNC_TASK_EXECUTE, c.LOG_PREFIX_SYNC + ': Running %s'],
-  [c.SYNC_TASK_STOP, c.LOG_PREFIX_SYNC + ': Stopping %s'],
+  [c.SYNC_TASK_START, c.LOG_PREFIX_SYNC + 'Starting %s. Running each %s millis'],
+  [c.SYNC_TASK_EXECUTE, c.LOG_PREFIX_SYNC + 'Running %s'],
+  [c.SYNC_TASK_STOP, c.LOG_PREFIX_SYNC + 'Stopping %s'],
   // initialization / settings validation
   [c.SETTINGS_SPLITS_FILTER, c.LOG_PREFIX_SETTINGS + ': feature flags filtering criteria is "%s".']
 ]);

src/logger/messages/info.ts

@@ -21,7 +21,6 @@ export const codesInfo: [number, string][] = codesWarn.concat([
   [c.POLLING_SMART_PAUSING, c.LOG_PREFIX_SYNC_POLLING + 'Turning segments data polling %s.'],
   [c.POLLING_START, c.LOG_PREFIX_SYNC_POLLING + 'Starting polling'],
   [c.POLLING_STOP, c.LOG_PREFIX_SYNC_POLLING + 'Stopping polling'],
-  [c.SYNC_SPLITS_FETCH_RETRY, c.LOG_PREFIX_SYNC_SPLITS + 'Retrying fetch of feature flags (attempt #%s). Reason: %s'],
   [c.SUBMITTERS_PUSH_FULL_QUEUE, c.LOG_PREFIX_SYNC_SUBMITTERS + 'Flushing full %s queue and resetting timer.'],
   [c.SUBMITTERS_PUSH, c.LOG_PREFIX_SYNC_SUBMITTERS + 'Pushing %s.'],
   [c.SUBMITTERS_PUSH_PAGE_HIDDEN, c.LOG_PREFIX_SYNC_SUBMITTERS + 'Flushing %s because page became hidden.'],

src/logger/messages/warn.ts

@@ -6,8 +6,8 @@ export const codesWarn: [number, string][] = codesError.concat([
   [c.ENGINE_VALUE_INVALID, c.LOG_PREFIX_ENGINE_VALUE + 'Value %s doesn\'t match with expected type.'],
   [c.ENGINE_VALUE_NO_ATTRIBUTES, c.LOG_PREFIX_ENGINE_VALUE + 'Defined attribute `%s`. No attributes received.'],
   // synchronizer
-  [c.SYNC_MYSEGMENTS_FETCH_RETRY, c.LOG_PREFIX_SYNC_MYSEGMENTS + 'Retrying fetch of memberships (attempt #%s). Reason: %s'],
-  [c.SYNC_SPLITS_FETCH_FAILS, c.LOG_PREFIX_SYNC_SPLITS + 'Error while doing fetch of feature flags. %s'],
+  [c.SYNC_FETCH_RETRY, c.LOG_PREFIX_SYNC + 'Retrying fetch of %s (attempt #%s). Reason: %s'],
+  [c.SYNC_FETCH_FAILS, c.LOG_PREFIX_SYNC + 'Error while doing fetch of %s. %s'],
   [c.STREAMING_PARSING_ERROR_FAILS, c.LOG_PREFIX_SYNC_STREAMING + 'Error parsing SSE error notification: %s'],
   [c.STREAMING_PARSING_MESSAGE_FAILS, c.LOG_PREFIX_SYNC_STREAMING + 'Error parsing SSE message notification: %s'],
   [c.STREAMING_FALLBACK, c.LOG_PREFIX_SYNC_STREAMING + 'Falling back to polling mode. Reason: %s'],

src/sync/__tests__/syncManagerOnline.spec.ts

@@ -10,6 +10,11 @@ jest.mock('../submitters/submitterManager', () => {
   };
 });
 
+// Mocked splitApi
+const splitApiMock = {
+  fetchSplitChanges: jest.fn()
+} as any;
+
 // Mocked storageManager
 const storageManagerMock = {
   splits: {
@@ -49,6 +54,7 @@ test('syncManagerOnline should start or not the submitter depending on user cons
   const syncManager = syncManagerOnlineFactory()({
     settings, // @ts-ignore
     storage: {},
+    splitApi: splitApiMock,
   });
   const submitterManager = syncManager.submitterManager!;
 
@@ -101,6 +107,7 @@ test('syncManagerOnline should syncAll a single time when sync is disabled', asy
   const syncManager = syncManagerOnlineFactory(() => pollingManagerMock, pushManagerFactoryMock)({
     settings, // @ts-ignore
     storage: { validateCache: () => { return Promise.resolve({ initialCacheLoad: true, lastUpdateTimestamp: undefined }); } },
+    splitApi: splitApiMock,
   });
 
   expect(pushManagerFactoryMock).not.toBeCalled();
@@ -170,6 +177,7 @@ test('syncManagerOnline should syncAll a single time when sync is disabled', asy
   const testSyncManager = syncManagerOnlineFactory(() => pollingManagerMock, pushManagerFactoryMock)({
     settings, // @ts-ignore
     storage: { validateCache: () => Promise.resolve({ initialCacheLoad: true, lastUpdateTimestamp: undefined }) },
+    splitApi: splitApiMock,
   });
 
   expect(pushManagerFactoryMock).toBeCalled();
@@ -188,7 +196,8 @@ test('syncManagerOnline should emit SDK_SPLITS_CACHE_LOADED if validateCache ret
   const params = {
     settings: fullSettings,
     storage: { validateCache: () => Promise.resolve({ initialCacheLoad: false, lastUpdateTimestamp }) },
-    readiness: { splits: { emit: jest.fn() } }
+    readiness: { splits: { emit: jest.fn() } },
+    splitApi: splitApiMock,
   }; // @ts-ignore
   const syncManager = syncManagerOnlineFactory()(params);
 

src/sync/polling/fetchers/configsFetcher.ts

@@ -1,7 +1,8 @@
 import { IDefinition, IDefinitionChangesResponse, IDefinitionCondition, IDefinitionMatcher } from '../../../dtos/types';
-import { IFetchDefinitionChanges, IResponse } from '../../../services/types';
+import { IResponse } from '../../../services/types';
 import { IDefinitionChangesFetcher } from './types';
 import SplitIO from '../../../../types/splitio';
+import { ISdkFactoryContextSync } from '../../../sdkFactory/types';
 
 type IConfigMatcher = {
   type: 'IS_EQUAL_TO';
@@ -54,9 +55,10 @@ export interface IConfigsResponse {
  * Factory of Configs fetcher.
  * Configs fetcher is a wrapper around `configs` API service that parses the response and handle errors.
  */
-export function configsFetcherFactory(fetchConfigs: IFetchDefinitionChanges): IDefinitionChangesFetcher {
+export function configsFetcherFactory(params: ISdkFactoryContextSync): IDefinitionChangesFetcher {
+  const fetchConfigs = params.splitApi.fetchConfigs;
 
-  return function configsFetcher(
+  function configsFetcher(
     since: number,
     noCache?: boolean,
     till?: number,
@@ -71,7 +73,10 @@ export function configsFetcherFactory(fetchConfigs: IFetchDefinitionChanges): ID
     return configsPromise
       .then<IConfigsResponse>((resp: IResponse) => resp.json())
       .then(convertConfigsResponseToDefinitionChangesResponse);
-  };
+  }
+
+  configsFetcher.type = 'configs' as const;
+  return configsFetcher;
 
 }
 

src/sync/polling/fetchers/splitChangesFetcher.ts

@@ -1,12 +1,12 @@
 import { ISettings } from '../../../types';
 import { IDefinitionChangesResponse } from '../../../dtos/types';
-import { IFetchDefinitionChanges, IResponse } from '../../../services/types';
-import { IStorageBase } from '../../../storages/types';
+import { IResponse } from '../../../services/types';
 import { FLAG_SPEC_VERSION } from '../../../utils/constants';
 import { base } from '../../../utils/settingsValidation';
 import { IDefinitionChangesFetcher } from './types';
-import { LOG_PREFIX_SYNC_SPLITS } from '../../../logger/constants';
+import { LOG_PREFIX_SYNC } from '../../../logger/constants';
 import { checkIfServerSide } from '../../../utils/key';
+import { ISdkFactoryContextSync } from '../../../sdkFactory/types';
 
 const PROXY_CHECK_INTERVAL_MILLIS_CS = 60 * 60 * 1000; // 1 hour in Client Side
 const PROXY_CHECK_INTERVAL_MILLIS_SS = 24 * PROXY_CHECK_INTERVAL_MILLIS_CS; // 24 hours in Server Side
@@ -20,13 +20,14 @@ function sdkEndpointOverridden(settings: ISettings) {
  * SplitChanges fetcher is a wrapper around `splitChanges` API service that parses the response and handle errors.
  */
 // @TODO breaking: drop support for Split Proxy below v5.10.0 and simplify the implementation
-export function splitChangesFetcherFactory(fetchSplitChanges: IFetchDefinitionChanges, settings: ISettings, storage: Pick<IStorageBase, 'splits' | 'rbSegments'>): IDefinitionChangesFetcher {
+export function splitChangesFetcherFactory(params: ISdkFactoryContextSync): IDefinitionChangesFetcher {
 
+  const { splitApi: { fetchSplitChanges }, settings, storage } = params;
   const log = settings.log;
   const PROXY_CHECK_INTERVAL_MILLIS = checkIfServerSide(settings) ? PROXY_CHECK_INTERVAL_MILLIS_SS : PROXY_CHECK_INTERVAL_MILLIS_CS;
   let lastProxyCheckTimestamp: number | undefined;
 
-  return function splitChangesFetcher(
+  function splitChangesFetcher(
     since: number,
     noCache?: boolean,
     till?: number,
@@ -44,7 +45,7 @@ export function splitChangesFetcherFactory(fetchSplitChanges: IFetchDefinitionCh
       .catch((err) => {
         // Handle proxy error with spec 1.3
         if ((!err.statusCode || err.statusCode === 400) && sdkEndpointOverridden(settings) && settings.sync.flagSpecVersion === FLAG_SPEC_VERSION) {
-          log.error(LOG_PREFIX_SYNC_SPLITS + 'Proxy error detected. Retrying with spec 1.2. If you are using Split Proxy, please upgrade to latest version');
+          log.error(LOG_PREFIX_SYNC + 'Proxy error detected. Retrying with spec 1.2. If you are using Split Proxy, please upgrade to latest version');
           lastProxyCheckTimestamp = Date.now();
           settings.sync.flagSpecVersion = '1.2'; // fallback to 1.2 spec
           return fetchSplitChanges(since, noCache, till); // retry request without rbSince
@@ -70,7 +71,7 @@ export function splitChangesFetcherFactory(fetchSplitChanges: IFetchDefinitionCh
 
         // Proxy recovery
         if (lastProxyCheckTimestamp) {
-          log.info(LOG_PREFIX_SYNC_SPLITS + 'Proxy error recovered');
+          log.info(LOG_PREFIX_SYNC + 'Proxy error recovered');
           lastProxyCheckTimestamp = undefined;
           return splitChangesFetcher(-1, undefined, undefined, -1)
             .then((splitChangesResponse: IDefinitionChangesResponse) =>
@@ -81,6 +82,8 @@ export function splitChangesFetcherFactory(fetchSplitChanges: IFetchDefinitionCh
 
         return data;
       });
-  };
+  }
 
+  splitChangesFetcher.type = 'feature flags' as const;
+  return splitChangesFetcher;
 }

src/sync/polling/fetchers/types.ts

@@ -1,13 +1,15 @@
 import { IDefinitionChangesResponse, ISegmentChangesResponse, IMembershipsResponse } from '../../../dtos/types';
 import { IResponse } from '../../../services/types';
 
-export type IDefinitionChangesFetcher = (
+export type IDefinitionChangesFetcher = ((
   since: number,
   noCache?: boolean,
   till?: number,
   rbSince?: number,
   decorator?: (promise: Promise<IResponse>) => Promise<IResponse>
-) => Promise<IDefinitionChangesResponse>
+) => Promise<IDefinitionChangesResponse>) & {
+  type: 'configs' | 'feature flags'
+}
 
 export type ISegmentChangesFetcher = (
   since: number,

src/sync/polling/pollingManagerCS.ts

@@ -3,26 +3,28 @@ import { forOwn } from '../../utils/lang';
 import { IReadinessManager } from '../../readiness/types';
 import { IStorageSync } from '../../storages/types';
 import { mySegmentsSyncTaskFactory } from './syncTasks/mySegmentsSyncTask';
-import { splitsSyncTaskFactory } from './syncTasks/splitsSyncTask';
+import { definitionsSyncTaskFactory } from './syncTasks/definitionsSyncTask';
 import { getMatching } from '../../utils/key';
 import { SDK_SPLITS_ARRIVED, SDK_SEGMENTS_ARRIVED } from '../../readiness/constants';
 import { POLLING_SMART_PAUSING, POLLING_START, POLLING_STOP } from '../../logger/constants';
 import { ISdkFactoryContextSync } from '../../sdkFactory/types';
 import { usesSegmentsSync } from '../../storages/AbstractSplitsCacheSync';
 import { SdkUpdateMetadata } from '../../../types/splitio';
+import { IDefinitionChangesFetcher } from './fetchers/types';
 
 /**
  * Expose start / stop mechanism for polling data from services.
  * For client-side API with multiple clients.
  */
 export function pollingManagerCSFactory(
-  params: ISdkFactoryContextSync
+  params: ISdkFactoryContextSync,
+  definitionChangesFetcher: IDefinitionChangesFetcher
 ): IPollingManagerCS {
 
   const { splitApi, storage, readiness, settings } = params;
   const log = settings.log;
 
-  const splitsSyncTask = splitsSyncTaskFactory(splitApi.fetchSplitChanges, storage, readiness, settings, true);
+  const definitionsSyncTask = definitionsSyncTaskFactory(definitionChangesFetcher, storage, readiness, settings, true);
 
   // Map of matching keys to their corresponding MySegmentsSyncTask.
   const mySegmentsSyncTasks: Record<string, IMySegmentsSyncTask> = {};
@@ -44,7 +46,7 @@ export function pollingManagerCSFactory(
 
   // smart pausing
   readiness.splits.on(SDK_SPLITS_ARRIVED, () => {
-    if (!splitsSyncTask.isRunning()) return; // noop if not doing polling
+    if (!definitionsSyncTask.isRunning()) return; // noop if not doing polling
     const usingSegments = usesSegmentsSync(storage);
     if (usingSegments !== mySegmentsSyncTask.isRunning()) {
       log.info(POLLING_SMART_PAUSING, [usingSegments ? 'ON' : 'OFF']);
@@ -71,31 +73,31 @@ export function pollingManagerCSFactory(
   }
 
   return {
-    splitsSyncTask,
+    definitionsSyncTask,
     segmentsSyncTask: mySegmentsSyncTask,
 
     // Start periodic fetching (polling)
     start() {
       log.info(POLLING_START);
 
-      splitsSyncTask.start();
+      definitionsSyncTask.start();
       if (usesSegmentsSync(storage)) startMySegmentsSyncTasks();
     },
 
     // Stop periodic fetching (polling)
     stop() {
       log.info(POLLING_STOP);
 
-      if (splitsSyncTask.isRunning()) splitsSyncTask.stop();
+      if (definitionsSyncTask.isRunning()) definitionsSyncTask.stop();
       stopMySegmentsSyncTasks();
     },
 
     // Used by SyncManager to know if running in polling mode.
-    isRunning: splitsSyncTask.isRunning,
+    isRunning: definitionsSyncTask.isRunning,
 
-    // fetch splits and segments
+    // fetch definitions and segments
     syncAll() {
-      const promises = [splitsSyncTask.execute()];
+      const promises = [definitionsSyncTask.execute()];
       forOwn(mySegmentsSyncTasks, (mySegmentsSyncTask) => {
         promises.push(mySegmentsSyncTask.execute());
       });

src/sync/polling/pollingManagerSS.ts

@@ -1,36 +1,38 @@
-import { splitsSyncTaskFactory } from './syncTasks/splitsSyncTask';
+import { definitionsSyncTaskFactory } from './syncTasks/definitionsSyncTask';
 import { segmentsSyncTaskFactory } from './syncTasks/segmentsSyncTask';
-import { IPollingManager, ISegmentsSyncTask, ISplitsSyncTask } from './types';
+import { IPollingManager, ISegmentsSyncTask, IDefinitionsSyncTask } from './types';
 import { POLLING_START, POLLING_STOP, LOG_PREFIX_SYNC_POLLING } from '../../logger/constants';
 import { ISdkFactoryContextSync } from '../../sdkFactory/types';
+import { IDefinitionChangesFetcher } from './fetchers/types';
 
 /**
  * Expose start / stop mechanism for pulling data from services.
  */
 export function pollingManagerSSFactory(
-  params: ISdkFactoryContextSync
+  params: ISdkFactoryContextSync,
+  definitionChangesFetcher: IDefinitionChangesFetcher
 ): IPollingManager {
 
   const { splitApi, storage, readiness, settings } = params;
   const log = settings.log;
 
-  const splitsSyncTask: ISplitsSyncTask = splitsSyncTaskFactory(splitApi.fetchSplitChanges, storage, readiness, settings);
+  const definitionsSyncTask: IDefinitionsSyncTask = definitionsSyncTaskFactory(definitionChangesFetcher, storage, readiness, settings);
   const segmentsSyncTask: ISegmentsSyncTask = segmentsSyncTaskFactory(splitApi.fetchSegmentChanges, storage, readiness, settings);
 
   return {
-    splitsSyncTask,
+    definitionsSyncTask,
     segmentsSyncTask,
 
     // Start periodic fetching (polling)
     start() {
       log.info(POLLING_START);
-      log.debug(LOG_PREFIX_SYNC_POLLING + `Feature flags will be refreshed each ${settings.scheduler.featuresRefreshRate} millis`);
-      log.debug(LOG_PREFIX_SYNC_POLLING + `Segments will be refreshed each ${settings.scheduler.segmentsRefreshRate} millis`);
+      log.debug(LOG_PREFIX_SYNC_POLLING + `${definitionChangesFetcher.type} will be refreshed each ${settings.scheduler.featuresRefreshRate} millis`);
+      log.debug(LOG_PREFIX_SYNC_POLLING + `segments will be refreshed each ${settings.scheduler.segmentsRefreshRate} millis`);
 
-      const startingUp = splitsSyncTask.start();
+      const startingUp = definitionsSyncTask.start();
       if (startingUp) {
         startingUp.then(() => {
-          if (splitsSyncTask.isRunning()) segmentsSyncTask.start();
+          if (definitionsSyncTask.isRunning()) segmentsSyncTask.start();
         });
       }
     },
@@ -39,16 +41,16 @@ export function pollingManagerSSFactory(
     stop() {
       log.info(POLLING_STOP);
 
-      if (splitsSyncTask.isRunning()) splitsSyncTask.stop();
+      if (definitionsSyncTask.isRunning()) definitionsSyncTask.stop();
       if (segmentsSyncTask.isRunning()) segmentsSyncTask.stop();
     },
 
     // Used by SyncManager to know if running in polling mode.
-    isRunning: splitsSyncTask.isRunning,
+    isRunning: definitionsSyncTask.isRunning,
 
     syncAll() {
-      // fetch splits and segments. There is no need to catch this promise (`SplitChangesUpdater` is always resolved with a boolean value)
-      return splitsSyncTask.execute().then(() => {
+      // fetch definitions and segments. There is no need to catch this promise (`DefinitionChangesUpdater` is always resolved with a boolean value)
+      return definitionsSyncTask.execute().then(() => {
         return segmentsSyncTask.execute();
       });
     }