Merge branch 'development' of github.com:splitio/javascript-commons into fme-12059

Author: ZamoraEmmanuel

.nvmrc

@@ -1 +1 @@
-lts/*
+22

CHANGES.txt

@@ -1,3 +1,6 @@
+2.10.1 (December 18, 2025)
+ - Bugfix - Handle `null` prerequisites properly.
+
 2.10.0 (December 16, 2025)
  - Added property `impressionsDisabled` in getTreatment(s) `evaluationOptions` parameter, to disable impressions per evaluations.
 

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@splitsoftware/splitio-commons",
-  "version": "2.10.0",
+  "version": "2.10.1",
   "description": "Split JavaScript SDK common components",
   "main": "cjs/index.js",
   "module": "esm/index.js",

package.json

@@ -220,7 +220,7 @@ export interface ISplit {
   changeNumber: number,
   status: 'ACTIVE' | 'ARCHIVED',
   conditions: ISplitCondition[],
-  prerequisites?: {
+  prerequisites?: null | {
     n: string,
     ts: string[]
   }[]

src/dtos/types.ts

@@ -73,6 +73,9 @@ test('MATCHER PREREQUISITES / Edge cases', () => {
   const matcherTrueNoPrerequisites = prerequisitesMatcherContext(undefined, mockStorage, loggerMock);
   expect(matcherTrueNoPrerequisites({ key: 'a-key' }, evaluateFeature)).toBe(true);
 
+  const matcherTruePrerequisitesNull = prerequisitesMatcherContext(null, mockStorage, loggerMock);
+  expect(matcherTruePrerequisitesNull({ key: 'a-key' }, evaluateFeature)).toBe(true);
+
   const matcherTrueEmptyPrerequisites = prerequisitesMatcherContext([], mockStorage, loggerMock);
   expect(matcherTrueEmptyPrerequisites({ key: 'a-key' }, evaluateFeature)).toBe(true);
 

src/evaluator/matchers/__tests__/prerequisites.spec.ts

@@ -4,10 +4,12 @@ import { ILogger } from '../../logger/types';
 import { thenable } from '../../utils/promise/thenable';
 import { IDependencyMatcherValue, ISplitEvaluator } from '../types';
 
-export function prerequisitesMatcherContext(prerequisites: ISplit['prerequisites'] = [], storage: IStorageSync | IStorageAsync, log: ILogger) {
+export function prerequisitesMatcherContext(prerequisites: ISplit['prerequisites'], storage: IStorageSync | IStorageAsync, log: ILogger) {
 
   return function prerequisitesMatcher({ key, attributes }: IDependencyMatcherValue, splitEvaluator: ISplitEvaluator): MaybeThenable<boolean> {
 
+    prerequisites = prerequisites == null ? [] : prerequisites;
+
     function evaluatePrerequisite(prerequisite: { n: string; ts: string[] }): MaybeThenable<boolean> {
       const evaluation = splitEvaluator(log, key, prerequisite.n, attributes, storage);
       return thenable(evaluation) ?

src/evaluator/matchers/prerequisites.ts

@@ -39,7 +39,7 @@ export function segmentChangesUpdaterFactory(
 
   function updateSegment(segmentName: string, noCache?: boolean, till?: number, fetchOnlyNew?: boolean, retries?: number): Promise<boolean> {
     log.debug(`${LOG_PREFIX_SYNC_SEGMENTS}Processing segment ${segmentName}`);
-    let sincePromise = Promise.resolve(segments.getChangeNumber(segmentName));
+    const sincePromise = Promise.resolve(segments.getChangeNumber(segmentName));
 
     return sincePromise.then(since => {
       // if fetchOnlyNew flag, avoid processing already fetched segments

src/sync/polling/updaters/segmentChangesUpdater.ts

@@ -38,7 +38,7 @@ export function submitterManagerFactory(params: ISdkFactoryContextSync): ISubmit
     execute(onlyTelemetry?: boolean) {
       const promises = onlyTelemetry ? [] : submitters.map(submitter => submitter.execute());
       if (telemetrySubmitter) promises.push(telemetrySubmitter.execute());
-      return Promise.all(promises);
+      return Promise.all(promises).then(() => { });
     },
 
     isExecuting() {

src/sync/submitters/submitterManager.ts

@@ -237,5 +237,5 @@ export type TelemetryConfigStatsPayload = TelemetryConfigStats & {
 export interface ISubmitterManager extends ISyncTask {
   start(onlyTelemetry?: boolean): void,
   stop(allExceptTelemetry?: boolean): void,
-  execute(onlyTelemetry?: boolean): Promise<any>
+  execute(onlyTelemetry?: boolean): Promise<void>
 }