patching chardet.universaldetector.MINIMUM_THRESHOLD

[stanislavlevin]

Patching of chardet.universaldetector.MINIMUM_THRESHOLD has been added in:
2f5a5e5#diff-8a51311f10a4c83f2aeafd6e2421c73dc4119c961d1c1f1fab7192c6e6f98aaeR59

In that version of bundled chardet the MINIMUM_THRESHOLD was the module level variable of chardet.universaldetector:

sqlmap/thirdparty/chardet/universaldetector.py

Line 38 in 2f5a5e5

MINIMUM_THRESHOLD = 0.20

Later with updated chardet the MINIMUM_THRESHOLD has been moved:
bacf188#diff-bd2ab5211bb7e6b450f2c5eb45b93fe7f4475f9c5058b52d756dfacc4bc43677L38

but the patch reference was not updated.

chardet 7.0 dropped chardet.universaldetector module completely.

Is the patching of MINIMUM_THRESHOLD still needed? Looks like it does nothing atm.

[ashishtiwari03]

Hi

It looks like MINIMUM_THRESHOLD is now defined inside the UniversalDetector class:

UniversalDetector.MINIMUM_THRESHOLD

However, the current patch in lib/core/patch.py modifies:

thirdparty.chardet.universaldetector.MINIMUM_THRESHOLD

which no longer exists.

Would the preferred fix be to update the patch to:

thirdparty.chardet.universaldetector.UniversalDetector.MINIMUM_THRESHOLD

or should the patch be removed entirely if it's no longer necessary?

I'm happy to prepare a PR once the intended behavior is confirmed.