chore: remove custom vulncheck and github poc features

dervoeti · dervoeti · commit f3737d3eff03 · 2025-04-01T20:07:59.000+02:00
diff --git a/backend/application/commons/migrations/0017_remove_settings_background_exploits_import_crontab_hours_and_more.py b/backend/application/commons/migrations/0017_remove_settings_background_exploits_import_crontab_hours_and_more.py
@@ -0,0 +1,29 @@
+# Generated by Django 5.1.7 on 2025-04-01 18:00
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("commons", "0016_merge_20250328_1143"),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name="settings",
+            name="background_exploits_import_crontab_hours",
+        ),
+        migrations.RemoveField(
+            model_name="settings",
+            name="background_exploits_import_crontab_minutes",
+        ),
+        migrations.RemoveField(
+            model_name="settings",
+            name="exploits_last_sync_github_poc",
+        ),
+        migrations.RemoveField(
+            model_name="settings",
+            name="exploits_last_sync_vulncheck_kev",
+        ),
+    ]
diff --git a/backend/application/commons/models.py b/backend/application/commons/models.py
@@ -166,22 +166,6 @@ class Settings(Model):
     feature_disable_user_login = BooleanField(default=False, help_text="Disable user login")
     feature_general_rules_need_approval = BooleanField(default=False, help_text="General rules need approval")
 
-    exploits_last_sync_vulncheck_kev = DateTimeField(null=True, help_text="Last sync date of Vulncheck KEV data")
-
-    exploits_last_sync_github_poc = DateTimeField(null=True, help_text="Last sync date of GitHub PoC data")
-
-    background_exploits_import_crontab_minutes = IntegerField(
-        default=0,
-        validators=[MinValueValidator(0), MaxValueValidator(59)],
-        help_text="Minutes crontab expression for exploit data import",
-    )
-
-    background_exploits_import_crontab_hours = IntegerField(
-        default=4,
-        validators=[MinValueValidator(0), MaxValueValidator(23)],
-        help_text="Hours crontab expression for exploit data import (UTC)",
-    )
-
     risk_acceptance_expiry_days = IntegerField(
         default=30,
         validators=[MinValueValidator(0), MaxValueValidator(999999)],
diff --git a/backend/application/core/api/filters.py b/backend/application/core/api/filters.py
@@ -270,8 +270,6 @@ class ObservationFilter(FilterSet):
             ("origin_component_location", "origin_component_location"),
             ("has_potential_duplicates", "has_potential_duplicates"),
             ("patch_available", "patch_available"),
-            ("in_vulncheck_kev", "in_vulncheck_kev"),
-            ("exploit_available", "exploit_available"),
             ("origin_component_purl_type", "origin_component_purl_type"),
         ),
     )
@@ -291,8 +289,6 @@ class Meta:  # pylint: disable=duplicate-code
             "origin_service",
             "has_potential_duplicates",
             "patch_available",
-            "in_vulncheck_kev",
-            "exploit_available",
             "origin_component_purl_type",
         ]
 
diff --git a/backend/application/core/migrations/0072_remove_observation_core_observ_in_vuln_bb4e6d_idx_and_more.py b/backend/application/core/migrations/0072_remove_observation_core_observ_in_vuln_bb4e6d_idx_and_more.py
@@ -0,0 +1,29 @@
+# Generated by Django 5.1.7 on 2025-04-01 18:00
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("core", "0071_merge_20250331_1956"),
+    ]
+
+    operations = [
+        migrations.RemoveIndex(
+            model_name="observation",
+            name="core_observ_in_vuln_bb4e6d_idx",
+        ),
+        migrations.RemoveIndex(
+            model_name="observation",
+            name="core_observ_exploit_bc386d_idx",
+        ),
+        migrations.RemoveField(
+            model_name="observation",
+            name="exploit_available",
+        ),
+        migrations.RemoveField(
+            model_name="observation",
+            name="in_vulncheck_kev",
+        ),
+    ]
diff --git a/backend/application/core/models.py b/backend/application/core/models.py
@@ -454,8 +454,6 @@ class Observation(Model):
         decimal_places=3,
         null=True,
     )
-    in_vulncheck_kev = BooleanField(default=False)
-    exploit_available = BooleanField(default=False)
     found = DateField(null=True)
     scanner = CharField(max_length=255, blank=True)
     upload_filename = CharField(max_length=255, blank=True)
@@ -532,8 +530,6 @@ class Meta:
             Index(fields=["stackable_score"]),
             Index(fields=["scanner"]),
             Index(fields=["patch_available"]),
-            Index(fields=["in_vulncheck_kev"]),
-            Index(fields=["exploit_available"]),
             Index(fields=["upgrade_impact_score"]),
         ]
 
diff --git a/backend/application/core/services/exploits.py b/backend/application/core/services/exploits.py
diff --git a/backend/application/core/tasks.py b/backend/application/core/tasks.py
@@ -5,7 +5,6 @@
 
 from application.commons import settings_static
 from application.commons.services.tasks import handle_task_exception
-from application.core.services.exploits import import_github_poc, import_vulncheck_kev
 from application.core.services.housekeeping import (
     delete_inactive_branches_and_set_flags,
 )
@@ -34,25 +33,6 @@ def task_branch_housekeeping() -> None:
     logger.info("--- Branch_housekeeping - finished ---")
 
 
-@db_periodic_task(
-    crontab(
-        minute=settings_static.background_exploits_import_crontab_minutes,
-        hour=settings_static.background_exploits_import_crontab_hours,
-    )
-)
-@lock_task("import_exploits")
-def task_import_exploits() -> None:
-    logger.info("--- Import_Exploits - start ---")
-
-    try:
-        import_vulncheck_kev()
-        import_github_poc()
-    except Exception as e:
-        handle_task_exception(e)
-
-    logger.info("--- Import_Exploits - finished ---")
-
-
 @db_periodic_task(
     crontab(
         minute=settings_static.risk_acceptance_expiry_crontab_minute,
diff --git a/backend/application/exploits/tasks.py b/backend/application/exploits/tasks.py
diff --git a/frontend/src/commons/settings/SettingsEdit.tsx b/frontend/src/commons/settings/SettingsEdit.tsx
@@ -172,26 +172,6 @@ const SettingsEdit = () => {
                             sx={{ marginBottom: 2 }}
                         />
                     </Stack>
-                    <Stack direction="row" spacing={2}>
-                        <NumberInput
-                            source="background_exploits_import_crontab_hours"
-                            label="Exploit data import crontab (hours)"
-                            min={0}
-                            step={1}
-                            validate={validate_0_23}
-                            helperText="Hours crontab expression for exploit data import (UTC)"
-                            sx={{ marginBottom: 2 }}
-                        />
-                        <NumberInput
-                            source="background_exploits_import_crontab_minutes"
-                            label="Exploit data import crontab (minutes)"
-                            min={0}
-                            step={1}
-                            validate={validate_0_59}
-                            helperText="Minutes crontab expression for exploit data import"
-                            sx={{ marginBottom: 2 }}
-                        />
-                    </Stack>
 
                     <Divider flexItem sx={{ marginTop: 2, marginBottom: 2 }} />
                     <Typography variant="h6" sx={{ marginBottom: 2 }}>
diff --git a/frontend/src/commons/settings/SettingsShow.tsx b/frontend/src/commons/settings/SettingsShow.tsx
@@ -53,14 +53,6 @@ const SettingsShowComponent = () => {
                                 <NumberField source="background_epss_import_crontab_minute" />
                             </Labeled>
                         </Stack>
-                        <Stack direction="row" spacing={2}>
-                            <Labeled label="Exploit data import crontab (minutes)">
-                                <NumberField source="background_exploits_import_crontab_minutes" />
-                            </Labeled>
-                            <Labeled label="Exploit data import crontab (hours)">
-                                <NumberField source="background_exploits_import_crontab_hours" />
-                            </Labeled>
-                        </Stack>
                     </Paper>
 
                     <Paper sx={{ marginBottom: 2, padding: 2 }}>
diff --git a/frontend/src/core/observations/ObservationEmbeddedList.tsx b/frontend/src/core/observations/ObservationEmbeddedList.tsx
@@ -125,8 +125,6 @@ function listFilters(product: Product) {
     }
     // filters.push(<TextInput source="origin_component_location" label="Component location" />);
     filters.push(<NullableBooleanInput source="patch_available" label="Patch available" alwaysOn />);
-    filters.push(<NullableBooleanInput source="exploit_available" label="Exploit available" alwaysOn />);
-    filters.push(<NullableBooleanInput source="in_vulncheck_kev" label="Listed in Vulncheck KEV" alwaysOn />);
 
     return filters;
 }
diff --git a/frontend/src/core/observations/ObservationList.tsx b/frontend/src/core/observations/ObservationList.tsx
@@ -74,9 +74,7 @@ const listFilters = () => [
     <AutocompleteInputMedium source="age" choices={AGE_CHOICES} />,
     <NullableBooleanInput source="has_potential_duplicates" label="Duplicates" />,
     <NullableBooleanInputWide source="patch_available" label="Patch available" alwaysOn />,
-    <NullableBooleanInputWide source="exploit_available" label="Exploit available" alwaysOn />,
     <NullableBooleanInput source="cve_known_exploited" label="CVE exploited" alwaysOn />,
-    <NullableBooleanInputWide source="in_vulncheck_kev" label="Listed in Vulncheck KEV" alwaysOn />,
     <AutocompleteInput
         source="origin_component_purl_type"
         label="Component type"
diff --git a/frontend/src/core/observations/ObservationShow.tsx b/frontend/src/core/observations/ObservationShow.tsx
diff --git a/frontend/src/core/types.ts b/frontend/src/core/types.ts
