chore: remove pagination warnings (SecObserve#4208)

StefanFl · web-flow · commit fdaa7e39e0f9 · 2026-04-14T11:44:57.000+02:00
diff --git a/backend/application/access_control/queries/api_token.py b/backend/application/access_control/queries/api_token.py
@@ -19,7 +19,7 @@ def get_api_tokens() -> QuerySet[API_Token_Multiple]:
     if user is None:
         return API_Token_Multiple.objects.none()
 
-    api_tokens = API_Token_Multiple.objects.all()
+    api_tokens = API_Token_Multiple.objects.all().order_by("id")
 
     if user.is_superuser:
         return api_tokens
@@ -33,7 +33,7 @@ def get_api_tokens_for_user(given_user: User) -> QuerySet[API_Token_Multiple]:
     if current_user is None:
         return API_Token_Multiple.objects.none()
 
-    api_tokens = API_Token_Multiple.objects.filter(user=given_user)
+    api_tokens = API_Token_Multiple.objects.filter(user=given_user).order_by("id")
 
     if current_user.is_superuser:
         return api_tokens
diff --git a/backend/application/access_control/queries/authorization_group.py b/backend/application/access_control/queries/authorization_group.py
@@ -10,7 +10,7 @@ def get_authorization_groups() -> QuerySet[Authorization_Group]:
     if user is None:
         return Authorization_Group.objects.none()
 
-    authorization_groups = Authorization_Group.objects.all()
+    authorization_groups = Authorization_Group.objects.all().order_by("id")
 
     if user.is_superuser:
         return authorization_groups
diff --git a/backend/application/access_control/queries/authorization_group_member.py b/backend/application/access_control/queries/authorization_group_member.py
@@ -28,7 +28,7 @@ def get_authorization_group_members() -> QuerySet[Authorization_Group_Member]:
     if user is None:
         return Authorization_Group_Member.objects.none()
 
-    authorization_group_members = Authorization_Group_Member.objects.all()
+    authorization_group_members = Authorization_Group_Member.objects.all().order_by("id")
 
     if user.is_superuser:
         return authorization_group_members
diff --git a/backend/application/access_control/queries/user.py b/backend/application/access_control/queries/user.py
@@ -37,7 +37,7 @@ def get_users() -> QuerySet[User]:
     if user is None:
         return User.objects.none()
 
-    users = User.objects.all()
+    users = User.objects.all().order_by("id")
 
     if user.is_superuser or not user.is_external:
         return users
@@ -53,7 +53,7 @@ def get_users_without_api_tokens() -> QuerySet[User]:
     if user is None:
         return User.objects.none()
 
-    users = User.objects.exclude(username__startswith="-product-")
+    users = User.objects.exclude(username__startswith="-product-").order_by("id")
 
     if user.is_superuser:
         return users
diff --git a/backend/application/core/queries/branch.py b/backend/application/core/queries/branch.py
@@ -37,7 +37,7 @@ def get_branches(with_annotations: bool = False) -> QuerySet[Branch]:
     if user is None:
         return Branch.objects.none()
 
-    branches = Branch.objects.all()
+    branches = Branch.objects.all().order_by("id")
     branches = _add_annotations(branches, with_annotations)
 
     if not user.is_superuser:
diff --git a/backend/application/core/queries/component.py b/backend/application/core/queries/component.py
@@ -30,7 +30,7 @@ def get_components() -> QuerySet[Component]:
     if user is None:
         return Component.objects.none()
 
-    components = Component.objects.all()
+    components = Component.objects.all().order_by("id")
 
     if not user.is_superuser:
         product_members = Product_Member.objects.filter(product=OuterRef("product_id"), user=user)
diff --git a/backend/application/core/queries/observation.py b/backend/application/core/queries/observation.py
@@ -30,7 +30,7 @@ def get_observations() -> QuerySet[Observation]:
     if user is None:
         return Observation.objects.none()
 
-    observations = Observation.objects.all()
+    observations = Observation.objects.all().order_by("id")
 
     if not user.is_superuser:
         product_members = Product_Member.objects.filter(product=OuterRef("product_id"), user=user)
@@ -87,7 +87,7 @@ def get_observations_for_vulnerability_check(
             upload_filename="",
             api_configuration_name="",
             origin_service__name=service,
-        )
+        ).order_by("id")
 
     return Observation.objects.filter(
         product=product,
@@ -96,7 +96,7 @@ def get_observations_for_vulnerability_check(
         upload_filename="",
         api_configuration_name="",
         origin_service__isnull=True,
-    )
+    ).order_by("id")
 
 
 def get_evidences() -> QuerySet[Evidence]:
@@ -105,7 +105,7 @@ def get_evidences() -> QuerySet[Evidence]:
     if user is None:
         return Evidence.objects.none()
 
-    evidences = Evidence.objects.all()
+    evidences = Evidence.objects.all().order_by("id")
 
     if not user.is_superuser:
         product_members = Product_Member.objects.filter(product=OuterRef("observation__product_id"), user=user)
@@ -148,7 +148,7 @@ def get_potential_duplicates() -> QuerySet[Potential_Duplicate]:
     if user is None:
         return Potential_Duplicate.objects.none()
 
-    potential_duplicates = Potential_Duplicate.objects.all()
+    potential_duplicates = Potential_Duplicate.objects.all().order_by("id")
 
     if not user.is_superuser:
         product_members = Product_Member.objects.filter(product=OuterRef("observation__product_id"), user=user)
@@ -198,7 +198,7 @@ def get_observation_logs() -> QuerySet[Observation_Log]:
     if user is None:
         return Observation_Log.objects.none()
 
-    observation_logs = Observation_Log.objects.all()
+    observation_logs = Observation_Log.objects.all().order_by("id")
 
     if not user.is_superuser:
         product_members = Product_Member.objects.filter(product=OuterRef("observation__product_id"), user=user)
diff --git a/backend/application/core/queries/product.py b/backend/application/core/queries/product.py
@@ -69,7 +69,7 @@ def get_products(
     if user is None:
         return Product.objects.none()
 
-    products = Product.objects.all()
+    products = Product.objects.all().order_by("id")
 
     if is_product_group is not None:
         products = _add_annotations(products, is_product_group, with_observation_annotations, with_metrics_annotations)
diff --git a/backend/application/core/queries/product_member.py b/backend/application/core/queries/product_member.py
@@ -29,7 +29,7 @@ def get_product_members() -> QuerySet[Product_Member]:
     if user is None:
         return Product_Member.objects.none()
 
-    product_members = Product_Member.objects.exclude(user__username__startswith="-product-")
+    product_members = Product_Member.objects.exclude(user__username__startswith="-product-").order_by("id")
 
     if user.is_superuser:
         return product_members
@@ -53,7 +53,7 @@ def get_product_authorization_group_members() -> QuerySet[Product_Authorization_
     if user is None:
         return Product_Authorization_Group_Member.objects.none()
 
-    product_authorization_group_members = Product_Authorization_Group_Member.objects.all()
+    product_authorization_group_members = Product_Authorization_Group_Member.objects.all().order_by("id")
 
     if user.is_superuser:
         return product_authorization_group_members
diff --git a/backend/application/core/queries/service.py b/backend/application/core/queries/service.py
@@ -37,7 +37,7 @@ def get_services(with_annotations: bool = False) -> QuerySet[Service]:
     if user is None:
         return Service.objects.none()
 
-    services = Service.objects.all()
+    services = Service.objects.all().order_by("id")
     services = _add_annotations(services, with_annotations)
 
     if not user.is_superuser:
diff --git a/backend/application/import_observations/queries/api_configuration.py b/backend/application/import_observations/queries/api_configuration.py
@@ -34,7 +34,7 @@ def get_api_configurations() -> QuerySet[Api_Configuration]:
     if user is None:
         return Api_Configuration.objects.none()
 
-    api_configurations = Api_Configuration.objects.all()
+    api_configurations = Api_Configuration.objects.all().order_by("id")
 
     if not user.is_superuser:
         product_members = Product_Member.objects.filter(product=OuterRef("product_id"), user=user)
diff --git a/backend/application/import_observations/queries/vulnerability_check.py b/backend/application/import_observations/queries/vulnerability_check.py
@@ -12,7 +12,7 @@ def get_vulnerability_checks() -> QuerySet[Vulnerability_Check]:
     if user is None:
         return Vulnerability_Check.objects.none()
 
-    vulnerability_checks = Vulnerability_Check.objects.all()
+    vulnerability_checks = Vulnerability_Check.objects.all().order_by("id")
 
     if not user.is_superuser:
         product_members = Product_Member.objects.filter(product=OuterRef("product_id"), user=user)
diff --git a/backend/application/licenses/queries/concluded_license.py b/backend/application/licenses/queries/concluded_license.py
@@ -21,7 +21,7 @@ def get_concluded_licenses() -> QuerySet[Concluded_License]:
     if user is None:
         return Concluded_License.objects.none()
 
-    components = Concluded_License.objects.all()
+    components = Concluded_License.objects.all().order_by("id")
 
     if not user.is_superuser:
         product_members = Product_Member.objects.filter(product=OuterRef("product_id"), user=user)
diff --git a/backend/application/licenses/queries/license_component.py b/backend/application/licenses/queries/license_component.py
@@ -26,7 +26,7 @@ def get_license_components() -> QuerySet[License_Component]:
     if user is None:
         return License_Component.objects.none()
 
-    components = License_Component.objects.all()
+    components = License_Component.objects.all().order_by("id")
 
     if not user.is_superuser:
         product_members = Product_Member.objects.filter(product=OuterRef("product_id"), user=user)
diff --git a/backend/application/licenses/queries/license_component_evidence.py b/backend/application/licenses/queries/license_component_evidence.py
@@ -12,7 +12,7 @@ def get_license_component_evidences() -> QuerySet[License_Component_Evidence]:
     if user is None:
         return License_Component_Evidence.objects.none()
 
-    components = License_Component_Evidence.objects.all()
+    components = License_Component_Evidence.objects.all().order_by("id")
 
     if not user.is_superuser:
         product_members = Product_Member.objects.filter(product=OuterRef("license_component__product_id"), user=user)
diff --git a/backend/application/licenses/queries/license_policy.py b/backend/application/licenses/queries/license_policy.py
@@ -21,7 +21,7 @@ def get_license_policies() -> QuerySet[License_Policy]:
     if user is None:
         return License_Policy.objects.none()
 
-    license_policies = License_Policy.objects.all()
+    license_policies = License_Policy.objects.all().order_by("id")
 
     if user.is_superuser:
         return license_policies
diff --git a/backend/application/metrics/queries/product_metrics.py b/backend/application/metrics/queries/product_metrics.py
@@ -13,7 +13,7 @@ def get_product_metrics() -> QuerySet[Product_Metrics]:
     if user is None:
         return Product_Metrics.objects.none()
 
-    product_metrics = Product_Metrics.objects.all()
+    product_metrics = Product_Metrics.objects.all().order_by("id")
 
     if not user.is_superuser:
         product_members = Product_Member.objects.filter(product=OuterRef("product_id"), user=user)
diff --git a/backend/application/rules/queries/rule.py b/backend/application/rules/queries/rule.py
@@ -9,7 +9,7 @@
 
 
 def get_general_rules() -> QuerySet[Rule]:
-    return Rule.objects.filter(product__isnull=True)
+    return Rule.objects.filter(product__isnull=True).order_by("id")
 
 
 def get_general_rule_by_id(general_rule_id: int) -> Optional[Rule]:
@@ -25,7 +25,7 @@ def get_product_rules() -> QuerySet[Rule]:
     if user is None:
         return Rule.objects.none()
 
-    product_rules = Rule.objects.filter(product__isnull=False)
+    product_rules = Rule.objects.filter(product__isnull=False).order_by("id")
 
     if not user.is_superuser:
         product_members = Product_Member.objects.filter(product=OuterRef("product_id"), user=user)
diff --git a/backend/application/vex/queries/csaf.py b/backend/application/vex/queries/csaf.py
@@ -14,7 +14,7 @@ def get_csafs() -> QuerySet[CSAF]:
     if user is None:
         return CSAF.objects.none()
 
-    csafs = CSAF.objects.all()
+    csafs = CSAF.objects.all().order_by("id")
 
     if not user.is_superuser:
         product_members = Product_Member.objects.filter(product=OuterRef("product_id"), user=user)
diff --git a/backend/application/vex/queries/cyclonedx.py b/backend/application/vex/queries/cyclonedx.py
@@ -14,7 +14,7 @@ def get_cyclonedx_s() -> QuerySet[CycloneDX]:
     if user is None:
         return CycloneDX.objects.none()
 
-    cyclonedx_s = CycloneDX.objects.all()
+    cyclonedx_s = CycloneDX.objects.all().order_by("id")
 
     if not user.is_superuser:
         product_members = Product_Member.objects.filter(product=OuterRef("product_id"), user=user)
diff --git a/backend/application/vex/queries/openvex.py b/backend/application/vex/queries/openvex.py
@@ -14,7 +14,7 @@ def get_openvex_s() -> QuerySet[OpenVEX]:
     if user is None:
         return OpenVEX.objects.none()
 
-    openvex_s = OpenVEX.objects.all()
+    openvex_s = OpenVEX.objects.all().order_by("id")
 
     if not user.is_superuser:
         product_members = Product_Member.objects.filter(product=OuterRef("product_id"), user=user)
diff --git a/backend/unittests/authorization/api/test_authorization_components.py b/backend/unittests/authorization/api/test_authorization_components.py
@@ -16,7 +16,7 @@ def test_authorization_components_product_authorization_group_member(self):
         self._test_authorization_components()
 
     def _test_authorization_components(self):
-        expected_data = "{'count': 2, 'next': None, 'previous': None, 'results': [{'id': '4dd012d1d2e18cf07666cc7fe0520da0', 'product_name': 'db_product_internal', 'product_group_name': 'db_product_group', 'branch_name': '', 'component_name_version_type': 'internal_component:1.0.0', 'origin_service_name': '', 'component_name': 'internal_component', 'component_version': '1.0.0', 'component_name_version': 'internal_component:1.0.0', 'component_purl': '', 'component_purl_type': '', 'component_cpe': '', 'component_dependencies': '', 'component_cyclonedx_bom_link': '', 'has_observations': False, 'product': 1, 'branch': None, 'origin_service': None}, {'id': '25a348829ab6ef7330b97069dab60a40', 'product_name': 'db_product_external', 'product_group_name': '', 'branch_name': '', 'component_name_version_type': 'external_component:2.0.0', 'origin_service_name': '', 'component_name': 'external_component', 'component_version': '2.0.0', 'component_name_version': 'external_component:2.0.0', 'component_purl': '', 'component_purl_type': '', 'component_cpe': '', 'component_dependencies': '', 'component_cyclonedx_bom_link': '', 'has_observations': False, 'product': 2, 'branch': None, 'origin_service': None}]}"
+        expected_data = "{'count': 2, 'next': None, 'previous': None, 'results': [{'id': '25a348829ab6ef7330b97069dab60a40', 'product_name': 'db_product_external', 'product_group_name': '', 'branch_name': '', 'component_name_version_type': 'external_component:2.0.0', 'origin_service_name': '', 'component_name': 'external_component', 'component_version': '2.0.0', 'component_name_version': 'external_component:2.0.0', 'component_purl': '', 'component_purl_type': '', 'component_cpe': '', 'component_dependencies': '', 'component_cyclonedx_bom_link': '', 'has_observations': False, 'product': 2, 'branch': None, 'origin_service': None}, {'id': '4dd012d1d2e18cf07666cc7fe0520da0', 'product_name': 'db_product_internal', 'product_group_name': 'db_product_group', 'branch_name': '', 'component_name_version_type': 'internal_component:1.0.0', 'origin_service_name': '', 'component_name': 'internal_component', 'component_version': '1.0.0', 'component_name_version': 'internal_component:1.0.0', 'component_purl': '', 'component_purl_type': '', 'component_cpe': '', 'component_dependencies': '', 'component_cyclonedx_bom_link': '', 'has_observations': False, 'product': 1, 'branch': None, 'origin_service': None}]}"
         self._test_api(APITest("db_admin", "get", "/api/components/", None, 200, expected_data))
 
         expected_data = "{'count': 1, 'next': None, 'previous': None, 'results': [{'id': '4dd012d1d2e18cf07666cc7fe0520da0', 'product_name': 'db_product_internal', 'product_group_name': 'db_product_group', 'branch_name': '', 'component_name_version_type': 'internal_component:1.0.0', 'origin_service_name': '', 'component_name': 'internal_component', 'component_version': '1.0.0', 'component_name_version': 'internal_component:1.0.0', 'component_purl': '', 'component_purl_type': '', 'component_cpe': '', 'component_dependencies': '', 'component_cyclonedx_bom_link': '', 'has_observations': False, 'product': 1, 'branch': None, 'origin_service': None}]}"
diff --git a/backend/unittests/authorization/api/test_authorization_observation_logs.py b/backend/unittests/authorization/api/test_authorization_observation_logs.py
