Skip to content

Commit baa350e

Browse files
stranmaclaude
andcommitted
fix: address CodeRabbit review feedback
- Use wildcard prefix Bash(*git remote add *) in settings.json deny rules to catch chained commands (matching tier file patterns) - Add missing set-head to docs denied commands table Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 6abc80b commit baa350e

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

.claude/settings.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@
3131
"deny": [
3232
"Bash(gh secret *)", "Bash(gh auth *)", "Bash(gh ssh-key *)", "Bash(gh gpg-key *)",
3333
"Bash(git clean *)", "Bash(git config *)",
34-
"Bash(git remote add *)", "Bash(git remote set-url *)", "Bash(git remote remove *)",
35-
"Bash(git remote rename *)", "Bash(git remote set-head *)",
34+
"Bash(*git remote add *)", "Bash(*git remote set-url *)", "Bash(*git remote remove *)",
35+
"Bash(*git remote rename *)", "Bash(*git remote set-head *)",
3636
"Bash(uv self *)"
3737
],
3838
"ask": [

docs/DEVCONTAINER_PERMISSIONS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ Regardless of tier, these layers provide defense-in-depth:
4545
| `docker run --privileged` | Use `docker run` without `--privileged` | Container escape vector |
4646
| `curl ... \| bash` / `wget ... \| sh` | Do not pipe remote scripts. Add to Dockerfile instead. | Supply-chain attack vector |
4747
| `cd path && command` | Use absolute paths: `command /absolute/path` | Chained commands bypass glob-based permission checks |
48-
| `git remote add/set-url/remove/rename` | Ask the user to manage remotes | Prevents code exfiltration to unauthorized remotes |
48+
| `git remote add/set-url/remove/rename/set-head` | Ask the user to manage remotes | Prevents code exfiltration to unauthorized remotes |
4949

5050
## Tier Comparison
5151

0 commit comments

Comments
 (0)