Skip to content

Commit 95cd4a1

Browse files
committed
Consider new symbol tags: Implements and Overrides
See changes on related PRs: - microsoft/language-server-protocol#2003 - eclipse-lsp4j/lsp4j#948
1 parent 0dc90b9 commit 95cd4a1

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/LSPImages.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,8 @@ public static ImageRegistry getImageRegistry() {
333333
case Declaration -> getImage(IMG_OVR_DECLARATION);
334334
case Definition -> getImage(IMG_OVR_DEFINITION);
335335
case ReadOnly -> getImage(IMG_OVR_READ_ONLY);
336+
case Overrides -> getImage(IMG_OVR_OVERRIDE);
337+
case Implements -> getImage(IMG_OVR_IMPLEMENT);
336338
};
337339
}
338340

@@ -358,6 +360,8 @@ public static ImageRegistry getImageRegistry() {
358360
case Declaration -> getImageDescriptor(IMG_OVR_DECLARATION);
359361
case Definition -> getImageDescriptor(IMG_OVR_DEFINITION);
360362
case ReadOnly -> getImageDescriptor(IMG_OVR_READ_ONLY);
363+
case Overrides -> getImageDescriptor(IMG_OVR_OVERRIDE);
364+
case Implements -> getImageDescriptor(IMG_OVR_IMPLEMENT);
361365
};
362366
}
363367

@@ -403,6 +407,7 @@ public static ImageRegistry getImageRegistry() {
403407
// precedence for remaining symbol tags (without visibility tags and deprecation tag)
404408
private static final List<SymbolTag> ADDITIONAL_TAGS_PRECEDENCE = List.of(
405409
SymbolTag.Static, SymbolTag.Abstract, SymbolTag.Virtual, SymbolTag.Final, SymbolTag.Sealed,
410+
SymbolTag.Overrides, SymbolTag.Implements,
406411
SymbolTag.Synchronized, SymbolTag.Transient, SymbolTag.Volatile,
407412
SymbolTag.Nullable, SymbolTag.NonNull, SymbolTag.ReadOnly,
408413
SymbolTag.Declaration, SymbolTag.Definition);
@@ -506,6 +511,7 @@ private static List<SymbolTag> getAdditionalSymbolTagsSorted(List<SymbolTag> sym
506511
symbolTags = Collections.emptyList();
507512
}
508513

514+
// TODO place the visibility overlay icon on the lower right corner, similar to JDT
509515
ImageDescriptor severityImageDescriptor = getOverlayForMarkerSeverity(severity);
510516
ImageDescriptor visibilityImageDescriptor = getOverlayForVisibility(symbolTags);
511517
ImageDescriptor deprecatedImageDescriptor = getUnderlayForDeprecation(deprecated || SymbolsUtil.isDeprecated(symbolTags));

0 commit comments

Comments
 (0)