From 84e1bf61a0c9b59c98b20cabe256af72802d222a Mon Sep 17 00:00:00 2001 From: immanuwell Date: Sun, 10 May 2026 11:19:12 +0400 Subject: [PATCH] fix: normalize underscore max old space flags --- .changeset/quiet-pots-relax.md | 5 +++++ packages/core/src/v3/machines/index.ts | 2 +- packages/core/src/v3/machines/max-old-space.test.ts | 8 ++++++++ 3 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 .changeset/quiet-pots-relax.md diff --git a/.changeset/quiet-pots-relax.md b/.changeset/quiet-pots-relax.md new file mode 100644 index 00000000000..fc7a45fb531 --- /dev/null +++ b/.changeset/quiet-pots-relax.md @@ -0,0 +1,5 @@ +--- +"@trigger.dev/core": patch +--- + +Replace underscore-form Node.js max-old-space-size flags when normalizing NODE_OPTIONS. diff --git a/packages/core/src/v3/machines/index.ts b/packages/core/src/v3/machines/index.ts index e5dcb097dc5..72b8ea9c80d 100644 --- a/packages/core/src/v3/machines/index.ts +++ b/packages/core/src/v3/machines/index.ts @@ -45,7 +45,7 @@ export function nodeOptionsWithMaxOldSpaceSize( let options = existingOptions ?? ""; //remove existing max-old-space-size flag - options = options.replace(/--max-old-space-size=\d+/g, "").trim(); + options = options.replace(/--max[-_]old[-_]space[-_]size=\d+/g, "").trim(); //get max-old-space-size flag const flag = maxOldSpaceSizeFlag(machine, overhead); diff --git a/packages/core/src/v3/machines/max-old-space.test.ts b/packages/core/src/v3/machines/max-old-space.test.ts index 425b8197624..b29d6c96444 100644 --- a/packages/core/src/v3/machines/max-old-space.test.ts +++ b/packages/core/src/v3/machines/max-old-space.test.ts @@ -36,6 +36,14 @@ describe("nodeOptionsWithMaxOldSpaceSize", () => { expect(result).toBe(`--inspect ${expectedFlag}`); }); + it("replaces existing max_old_space_size flag", () => { + const result = nodeOptionsWithMaxOldSpaceSize( + "--max_old_space_size=4096 --inspect", + testMachine + ); + expect(result).toBe(`--inspect ${expectedFlag}`); + }); + it("handles multiple existing max-old-space-size flags", () => { const result = nodeOptionsWithMaxOldSpaceSize( "--max-old-space-size=4096 --inspect --max-old-space-size=8192",