chore: added fix for snake case nested attributes and import keywork … (#779)

Added fix for snake case nested attributes and import keywork error
added the test generation for memory/v1 here to preview
twilio/twilio-python#917

snake case 

https://github.com/twilio/twilio-python/pull/917/changes#diff-777836e65412325fc37488cd2666c3c5a395f055d5dddee403544a8386dfebf7R48

import keyword generation :
https://github.com/twilio/twilio-python/pull/917/changes#diff-116f38979d5ea6f70e7b59044645b2666073bb9259c94a51492bff8ca69f5574

<!--
We appreciate the effort for this pull request but before that please
make sure you read the contribution guidelines, then fill out the blanks
below.

Please format the PR title appropriately based on the type of change:
  <type>[!]: <description>
Where <type> is one of: docs, chore, feat, fix, test, misc.
Add a '!' after the type for breaking changes (e.g. feat!: new breaking
feature).

**All third-party contributors acknowledge that any contributions they
provide will be made under the same open-source license that the
open-source project is provided under.**

Please enter each Issue number you are resolving in your PR after one of
the following words [Fixes, Closes, Resolves]. This will auto-link these
issues and close them when this PR is merged!
e.g.
Fixes #1
Closes #2
-->

# Fixes #

A short description of what this PR does.

### Checklist
- [x] I acknowledge that all my contributions will be made under the
project's license
- [ ] Run `make test-docker`
- [ ] Verify affected language according to the code change:
- [ ] Generate [twilio-java](https://github.com/twilio/twilio-java) from
our [OpenAPI specification](https://github.com/twilio/twilio-oai) using
the [scripts/build_twilio_library.py](./scripts/build_twilio_library.py)
using `python scripts/build_twilio_library.py
path/to/twilio-oai/spec/yaml path/to/twilio-java -l java` and inspect
the diff
    - [ ] Run `make test` in `twilio-java`
    - [ ] Create a pull request in `twilio-java`
- [ ] Provide a link below to the pull request, this ensures that the
generated code has been verified
- [ ] I have made a material change to the repo (functionality, testing,
spelling, grammar)
- [ ] I have read the [Contribution
Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md)
and my PR follows them
- [ ] I have titled the PR appropriately
- [ ] I have updated my branch with the main branch
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have added the necessary documentation about the functionality
in the appropriate .md file
- [ ] I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

Author: kridai

src/main/java/com/twilio/oai/common/Utility.java

@@ -93,7 +93,7 @@ public String populateCrudOperations(final CodegenOperation operation) {
 
         return method.name();
     }
-    
+
     /*
        responses:
         '200':
@@ -129,16 +129,22 @@ public Optional<CodegenModel> getModel(final List<CodegenModel> models,
                                            final CodegenOperation codegenOperation) {
         if (recordKey != null &&
             (boolean) codegenOperation.vendorExtensions.getOrDefault("x-is-read-operation", false)) {
-            return models
+            Optional<CodegenModel> nestedModel = models
                 .stream()
                 .filter(model -> model.getClassname().equals(className))
                 .map(CodegenModel::getVars)
                 .flatMap(Collection::stream)
                 .filter(prop -> prop.baseName.equals(recordKey))
                 .map(CodegenProperty::getComplexType)
+                .filter(Objects::nonNull)  // Filter out null complex types (e.g., arrays of primitives)
                 .map(classname -> getModelByClassname(models, classname))
                 .findFirst()
-                .orElse(null);
+                .orElse(Optional.empty());
+
+            // If we found a nested model, return it; otherwise fall back to top-level model
+            if (nestedModel.isPresent()) {
+                return nestedModel;
+            }
         }
 
         return getModelByClassname(models, className);
@@ -191,7 +197,7 @@ public static String replaceDatatypeInContainer(String input, String replacement
         // Return the input unchanged if no match is found
         return input;
     }
-    
+
     public static String appendResourceNameToEnum(String name) {
         if (name == null || name.isEmpty()) {
             return null;
@@ -202,7 +208,7 @@ public static String appendResourceNameToEnum(String name) {
         }
         return prefix + com.twilio.oai.common.StringUtils.toPascalCase(name);
     }
-    
+
     public static String getEnumNameFromRef(final String ref) {
         String schemaName = ref.replaceFirst("#/components/schemas/", "");
         String[] enumNameArray = schemaName.split("_enum_");
@@ -213,7 +219,7 @@ public static String getEnumNameFromRef(final String ref) {
        Example1:
        singleBodyRef:
          $ref: '#/components/schemas/singleReusable'
-       
+
        Example2:
        status:
           $ref: '#/components/schemas/message_enum_status'
@@ -228,23 +234,23 @@ public static String getEnumNameFromDefaultDatatype(final String ref) {
         String[] enumNameArray = schemaName.split("_enum_");
         return enumNameArray[enumNameArray.length - 1];
     }
-    
+
     public static String getEnumNameFromDatatype(final String datatype) {
         if (datatype == null || datatype.isEmpty()) {
             return null;
         }
         String[] enumNameArray = datatype.split("Enum");
         return enumNameArray[enumNameArray.length - 1];
     }
-    
+
     /*
-    Type1: 
+    Type1:
         types:
           $ref: '#/components/schemas/types'
-          
+
      */
     public static CodegenModel getModelFromOpenApiType(CodegenProperty codegenProperty) {
-        // Ref occurs for 2 cases, 
+        // Ref occurs for 2 cases,
         // 1. one when there is no ref, in that case the name will contain parent names.
         // 2. When model is defined using ref(reusable), name will not contain parent names.
         if (StringUtils.isBlank(codegenProperty.openApiType)) {
@@ -261,7 +267,7 @@ public static CodegenModel getModelFromOpenApiType(CodegenProperty codegenProper
 
     public static void main(String[] args) {
         String ref = "#/components/schemas/api.v2010.account.message";
-        
+
         System.out.println(getModelFromRef(ref));
     }
     public static CodegenModel getModelFromRef(String ref) {

src/main/java/com/twilio/oai/resolver/python/PythonCaseResolver.java

@@ -4,19 +4,41 @@
 
 import org.openapitools.codegen.utils.StringUtils;
 
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.Set;
+
 public class PythonCaseResolver implements CaseResolver {
+    // Python reserved keywords that cannot be used as filenames
+    private static final Set<String> PYTHON_RESERVED_KEYWORDS = new HashSet<>(Arrays.asList(
+        "import", "from", "class", "def", "return", "if", "else", "elif", "for", "while",
+        "break", "continue", "pass", "try", "except", "finally", "raise", "with", "as",
+        "assert", "del", "global", "lambda", "yield", "None", "True", "False", "and",
+        "or", "not", "in", "is"
+    ));
+
     @Override //not sure
     public String productOperation(final String product) {
         return StringUtils.underscore(product);
     }
 
     @Override //flex_flow.py
     public String pathOperation(final String pathPart) {
-        return StringUtils.underscore(pathPart);
+        String result = StringUtils.underscore(pathPart);
+        // If the result is a Python reserved keyword, append underscore
+        if (PYTHON_RESERVED_KEYWORDS.contains(result.toLowerCase())) {
+            return result + "_";
+        }
+        return result;
     }
 
     @Override
     public String filenameOperation(final String filename) {
-        return pathOperation(filename);
+        String result = pathOperation(filename);
+        // If the filename (without extension) is a Python reserved keyword, append underscore
+        if (PYTHON_RESERVED_KEYWORDS.contains(result.toLowerCase())) {
+            return result + "_";
+        }
+        return result;
     }
 }

src/main/resources/twilio-python/responseInstance.handlebars

@@ -3,12 +3,12 @@
 Response model for {{name}} operations
 """
 class {{name}}Resource:
-  def __init__(self,{{#vars}}{{baseName}}: {{{baseType}}}{{#unless @last}}, {{/unless}}{{/vars}}):
+  def __init__(self,{{#vars}}{{name}}: {{{baseType}}}{{#unless @last}}, {{/unless}}{{/vars}}):
     """
     Initialize the {{name}}Resource
-    {{#vars}}:param {{baseName}}: {{{description}}}
+    {{#vars}}:param {{name}}: {{{description}}}
     {{/vars}}
     """
-    {{#vars}}self.{{baseName}} = {{baseName}}
+    {{#vars}}self.{{name}} = {{name}}
     {{/vars}}
 {{/responseInstanceModels}}