fix: support plain equality in _where#1759
Open
LaplaceYoung wants to merge 1 commit into
Open
Conversation
Contributor
|
I reviewed this change because it relates to the plain _where equality behavior. The fix direction looks useful because users may expect _where={"title":"foo"} to behave like an equality check, similar to title=foo. One thing I would suggest is adding regression coverage for both supported forms: the primitive shorthand form and the operator-object form, for example _where={"title":"foo"} and _where={"title":{"eq":"foo"}}. That would help make sure both syntaxes stay consistent in future changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_whereJSON as equality filters.eq,gt,contains, and related operators.matchesWhere()and the HTTP_wherequery path.Closes #1757
Verification
pnpm testpnpm typecheckpnpm lintpnpm exec oxfmt --check src/app.test.ts src/matches-where.test.ts src/matches-where.tsgit diff --check