Move the network assignment for a created Docker Swarm service to the TaskTemplate structure as per the changes in docker 29.0 and metioned/explained at docker/docker-py#3362

rasmunk · rasmunk · commit 7b43f797d78b · 2025-12-18T10:12:19.000+01:00
diff --git a/jhub/swarmspawner.py b/jhub/swarmspawner.py
@@ -1106,6 +1106,7 @@ async def start(self):
                 "container_spec": container_spec,
                 "resources": resources,
                 "placement": placement,
+                "networks": networks,
             }
 
             if task_log_driver:
@@ -1120,7 +1121,6 @@ async def start(self):
                 "create_service",
                 task_tmpl,
                 name=self.service_name,
-                networks=networks,
                 endpoint_spec=endpoint_spec,
             )
             self.service_id = resp["ID"]

Original file line number	Diff line number	Diff line change
`@@ -1106,6 +1106,7 @@ async def start(self):`
`1106`	`1106`	`"container_spec": container_spec,`
`1107`	`1107`	`"resources": resources,`
`1108`	`1108`	`"placement": placement,`
	`1109`	`+ "networks": networks,`
`1109`	`1110`	`}`
`1110`	`1111`
`1111`	`1112`	`if task_log_driver:`
`@@ -1120,7 +1121,6 @@ async def start(self):`
`1120`	`1121`	`"create_service",`
`1121`	`1122`	`task_tmpl,`
`1122`	`1123`	`name=self.service_name,`
`1123`		`- networks=networks,`
`1124`	`1124`	`endpoint_spec=endpoint_spec,`
`1125`	`1125`	`)`
`1126`	`1126`	`self.service_id = resp["ID"]`