Update to OJS Version 3.4

[jpmmartins]

We are using this plugin in an OJS 3.3 installation to show the html content in the main page of a particular article.

https://journals.ub.uni-koeln.de/index.php/philsym/article/view/2022

Are there any plans to update the plugin?

Thanks for any help.

[ctgraham]

Yes, we have a current project upgrading each of our plugins to support 3.4.

[jbogdani]

Hello,
I had the plugin installed in a 3.3.x OJS instance, which was updated to the 3.3.0-17 version by the company that manages our journal for ‘security reasons’. The update broke our journal and I am wondering if it would be easier to roll back or to upgrade the plugin. It seems that is is not only the 3.4.x that brakes it.
Do you have a timeline for the new version? The sysadmins are not willing to downgrade since they are hosting many journals on the same instance...
Maybe I can also help with developing/testing if necessary.

Thank you for your work.

[ctgraham]

@trp89 , are the latest change to the 3.4_Updates branch ready to push so that others can try them out?

[trp89]

@jbogdani I just pushed changes for the 3.4 version of this plugin. Above I have references to two commits containing those specific changes. Let me know how the changes look.

[jbogdani]

@trp89 thank you.
Sorry for the late replay, but it took a while to get the update applied to the (managed) OJS instance.

Everything seems to work fine, many thanks for your work!

[jpmmartins]

I am having troubles loading the DOI on the sidebar. It is activated in Website Settings>Appearance>Setup>Sidebar. I believe it might have to do with the rewrite of the function lib/pkp/classes/plugins/PluginRegistry.php:107 in version 3.4.

OJS 3.3: https://journals.ub.uni-koeln.de/index.php/phidi/article/view/2412

Should I open a specific issue, or should this be a running issue for fixing problems with the update?

Nice to meet you at the PKP Sprint @ctgraham.

[ctgraham]

Hi, @jpmmartins , this issue is a good place to report bugs in the draft 3.4 implementation.

@trp89 , @jpmmartins suggests looking at PluginRegistry::loadCategory()
https://github.com/pkp/pkp-lib/blob/bbdfc8a66734904f1b7f57f847838c0699b77e44/classes/plugins/PluginRegistry.php#L107

For the DOI to be presented, we'll need the DOI PubIdPlugin to be loaded into the template manager at the time of block display. ( The block display looks for it here:

inlineHtmlGalley/InlineHtmlGalleySidebarBlockPlugin.php

Lines 68 to 82 in f093357

	function getContents($templateMgr, $request = null) {
	if ($templateMgr && $request) {
	$pubIdPlugins = $templateMgr->getTemplateVars('pubIdPlugins');
	if ($pubIdPlugins) {
	foreach ($pubIdPlugins as $pubIdPlugin) {
	if ($pubIdPlugin->getPubIdType() == 'doi') {
	return parent::getContents($templateMgr, $request);
	}
	}
	}
	}
	return false;
	}
	}

)

[jpmmartins]

The reason why it is not working seems to be because the plugins/pubIds/doi does not exist anymore.

@ocolbe found a workaround for the bootstrap3 theme where Alec suggested going via the article data.

pkp/bootstrap3@0a12934

I have looked into the plugin and the solution seems not be just changing plugins/generic/inlineHtmlGalley/templates/blockDoi.tpl but something needs to be changed also on in the function getContents of InlineHtmlGalleySidebarBlockPlugin.php

[jpmmartins]

I was installing the version of the plugin on a ojs-3.4.0-8 instance, and I also got an error related to the the new carbon class. It will not throw an error anymore after correcting the line

inlineHtmlGalley/templates/blockPublishedDate.tpl

Line 21 in 5af7a00

{$publication->getData('datePublished')|date_format}

I will do a pull request for you to analyse.