Rename Operations::Create to Operations::Push

Author: benedikt

lib/userlist/push.rb

@@ -5,7 +5,7 @@
 require 'userlist/push/resource_collection'
 require 'userlist/push/relation'
 
-require 'userlist/push/operations/create'
+require 'userlist/push/operations/push'
 require 'userlist/push/operations/delete'
 
 require 'userlist/push/user'
@@ -38,39 +38,39 @@ def initialize(configuration = {})
     attr_reader :config, :strategy
 
     def events
-      @events ||= Relation.new(self, Event, [Operations::Create])
+      @events ||= Relation.new(self, Event, [Operations::Push])
     end
 
     def users
-      @users ||= Relation.new(self, User, [Operations::Create, Operations::Delete])
+      @users ||= Relation.new(self, User, [Operations::Push, Operations::Delete])
     end
 
     def companies
-      @companies ||= Relation.new(self, Company, [Operations::Create, Operations::Delete])
+      @companies ||= Relation.new(self, Company, [Operations::Push, Operations::Delete])
     end
 
     def relationships
-      @relationships ||= Relation.new(self, Relationship, [Operations::Create, Operations::Delete])
+      @relationships ||= Relation.new(self, Relationship, [Operations::Push, Operations::Delete])
     end
 
     def messages
-      @messages ||= Relation.new(self, Message, [Operations::Create])
+      @messages ||= Relation.new(self, Message, [Operations::Push])
     end
 
     def event(payload = {})
-      events.create(payload)
+      events.push(payload)
     end
 
     def user(payload = {})
-      users.create(payload)
+      users.push(payload)
     end
 
     def company(payload = {})
-      companies.create(payload)
+      companies.push(payload)
     end
 
     def message(payload = {})
-      messages.create(payload)
+      messages.push(payload)
     end
 
     alias track event

lib/userlist/push/company.rb

@@ -1,7 +1,7 @@
 module Userlist
   class Push
     class Company < Resource
-      include Operations::Create
+      include Operations::Push
       include Operations::Delete
 
       def self.endpoint

lib/userlist/push/event.rb

@@ -1,7 +1,7 @@
 module Userlist
   class Push
     class Event < Resource
-      include Operations::Create
+      include Operations::Push
 
       has_one :user, type: 'Userlist::Push::User'
       has_one :company, type: 'Userlist::Push::Company'

lib/userlist/push/message.rb

@@ -1,7 +1,7 @@
 module Userlist
   class Push
     class Message < Resource
-      include Operations::Create
+      include Operations::Push
 
       has_one :user, type: 'Userlist::Push::User'
 

lib/userlist/push/operations/create.rb lib/userlist/push/operations/push.rblib/userlist/push/operations/create.rb renamed to lib/userlist/push/operations/push.rb

@@ -1,25 +1,22 @@
 module Userlist
   class Push
     module Operations
-      module Create
+      module Push
         module ClassMethods
-          def create(payload = {}, config = self.config)
+          def push(payload = {}, config = self.config)
             return false unless resource = from_payload(payload, config)
-            return false unless resource.create?
+            return false unless resource.push?
 
-            strategy.call(:post, endpoint, resource.for_context(:create))
+            strategy.call(:post, endpoint, resource.for_context(:push))
           end
 
-          alias push create
+          alias create push
+          alias update push
         end
 
         def self.included(base)
           base.extend(ClassMethods)
         end
-
-        def create?
-          push?
-        end
       end
     end
   end

lib/userlist/push/relationship.rb

@@ -1,7 +1,7 @@
 module Userlist
   class Push
     class Relationship < Resource
-      include Operations::Create
+      include Operations::Push
       include Operations::Delete
 
       has_one :user, type: 'Userlist::Push::User'

lib/userlist/push/user.rb

@@ -1,7 +1,7 @@
 module Userlist
   class Push
     class User < Resource
-      include Operations::Create
+      include Operations::Push
       include Operations::Delete
 
       has_many :relationships, type: 'Userlist::Push::Relationship', inverse: :user

spec/userlist/push/operations/delete_spec.rb

@@ -18,7 +18,7 @@
         relation.delete(payload)
       end
 
-      it 'should set the context to :create' do
+      it 'should set the context to :delete' do
         expect(strategy).to receive(:call).with(:delete, '/users', satisfy { |r| r.context == :delete })
         relation.delete(payload)
       end
@@ -34,7 +34,7 @@
         relation.delete(payload)
       end
 
-      it 'should set the context to :create' do
+      it 'should set the context to :delete' do
         expect(strategy).to receive(:call).with(:delete, '/users', satisfy { |r| r.context == :delete })
         relation.delete(payload)
       end
@@ -48,7 +48,7 @@
         relation.delete(payload)
       end
 
-      it 'should set the context to :create' do
+      it 'should set the context to :delete' do
         expect(strategy).to receive(:call).with(:delete, '/users', satisfy { |r| r.context == :delete })
         relation.delete(payload)
       end

…/userlist/push/operations/create_spec.rb …ec/userlist/push/operations/push_spec.rbspec/userlist/push/operations/create_spec.rb renamed to spec/userlist/push/operations/push_spec.rb spec/userlist/push/operations/create_spec.rb renamed to spec/userlist/push/operations/push_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-RSpec.describe Userlist::Push::Operations::Create do
+RSpec.describe Userlist::Push::Operations::Push do
   let(:resource_type) { Userlist::Push::User }
   let(:relation) { Userlist::Push::Relation.new(scope, resource_type, [described_class]) }
   let(:scope) { Userlist::Push.new(push_strategy: strategy) }
@@ -17,29 +17,29 @@
     }
   end
 
-  describe '.create' do
+  describe '.push' do
     before do
       allow(strategy).to receive(:call)
     end
 
     it 'should create a new instance of the resource_type' do
       expect(resource_type).to receive(:new).with(payload, scope.config).and_return(resource)
-      relation.create(payload)
+      relation.push(payload)
     end
 
     it 'should be aliased as #push' do
-      expect(relation.method(:push)).to eq(relation.method(:create))
+      expect(relation.method(:push)).to eq(relation.method(:push))
     end
 
     context 'when given a payload hash' do
       it 'should send the payload to the endpoint' do
         expect(strategy).to receive(:call).with(:post, '/users', resource)
-        relation.create(payload)
+        relation.push(payload)
       end
 
-      it 'should set the context to :create' do
-        expect(strategy).to receive(:call).with(:post, '/users', satisfy { |r| r.context == :create })
-        relation.create(payload)
+      it 'should set the context to :push' do
+        expect(strategy).to receive(:call).with(:post, '/users', satisfy { |r| r.context == :push })
+        relation.push(payload)
       end
     end
 
@@ -48,12 +48,12 @@
 
       it 'should send the request to the endpoint' do
         expect(strategy).to receive(:call).with(:post, '/users', resource)
-        relation.create(payload)
+        relation.push(payload)
       end
 
-      it 'should set the context to :create' do
-        expect(strategy).to receive(:call).with(:post, '/users', satisfy { |r| r.context == :create })
-        relation.create(payload)
+      it 'should set the context to :push' do
+        expect(strategy).to receive(:call).with(:post, '/users', satisfy { |r| r.context == :push })
+        relation.push(payload)
       end
     end
 
@@ -64,7 +64,7 @@
 
       it 'should send a simple payload to the endpoint' do
         expect(strategy).to receive(:call).with(:post, '/users', resource)
-        relation.create(payload[:identifier])
+        relation.push(payload[:identifier])
       end
     end
 
@@ -73,18 +73,18 @@
 
       it 'should not send a payload to the endpoint' do
         expect(strategy).to_not receive(:call)
-        relation.create(payload)
+        relation.push(payload)
       end
     end
 
     context 'when the operation is not permitted' do
       before do
-        allow_any_instance_of(resource_type).to receive(:create?).and_return(false)
+        allow_any_instance_of(resource_type).to receive(:push?).and_return(false)
       end
 
       it 'should not send a payload to the endpoint' do
         expect(strategy).to_not receive(:call)
-        relation.create(payload)
+        relation.push(payload)
       end
     end
 
@@ -94,8 +94,20 @@
       end
 
       it 'should not allow the operation' do
-        expect(resource.create?).to be(false)
+        expect(resource.push?).to be(false)
       end
     end
   end
+
+  describe '.create' do
+    it 'should be an alias for push' do
+      expect(relation.method(:create)).to eq(relation.method(:push))
+    end
+  end
+
+  describe '.update' do
+    it 'should be an alias for push' do
+      expect(relation.method(:update)).to eq(relation.method(:push))
+    end
+  end
 end

spec/userlist/push/relation_spec.rb

@@ -3,7 +3,7 @@
 RSpec.describe Userlist::Push::Relation do
   let(:scope) { double(:scope, config: config) }
   let(:resource_type) { double(:resource_type, endpoint: '/messages') }
-  let(:operations) { [Userlist::Push::Operations::Create, Userlist::Push::Operations::Delete] }
+  let(:operations) { [Userlist::Push::Operations::Push, Userlist::Push::Operations::Delete] }
   let(:config) { Userlist.config.merge(push_strategy: :null) }
 
   subject { described_class.new(scope, resource_type, operations) }