Merge pull request #8 from userlist/enable-retries-on-active-job-strategy

Author: benedikt

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Userlist for Ruby Changelog
 
+## Unreleased (main)
+
+- Updates ActiveJob Worker to retry on Timeout::Error with polynomially longer wait times, up to 10 attempts
+
 ## v0.9.0 (2024-03-19)
 
 - Allows deleteing resources by using other identifiers (like email)

lib/userlist/push/strategies/active_job/worker.rb

@@ -5,6 +5,8 @@ class Push
     module Strategies
       class ActiveJob
         class Worker < ::ActiveJob::Base
+          retry_on Timeout::Error, wait: :polynomially_longer, attempts: 10
+
           def perform(method, *args)
             client = Userlist::Push::Client.new
             client.public_send(method, *args)

spec/support/active_job.rb

@@ -0,0 +1,3 @@
+require 'active_job'
+
+ActiveJob::Base.queue_adapter = :test

spec/userlist/push/strategies/active_job/worker_spec.rb

@@ -28,4 +28,11 @@
     described_class.perform_now('post', '/user', payload)
     described_class.perform_now('delete', '/user/identifier')
   end
+
+  it 'should retry the job on failure' do
+    allow(client).to receive(:post).and_raise(Timeout::Error)
+
+    expect { described_class.perform_now('post', '/events', payload) }
+      .to change(described_class.queue_adapter.enqueued_jobs, :size).by(1)
+  end
 end