Allow setting of various other options on resources

Author: benedikt

lib/userlist/push/operations/delete.rb

@@ -7,7 +7,7 @@ def delete(payload = {}, config = self.config)
             return false unless resource = from_payload(payload, config)
             return false unless resource.delete?
 
-            strategy.call(:delete, endpoint, resource.for_context(:delete))
+            strategy.call(:delete, endpoint, resource.with(context: :delete))
           end
         end
 

lib/userlist/push/operations/push.rb

@@ -7,7 +7,7 @@ def push(payload = {}, config = self.config)
             return false unless resource = from_payload(payload, config)
             return false unless resource.push?
 
-            strategy.call(:post, endpoint, resource.for_context(:push))
+            strategy.call(:post, endpoint, resource.with(context: :push))
           end
 
           alias create push

lib/userlist/push/resource.rb

@@ -58,14 +58,14 @@ def generated_methods
         end
       end
 
-      attr_reader :payload, :config, :context
+      attr_reader :payload, :config, :options
 
       def initialize(payload = {}, config = Userlist.config)
         raise Userlist::ArgumentError, 'Missing required payload' unless payload
 
         @payload = payload
         @config = config
-        @context = :push
+        @options = { context: :push }
       end
 
       def respond_to_missing?(method, include_private = false)
@@ -74,7 +74,7 @@ def respond_to_missing?(method, include_private = false)
       end
 
       def to_hash
-        Serializer.serialize(self, context: context)
+        Serializer.serialize(self, **options)
       end
       alias to_h to_hash
 
@@ -107,9 +107,9 @@ def push?
         true
       end
 
-      def for_context(context)
+      def with(**options)
         dup.tap do |instance|
-          instance.instance_variable_set(:@context, context)
+          instance.instance_variable_set(:@options, options)
         end
       end
 

spec/userlist/push/operations/delete_spec.rb

@@ -19,7 +19,7 @@
       end
 
       it 'should set the context to :delete' do
-        expect(strategy).to receive(:call).with(:delete, '/users', satisfy { |r| r.context == :delete })
+        expect(strategy).to receive(:call).with(:delete, '/users', satisfy { |r| r.options[:context] == :delete })
         relation.delete(payload)
       end
     end
@@ -35,7 +35,7 @@
       end
 
       it 'should set the context to :delete' do
-        expect(strategy).to receive(:call).with(:delete, '/users', satisfy { |r| r.context == :delete })
+        expect(strategy).to receive(:call).with(:delete, '/users', satisfy { |r| r.options[:context] == :delete })
         relation.delete(payload)
       end
     end
@@ -49,7 +49,7 @@
       end
 
       it 'should set the context to :delete' do
-        expect(strategy).to receive(:call).with(:delete, '/users', satisfy { |r| r.context == :delete })
+        expect(strategy).to receive(:call).with(:delete, '/users', satisfy { |r| r.options[:context] == :delete })
         relation.delete(payload)
       end
     end
@@ -63,6 +63,17 @@
       end
     end
 
+    context 'when given keyword arguments as payload' do
+      let(:payload) do
+        { identifier: identifier }
+      end
+
+      it 'should send the request to the endpoint' do
+        expect(strategy).to receive(:call).with(:delete, '/users', resource.with(context: :delete))
+        relation.delete(identifier:)
+      end
+    end
+
     context 'when the operation is not permitted' do
       before do
         allow_any_instance_of(resource_type).to receive(:delete?).and_return(false)

spec/userlist/push/operations/push_spec.rb

@@ -7,9 +7,10 @@
   let(:strategy) { instance_double('Userlist::Push::Strategies::Direct') }
   let(:resource) { resource_type.from_payload(payload) }
 
+  let(:identifier) { 'identifier' }
   let(:payload) do
     {
-      identifier: 'identifier',
+      identifier: identifier,
       properties: {
         first_name: 'John',
         last_name: 'Doe'
@@ -38,7 +39,7 @@
       end
 
       it 'should set the context to :push' do
-        expect(strategy).to receive(:call).with(:post, '/users', satisfy { |r| r.context == :push })
+        expect(strategy).to receive(:call).with(:post, '/users', satisfy { |r| r.options[:context] == :push })
         relation.push(payload)
       end
     end
@@ -52,14 +53,14 @@
       end
 
       it 'should set the context to :push' do
-        expect(strategy).to receive(:call).with(:post, '/users', satisfy { |r| r.context == :push })
+        expect(strategy).to receive(:call).with(:post, '/users', satisfy { |r| r.options[:context] == :push })
         relation.push(payload)
       end
     end
 
     context 'when given an identifier' do
       let(:payload) do
-        { identifier: 'identifier' }
+        { identifier: identifier }
       end
 
       it 'should send a simple payload to the endpoint' do
@@ -77,6 +78,17 @@
       end
     end
 
+      context 'when given keyword arguments as payload' do
+      let(:payload) do
+        { identifier: identifier }
+      end
+
+      it 'should send the request to the endpoint' do
+        expect(strategy).to receive(:call).with(:post, '/users', resource.with(context: :push))
+        relation.push(identifier:)
+      end
+    end
+
     context 'when the operation is not permitted' do
       before do
         allow_any_instance_of(resource_type).to receive(:push?).and_return(false)