Commit 0971535
authored
test(e2e): skip rollipop typeerror check (#383)
### TL;DR
Enable E2E tests to run on PRs that modify the CI workflow and optimize test commands.
### What changed?
- Added a `pull_request` trigger for the E2E test workflow when changes are made to `ecosystem-ci/**` or the workflow file itself
- Optimized the Playwright installation for vibe-dashboard to only install Chromium instead of all browsers
- Made the lint command for the rollipop project non-blocking by adding `|| true` due to a TypeScript ESLint issue
### How to test?
1. Make changes to files in the `ecosystem-ci/` directory or the `.github/workflows/e2e-test.yml` file
2. Verify that the E2E test workflow runs automatically on your PR
3. Check that the vibe-dashboard test uses only Chromium
4. Confirm that the rollipop build continues even if the lint step fails
### Why make this change?
- Running E2E tests on relevant PRs helps catch issues before they're merged to main
- Installing only Chromium for Playwright tests reduces CI time and resource usage
- Making the lint command non-blocking prevents CI failures due to a known TypeScript ESLint issue while still providing lint feedback1 parent e6f1154 commit 0971535
1 file changed
Lines changed: 10 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
12 | 16 | | |
13 | 17 | | |
14 | 18 | | |
| |||
41 | 45 | | |
42 | 46 | | |
43 | 47 | | |
| 48 | + | |
44 | 49 | | |
45 | 50 | | |
46 | 51 | | |
47 | 52 | | |
48 | 53 | | |
49 | 54 | | |
50 | 55 | | |
51 | | - | |
| 56 | + | |
52 | 57 | | |
53 | 58 | | |
54 | 59 | | |
| |||
67 | 72 | | |
68 | 73 | | |
69 | 74 | | |
70 | | - | |
71 | | - | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
72 | 79 | | |
73 | 80 | | |
74 | 81 | | |
| |||
0 commit comments