-
Notifications
You must be signed in to change notification settings - Fork 129
Open
Description
Summary
After migrating Rolldown's CI to Vite+, tests started failing because Vite+ injects VITE_PLUS_* environment variables.
These variables may be picked up by Vite's env exposure logic because they start with VITE_:
This means they can end up included in bundled applications unexpectedly.
Repro / context
- Report from
sapphi-red - Failing run: https://github.com/rolldown/rolldown/actions/runs/23351281471/job/67930353118#step:8:482
Problem
Even if the current vars do not contain sensitive information, using the VITE_ prefix creates unnecessary risk and surprising behavior.
Suggested fix
Rename internal env vars to something that does not match Vite's default public env prefix, e.g.
VITEPLUS_*- or another non-
VITE_prefix
Expected outcome
Internal Vite+ env vars should not be accidentally exposed to application bundles via Vite's envPrefix behavior.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Give feedbackPriority
Medium