🧪 test: update tests for convention system and fix linting issues

Co-authored-by: warengonzaga <15052701+warengonzaga@users.noreply.github.com>

Author: Copilot

source/cli.js

@@ -2,7 +2,7 @@
 import process from 'node:process';
 import {Command} from 'commander';
 import packageJSON from '../package.json';
-import {showBanner, showWarning} from './utils/ui.js';
+import {showBanner, showWarning, showSuccess, showError} from './utils/ui.js';
 import {commitCommand} from './commands/commit.js';
 import {
 	authenticateWithCopilot,
@@ -11,8 +11,7 @@ import {
 	logout,
 } from './commands/auth.js';
 import {showConfig, resetConfig} from './commands/config.js';
-import {setConvention, getConvention} from './utils/config-manager.js';
-import {showSuccess, showError} from './utils/ui.js';
+import {setConvention} from './utils/config-manager.js';
 
 const program = new Command();
 

source/commands/auth.js

@@ -1,5 +1,5 @@
-import {execa} from 'execa';
 import process from 'node:process';
+import {execa} from 'execa';
 import {
 	setAuthMode,
 	setToken,
@@ -19,7 +19,7 @@ import {
  * Handles GitHub Copilot and OpenAI authentication
  */
 
-export async function authenticateWithCopilot(token = null) {
+export async function authenticateWithCopilot() {
 	try {
 		console.log('🔐 Setting up GitHub Copilot authentication...\n');
 

source/commands/commit.js

@@ -142,14 +142,14 @@ export async function processFilesInteractively(aiProvider, options = {}) {
 
 		while (!fileProcessed) {
 			try {
-				const message = await aiProvider.generateCommitMessage(
-					diff,
-					file,
-					{...options, convention: currentConvention},
-				);
+				const message = await aiProvider.generateCommitMessage(diff, file, {
+					...options,
+					convention: currentConvention,
+				});
 
 				const result = await confirmCommit(message, file, currentConvention);
 
+				// eslint-disable-next-line unicorn/prefer-switch
 				if (result.action === 'accept') {
 					const success = await commit(result.message);
 					if (success) {
@@ -190,6 +190,7 @@ export async function processFilesInteractively(aiProvider, options = {}) {
 }
 /* eslint-enable no-await-in-loop */
 
+/* eslint-disable no-await-in-loop */
 export async function processFile(filePath, aiProvider, options = {}) {
 	showInfo(`Processing single file: ${filePath}`);
 	console.log('');
@@ -217,11 +218,10 @@ export async function processFile(filePath, aiProvider, options = {}) {
 		showInfo('Generating commit message...');
 
 		try {
-			const message = await aiProvider.generateCommitMessage(
-				diff,
-				filePath,
-				{...options, convention: currentConvention},
-			);
+			const message = await aiProvider.generateCommitMessage(diff, filePath, {
+				...options,
+				convention: currentConvention,
+			});
 
 			const result = await confirmCommit(message, filePath, currentConvention);
 
@@ -258,3 +258,4 @@ export async function processFile(filePath, aiProvider, options = {}) {
 	showWarning('Maximum regeneration attempts reached.');
 	await unstageFile(filePath);
 }
+/* eslint-enable no-await-in-loop */

source/utils/commit-conventions.js

@@ -2,7 +2,10 @@ export const CONVENTIONS = {
 	clean: {
 		name: 'Clean Commit',
 		description: 'wgtechlabs Clean Commit format with emojis',
-		buildPrompt: (diff, filePath) => `You are an expert at writing git commit messages following the "Clean Commit" format.
+		buildPrompt: (
+			diff,
+			filePath,
+		) => `You are an expert at writing git commit messages following the "Clean Commit" format.
 
 **Clean Commit Format:**
 <emoji> <type>: <description>
@@ -40,7 +43,10 @@ Generate a single commit message following Clean Commit format. Return ONLY the
 	conventional: {
 		name: 'Conventional Commits',
 		description: 'Standard Conventional Commits specification',
-		buildPrompt: (diff, filePath) => `You are an expert at writing git commit messages following the "Conventional Commits" specification.
+		buildPrompt: (
+			diff,
+			filePath,
+		) => `You are an expert at writing git commit messages following the "Conventional Commits" specification.
 
 **Format:**
 <type>(<scope>): <description>
@@ -76,7 +82,10 @@ Generate a single commit message following Conventional Commits format. Return O
 	gitmoji: {
 		name: 'Gitmoji',
 		description: 'Gitmoji commit convention with emojis',
-		buildPrompt: (diff, filePath) => `You are an expert at writing git commit messages using the "Gitmoji" convention.
+		buildPrompt: (
+			diff,
+			filePath,
+		) => `You are an expert at writing git commit messages using the "Gitmoji" convention.
 
 **Format:**
 :<emoji-code>: <description>
@@ -113,7 +122,10 @@ Generate a single commit message using Gitmoji format. Return ONLY the commit me
 	simple: {
 		name: 'Simple',
 		description: 'Plain descriptive commit messages',
-		buildPrompt: (diff, filePath) => `You are an expert at writing clear, concise git commit messages.
+		buildPrompt: (
+			diff,
+			filePath,
+		) => `You are an expert at writing clear, concise git commit messages.
 
 **Format:**
 Simple descriptive message in imperative mood

source/utils/ui.js

@@ -1,10 +1,7 @@
 import chalk from 'chalk';
 import figlet from 'figlet';
 import inquirer from 'inquirer';
-import {
-	listConventions,
-	getConvention,
-} from '../utils/commit-conventions.js';
+import {listConventions, getConvention} from '../utils/commit-conventions.js';
 
 /**
  * UI utilities for magic-commit terminal interface
@@ -72,7 +69,10 @@ export async function confirmCommit(
 			choices: [
 				{name: '✅ Accept and commit', value: 'accept'},
 				{name: '✏️  Edit message', value: 'edit'},
-				{name: '🔄 Regenerate with different convention', value: 'change-convention'},
+				{
+					name: '🔄 Regenerate with different convention',
+					value: 'change-convention',
+				},
 				{name: '⏭️  Skip this file', value: 'skip'},
 			],
 		},

test.js

@@ -5,8 +5,14 @@ import {
 	setToken,
 	getAuthMode,
 	getToken,
+	setConvention,
+	getConvention,
 	clearAll,
 } from './source/utils/config-manager.js';
+import {
+	getConvention as getConventionDetails,
+	listConventions,
+} from './source/utils/commit-conventions.js';
 
 test('config manager stores and retrieves auth mode', t => {
 	clearAll();
@@ -33,18 +39,79 @@ test('config manager stores and retrieves tokens', t => {
 	t.is(getToken('github'), undefined);
 });
 
-test('AIProvider builds Clean Commit prompt correctly', t => {
-	const provider = new AIProvider({authMode: 'openai'});
+test('config manager stores and retrieves convention', t => {
+	clearAll();
+	t.is(getConvention(), 'clean'); // Default
+
+	setConvention('conventional');
+	t.is(getConvention(), 'conventional');
+
+	setConvention('gitmoji');
+	t.is(getConvention(), 'gitmoji');
+
+	clearAll();
+	t.is(getConvention(), 'clean'); // Back to default
+});
+
+test('convention system returns correct convention details', t => {
+	const cleanConv = getConventionDetails('clean');
+	t.is(cleanConv.name, 'Clean Commit');
+	t.true(cleanConv.description.includes('emoji'));
+
+	const conventionalConv = getConventionDetails('conventional');
+	t.is(conventionalConv.name, 'Conventional Commits');
+
+	const gitmojiConv = getConventionDetails('gitmoji');
+	t.is(gitmojiConv.name, 'Gitmoji');
+
+	const simpleConv = getConventionDetails('simple');
+	t.is(simpleConv.name, 'Simple');
+});
+
+test('convention system lists all conventions', t => {
+	const conventions = listConventions();
+	t.is(conventions.length, 4);
+	t.true(conventions.some(c => c.value === 'clean'));
+	t.true(conventions.some(c => c.value === 'conventional'));
+	t.true(conventions.some(c => c.value === 'gitmoji'));
+	t.true(conventions.some(c => c.value === 'simple'));
+});
+
+test('convention system builds prompts correctly', t => {
 	const diff = 'test diff content';
 	const filePath = 'test.js';
 
-	const prompt = provider.buildCleanCommitPrompt(diff, filePath);
+	// Test Clean Commit
+	const cleanConv = getConventionDetails('clean');
+	const cleanPrompt = cleanConv.buildPrompt(diff, filePath);
+	t.true(cleanPrompt.includes('Clean Commit'));
+	t.true(cleanPrompt.includes('test diff content'));
+	t.true(cleanPrompt.includes('test.js'));
+	t.true(cleanPrompt.includes('📦'));
+
+	// Test Conventional Commits
+	const conventionalConv = getConventionDetails('conventional');
+	const conventionalPrompt = conventionalConv.buildPrompt(diff, filePath);
+	t.true(conventionalPrompt.includes('Conventional Commits'));
+	t.true(conventionalPrompt.includes('feat:'));
+	t.true(conventionalPrompt.includes('fix:'));
+
+	// Test Gitmoji
+	const gitmojiConv = getConventionDetails('gitmoji');
+	const gitmojiPrompt = gitmojiConv.buildPrompt(diff, filePath);
+	t.true(gitmojiPrompt.includes('Gitmoji'));
+	t.true(gitmojiPrompt.includes(':sparkles:'));
+
+	// Test Simple
+	const simpleConv = getConventionDetails('simple');
+	const simplePrompt = simpleConv.buildPrompt(diff, filePath);
+	t.true(simplePrompt.includes('imperative mood'));
+	t.true(simplePrompt.includes('test diff content'));
+});
 
-	t.true(prompt.includes('Clean Commit'));
-	t.true(prompt.includes('test diff content'));
-	t.true(prompt.includes('test.js'));
-	t.true(prompt.includes('📦'));
-	t.true(prompt.includes('🔧'));
+test('convention system defaults to clean for unknown convention', t => {
+	const unknownConv = getConventionDetails('unknown-convention');
+	t.is(unknownConv.name, 'Clean Commit'); // Should fallback to clean
 });
 
 test('AIProvider generates fallback message for large diffs', t => {