fix: retries=Infinity

This wasn't tested, and would have looped forever trying to populate this.#timeouts

Originally from: tim-kos/node-retry#77

Author: wraithgar

lib/retry.js

@@ -156,8 +156,12 @@ const timeouts = options => {
 }
 
 exports.operation = function (options = {}) {
+  if (options.retries === Infinity) {
+    options.forever = true
+    delete options.retries
+  }
   return new RetryOperation(timeouts(options), {
-    forever: options.forever || (options.retries === Infinity),
+    forever: options.forever,
     unref: options.unref,
     maxRetryTime: options.maxRetryTime
   })

test/retry.js

@@ -186,6 +186,25 @@ t.suite('retry', () => {
       })
     })
 
+    t.test('infinite retries', (t, done) => {
+      const error = new Error('some error')
+      const operation = retry.operation({ retries: Infinity, minTimeout: 1, maxTimeout: 10 })
+      let attempts = 0
+
+      operation.attempt(function (currentAttempt) {
+        attempts++
+        a.equal(currentAttempt, attempts)
+        if (attempts !== 6 && operation.retry(error)) {
+          return
+        }
+
+        a.strictEqual(attempts, 6)
+        a.strictEqual(operation.attempts, attempts)
+        a.strictEqual(operation.mainError, error)
+        done()
+      })
+    })
+
     t.test('retry forever no retries', (t, done) => {
       const error = new Error('some error')
       const delay = 50