feat(sensor): support more rpc methods

[minhd-vu]

Description

Jira / Linear Tickets

• DVT-000

Testing

• 👀
• Deployed Amoy
• Deployed Mainnet

[praetoriansentry]

Code review

Found 2 issues:

1. TOCTOU race condition when updating latestBlockHash and latestBlockNumber. The check-then-set pattern uses three separate lock operations (Get, Set, Set), so two goroutines handling different peers can both pass the > check and interleave their writes, leaving hash and number mismatched (e.g., hash from block N, number from block N+1). This appears in handleBlockRangeUpdate, handleNewBlockHashes, and handleNewBlock. (CLAUDE.md says "Race Conditions: Run with -race flag during testing; protect shared state with mutexes or channels")

polygon-cli/p2p/protocol.go

Lines 443 to 447 in d8ec9e3

	// Update latest block info from the range update (thread-safe for API access)
	if packet.LatestBlock > c.latestBlockNumber.Get() {
	c.latestBlockHash.Set(packet.LatestBlockHash)
	c.latestBlockNumber.Set(packet.LatestBlock)
	}

polygon-cli/p2p/protocol.go

Lines 546 to 550 in d8ec9e3

	// Update latest block info if this block is newer (thread-safe for API access)
	if entry.Number > c.latestBlockNumber.Get() {
	c.latestBlockHash.Set(hash)
	c.latestBlockNumber.Set(entry.Number)
	}

polygon-cli/p2p/protocol.go

Lines 1126 to 1129 in d8ec9e3

	// Update latest block info for this peer (thread-safe for API access)
	c.latestBlockHash.Set(hash)
	c.latestBlockNumber.Set(packet.Block.Number().Uint64())

2. Batch proxy silently drops already-validated transactions. In handleBatchRequest, when the loop encounters an unsupported method mid-batch, it proxies the entire original batch and returns early — without broadcasting transactions that were already validated and collected in txs from earlier iterations. For example, a batch of [eth_sendRawTransaction, eth_getBalance] with proxy enabled would validate the transaction but never broadcast it. (CLAUDE.md says "Completeness: Data collection operations must fetch ALL requested data or fail entirely - never produce partial results")

polygon-cli/cmd/p2p/sensor/rpc.go

Lines 237 to 252 in d8ec9e3

	for _, req := range requests {
	resp := processRequest(req, params, &txs)
	// If any method not found and proxy is enabled, forward entire batch
	if isMethodNotFound(resp) && params.proxy != nil {
	for _, rpcReq := range requests {
	params.counter.WithLabelValues(rpcReq.Method, "true").Inc()
	}
	proxyRPCRequest(w, r, body, params.proxy)
	return
	}
	params.counter.WithLabelValues(req.Method, "false").Inc()
	responses = append(responses, resp)
	}

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[sonarqubecloud]

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud