Skip to content

adding support for None chat templates.#3582

Open
NicoGrande wants to merge 1 commit intomainfrom
nicogrande/null-chat-templates
Open

adding support for None chat templates.#3582
NicoGrande wants to merge 1 commit intomainfrom
nicogrande/null-chat-templates

Conversation

@NicoGrande
Copy link
Copy Markdown
Collaborator

@NicoGrande NicoGrande commented Apr 6, 2026

Description

Avoid type errors when template_config resolves to None. This can happen if no chat_template_path is provided, if the chat template fails to load correctly, or if no chat template is passed in.

Tests

Added unit test for this case.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/trainers/post_train/rl/train_rl.py 0.00% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@NicoGrande NicoGrande force-pushed the nicogrande/null-chat-templates branch from b9e5220 to d118879 Compare April 6, 2026 21:35
@NicoGrande NicoGrande force-pushed the nicogrande/null-chat-templates branch from d118879 to ade2859 Compare April 6, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants