Explicit error terms testing and documentation#1064
Open
janzill wants to merge 87 commits intoActivitySim:explicit_error_termsfrom
Open
Explicit error terms testing and documentation#1064janzill wants to merge 87 commits intoActivitySim:explicit_error_termsfrom
janzill wants to merge 87 commits intoActivitySim:explicit_error_termsfrom
Conversation
…EET comparison tests
… are the same for eval_mnl and eval_nl
…ing cdap eet parity
… toy example and compares the result
Extend logit tests, add model tests, add simulate tests, draft docs
…nism in trip_scheduling (probabilistic, no EET branch)
…test Adds 2 zone tests
…ress for multi zone tests
…eduling choice" This reverts commit 2d181b2.
Deterministic alt sample randoms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
The implementation for the inconsistency fix for sampled choices is based on #1065, thanks @m-richards!
Regarding the RNG reset across shadow pricing iterations, this currently only applies to EET to make sure there are no changes to any Monte Carlo (MC) functionality. It would be good to discuss using this for MC as well, but I'd like to avoid doing this as part of this PR because it would mean updating tests and I want to make sure that the EET implementation does not change any MC results.
Some further discussion points regarding testing: