chore: add test case 'test_aks_create_and_update_with_gateway_api_without_azureservicemesh'#9735
chore: add test case 'test_aks_create_and_update_with_gateway_api_without_azureservicemesh'#9735Winbobob wants to merge 4 commits intoAzure:mainfrom
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @Winbobob, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull request overview
Adds a new AKS CLI integration test to validate enabling/disabling/re-enabling Gateway API on a cluster without the Azure Service Mesh add-on, and records the addition in the aks-preview changelog.
Changes:
- Add ScenarioTest
test_aks_create_and_update_with_gateway_api_without_azureservicemeshcoveringaz aks create+az aks update --disable-gateway-api/--enable-gateway-api. - Remove the now-obsolete TODO referencing the planned test.
- Update
HISTORY.rstPending section to mention the new test coverage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py |
Adds the new Gateway API (no ASM) create/update test and removes the related TODO. |
src/aks-preview/HISTORY.rst |
Notes the new test case under Pending. |
|
Queued live test: https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=158460845&view=results, it passed |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Queued live test to validate the change
- test_aks_create_and_update_with_gateway_api_and_azureservicemesh
- test_aks_create_and_update_with_gateway_api_without_azureservicemesh
Please commit the recording file according to your newly added test case to pass CI check
Winbobob
force-pushed
the
zheweihu/c/gateway-api-without-asm-test
branch
from
c0a78e8 to
df7e254
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
The CI failed because of request and response mismatches in the recording files. You may need to update the recordings with new ones generated from the live test pipeline. |
Winbobob
force-pushed
the
zheweihu/c/gateway-api-without-asm-test
branch
from
7549620 to
65f5062
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
The CI failed with error like this
E AssertionError: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_create_and_update_with_gateway_api_without_azureservicemesh.yaml') in your current record mode ('once').
E No match for the request (<Request (GET) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.ContainerService/locations/centraluseuap/kubernetesVersions?api-version=2026-01-02-preview>) was found.
E Found 7 similar requests with 1 different matcher(s) :
The error is caused by a mismatch between the location used during recording (when the test was previously run in live mode) and the default location set in the test case.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.