[AutoPR azure-keyvault-certificates]-generated-from-SDK Generation - Python-6045716 by azure-sdk · Pull Request #45842 · Azure/azure-sdk-for-python

azure-sdk · 2026-03-23T01:34:04Z

Configurations: 'specification/keyvault/data-plane/Certificates/tspconfig.yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: '06d1c57f16f9da0b2672c34e2066aa0a35b6e62c' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6045716 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.

…nfig.yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: '06d1c57f16f9da0b2672c34e2066aa0a35b6e62c' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6045716 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.

…ce_identifiers fields - 19 unit tests for model construction, serialization, deserialization, and round-trip - 3 recorded integration tests against live Key Vault (IP addresses, URIs, all fields) - Update assets.json with new recording tag

Copilot

Pull request overview

This PR appears to regenerate azure-keyvault-certificates from the Key Vault Certificates TypeSpec (API version 2025-07-01) and updates the package’s generated client/models plus adds SAN coverage tests.

Changes:

Regenerated _generated client/models for the new API version, including new SAN fields (ip_addresses, uniform_resource_identifiers).
Added new unit + recorded integration tests validating SAN model and service round-tripping.
Updated packaging/metadata files (TypeSpec source pointers, assets tag, packaging config, version bump + changelog entry).

Reviewed changes

Copilot reviewed 74 out of 74 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
sdk/keyvault/azure-keyvault-certificates/pyproject.toml	PEP 621 metadata + dynamic version/readme + packaging settings (currently inconsistent with code layout).
sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/init.py	Reduced to namespace stub, removing public exports (breaking).
sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_generated/**	Regenerated client/models/utils for API version 2025-07-01 (incl. SAN updates).
sdk/keyvault/azure-keyvault-certificates/tests/test_san_models.py	New unit tests for SAN model serialization/deserialization.
sdk/keyvault/azure-keyvault-certificates/tests/test_san_live.py	New recorded integration tests validating SAN fields round-trip.
sdk/keyvault/azure-keyvault-certificates/CHANGELOG.md	Version bump to 4.11.0 with placeholder text rather than actual change notes.
sdk/keyvault/azure-keyvault-certificates/setup.py	Added setuptools packaging script (potentially conflicting with existing pyproject settings).
sdk/keyvault/azure-keyvault-certificates/tsp-location.yaml	Updated TypeSpec source directory/commit pointers.
sdk/keyvault/azure-keyvault-certificates/MANIFEST.in	Adjusted py.typed include path and init inclusion.

Copilot · 2026-03-23T16:51:53Z

sdk/keyvault/azure-keyvault-certificates/pyproject.toml

+[tool.setuptools.dynamic.version]
+attr = "azure.keyvault.certificates._version.VERSION"
+


[tool.setuptools.dynamic.version] points to azure.keyvault.certificates._version.VERSION, but this module/file is no longer present in the package after this change set. This will break packaging/build at version resolution time. Update the attr to the actual version module (e.g., _generated._version) or restore the expected _version.py in azure.keyvault.certificates so the dynamic version path remains valid.

Copilot · 2026-03-23T16:51:54Z

sdk/keyvault/azure-keyvault-certificates/pyproject.toml

 [tool.setuptools.package-data]
-pytyped = ["py.typed"]
+pytyped = [
+    "py.typed",
+]


The pytyped = ["py.typed"] package-data configuration assumes a py.typed marker in the discovered packages. In this PR the marker file moved under azure/keyvault/certificates/_generated/py.typed, so type information may no longer be shipped for the public package unless package-data is updated accordingly (or the marker is restored at azure/keyvault/certificates/py.typed).

Copilot · 2026-03-23T16:51:54Z

sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/__init__.py

-
-from ._version import VERSION
-__version__ = VERSION
+__path__ = __import__("pkgutil").extend_path(__path__, __name__)  # type: ignore


azure.keyvault.certificates is reduced to a namespace-package stub and no longer exposes the public surface area (e.g., CertificateClient, models, enums, __version__). For a stable azure-keyvault-certificates release this is a breaking change for all existing imports. Restore the public exports (and underlying implementations) or bump major version and update docs/migration accordingly.

Suggested change

__path__ = __import__("pkgutil").extend_path(__path__, __name__) # type: ignore

from ._client import CertificateClient

from ._models import * # type: ignore[assignment, misc] # pylint: disable=wildcard-import

from ._enums import * # type: ignore[assignment, misc] # pylint: disable=wildcard-import

from ._version import VERSION as __version__

# Export the public surface area of this package.

# We start with the main client and version, then include all non-private

# names imported from models and enums.

__all__ = ["CertificateClient", "__version__"]

for _name, _value in list(globals().items()):

if _name.startswith("_"):

continue

if _name in __all__:

continue

# Only export names that are not modules; models and enums are expected

# to be classes, functions, or simple values.

import types as _types

if isinstance(_value, _types.ModuleType):

continue

__all__.append(_name)

del _name

del _value

del _types

…anall, spiffe to dictionary

…nored_headers in conftest.py - Restore 20 handwritten files deleted by the TSP emitter (known emitter regression): _client.py, _enums.py, _models.py, _polling.py, _sdk_moniker.py, _version.py, py.typed, aio/__init__.py, aio/_client.py, aio/_polling_async.py, _shared/ directory (8 files), sdk_packaging.toml - Restore __init__.py, azure/__init__.py, azure/keyvault/__init__.py (overwritten by emitter with namespace-package stub) - Restore MANIFEST.in (py.typed path was incorrectly changed to _generated/) - Add Accept to ignored_headers in conftest.py to handle Accept header changes in recordings after generation update

…dentifiers support

github-actions bot added the KeyVault label Mar 23, 2026

github-project-automation bot added this to Azure SDK for Key Vault Mar 23, 2026

github-project-automation bot moved this to Untriaged in Azure SDK for Key Vault Mar 23, 2026

singhalrohit4u and others added 2 commits March 23, 2026 09:42

Merge branch 'main' into sdkauto/azure-keyvault-certificates-6045716

60ebbd1

rohitsinghal4u marked this pull request as ready for review March 23, 2026 16:46

rohitsinghal4u requested a review from a team as a code owner March 23, 2026 16:46

Copilot AI review requested due to automatic review settings March 23, 2026 16:46

Copilot started reviewing on behalf of rohitsinghal4u March 23, 2026 16:47 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Fix cspell errors: add livekvtestsanip, livekvtestsanuri, livekvtests…

3aeba39

…anall, spiffe to dictionary

rohitsinghal4u requested review from benbp, mccoyp, scbedd and weshaggard as code owners March 23, 2026 17:26

rohitsinghal4u and others added 4 commits March 23, 2026 11:46

Merge branch 'main' into sdkauto/azure-keyvault-certificates-6045716

dc306a0

Merge branch 'main' into sdkauto/azure-keyvault-certificates-6045716

a591266

Add changelog entry for 4.11.0 - SAN ipAddresses and uniformResourceI…

28440df

…dentifiers support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AutoPR azure-keyvault-certificates]-generated-from-SDK Generation - Python-6045716#45842

[AutoPR azure-keyvault-certificates]-generated-from-SDK Generation - Python-6045716#45842
azure-sdk wants to merge 8 commits intomainfrom
sdkauto/azure-keyvault-certificates-6045716

azure-sdk commented Mar 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		[tool.setuptools.dynamic.version]
		attr = "azure.keyvault.certificates._version.VERSION"

-__path__ = __import__("pkgutil").extend_path(__path__, __name__)  # type: ignore
+from ._client import CertificateClient
+from ._models import *  # type: ignore[assignment, misc]  # pylint: disable=wildcard-import
+from ._enums import *  # type: ignore[assignment, misc]  # pylint: disable=wildcard-import
+from ._version import VERSION as __version__
+# Export the public surface area of this package.
+# We start with the main client and version, then include all non-private
+# names imported from models and enums.
+__all__ = ["CertificateClient", "__version__"]
+for _name, _value in list(globals().items()):
+    if _name.startswith("_"):
+        continue
+    if _name in __all__:
+        continue
+    # Only export names that are not modules; models and enums are expected
+    # to be classes, functions, or simple values.
+    import types as _types
+    if isinstance(_value, _types.ModuleType):
+        continue
+    __all__.append(_name)
+del _name
+del _value
+del _types

Conversation

azure-sdk commented Mar 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants