[AutoPR azure-keyvault-secrets]-generated-from-SDK Generation - Python-6050879 by azure-sdk · Pull Request #45863 · Azure/azure-sdk-for-python

azure-sdk · 2026-03-23T22:36:16Z

Configurations: 'specification/keyvault/data-plane/Secrets/tspconfig.yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: '3d69f01137e1271361cc8003e399475cbfefadec' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6050879 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.

…yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: '3d69f01137e1271361cc8003e399475cbfefadec' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6050879 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.

- Restore user-friendly SDK layer deleted by auto-generation - Add out_content_type parameter to get_secret() for PFX->PEM conversion - Add previous_version property to SecretProperties - Add 2025-07-01 and 2025-06-01-preview API versions - Add unit tests for new features (test_new_features.py) - Add live recording tests for previous_version and out_content_type - Update assets.json with new recordings tag - Fix proxy_startup.py to support ARM64 platform

github-actions · 2026-03-24T17:57:53Z

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure-keyvault-secrets

Copilot

Pull request overview

This PR updates azure-keyvault-secrets to a newly generated TypeSpec-based data-plane surface targeting Key Vault Secrets API version 2025-07-01, including new request/response fields and updated generation/runtime plumbing.

Changes:

Add support for out_content_type on SecretClient.get_secret (PFX → PEM conversion via outContentType query param) and introduce ContentType enum.
Surface previous_version on SecretProperties (from previousVersion in service responses).
Update default API version to 2025-07-01 and refresh generated models/operations, tests, samples, and packaging metadata.

Reviewed changes

Copilot reviewed 55 out of 56 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
sdk/keyvault/azure-keyvault-secrets/tsp-location.yaml	Updates TypeSpec source location/commit for generation.
sdk/keyvault/azure-keyvault-secrets/tests/test_secrets_client.py	Adds live tests for `previous_version` and `out_content_type`; updates imports.
sdk/keyvault/azure-keyvault-secrets/tests/test_secrets_async.py	Minor formatting in async test.
sdk/keyvault/azure-keyvault-secrets/tests/test_polling_method.py	Formatting-only change for polling method tests.
sdk/keyvault/azure-keyvault-secrets/tests/test_new_features.py	Adds unit tests validating query param + `previous_version` mapping.
sdk/keyvault/azure-keyvault-secrets/tests/conftest.py	Fixes trailing comma formatting in imports.
sdk/keyvault/azure-keyvault-secrets/tests/_test_case.py	Adjusts live auth env handling; configures credential for multi-tenant challenge flow.
sdk/keyvault/azure-keyvault-secrets/setup.py	Adds generated setup.py for packaging/versioning.
sdk/keyvault/azure-keyvault-secrets/sdk_packaging.toml	Removes legacy packaging config file.
sdk/keyvault/azure-keyvault-secrets/samples/recover_purge_operations_async.py	Adds pylint suppression header + formatting tweak.
sdk/keyvault/azure-keyvault-secrets/samples/recover_purge_operations.py	Adds pylint suppression header.
sdk/keyvault/azure-keyvault-secrets/samples/list_operations_async.py	Adds pylint suppression header + minor print formatting.
sdk/keyvault/azure-keyvault-secrets/samples/list_operations.py	Adds pylint suppression header + minor print formatting.
sdk/keyvault/azure-keyvault-secrets/samples/hello_world_async.py	Adds pylint suppression header + spacing.
sdk/keyvault/azure-keyvault-secrets/samples/hello_world.py	Adds pylint suppression header.
sdk/keyvault/azure-keyvault-secrets/samples/backup_restore_operations_async.py	Adds pylint suppression header + indentation fix.
sdk/keyvault/azure-keyvault-secrets/samples/backup_restore_operations.py	Adds pylint suppression header.
sdk/keyvault/azure-keyvault-secrets/pyproject.toml	Reformats TOML, moves packaging flag, keeps dynamic version/readme config.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/aio/_client.py	Adds `out_content_type` kw-only param and wires it to generated client.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/client_base.py	Adds new API versions and updates default to `2025-07-01`.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_models.py	Adds `SecretProperties.previous_version` and populates it from bundles.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/models/_patch.py	Updates generated customization stub typing/header.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/models/_models.py	Adds `previous_version` to generated bundles; modernizes typing (`dict[str, ...]`).
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/models/_enums.py	Adds `ContentType` enum; docstring punctuation tweaks.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/models/init.py	Exposes `ContentType` from generated models package.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/aio/_vendor.py	Removes internal typing mixin module.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/aio/_patch.py	Updates generated customization stub typing/header.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/aio/_operations/_patch.py	Updates generated customization stub typing/header.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/aio/_operations/_operations.py	Adds `out_content_type` support + api-version validation; refactors paging types; tweaks streaming behavior.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/aio/_operations/init.py	Renames exported operations mixin to internal `_KeyVaultClientOperationsMixin`.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/aio/_configuration.py	Updates default api_version docstring/default to `2025-07-01`.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/aio/_client.py	Uses new internal operations mixin and updated api_version docs.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/_version.py	Bumps generated version to 4.11.0.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/_vendor.py	Removes internal typing mixin module.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/_validation.py	Adds api-version validation decorator used by generated operations.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/_utils/serialization.py	Removes `eval` conversions; modernizes typing and serialization logic.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/_utils/model_base.py	Significant generated runtime refactor (typing, optional handling, array-encoded formats, failsafe deserialize signature).
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/_serialization.py	Removes large legacy generated serialization module.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/_patch.py	Updates generated customization stub typing/header.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/_operations/_patch.py	Updates generated customization stub typing/header.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/_operations/_operations.py	Adds `out_content_type` query support + api-version validation; refactors paging types; tweaks streaming behavior.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/_operations/init.py	Renames exported operations mixin to internal `_KeyVaultClientOperationsMixin`.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/_model_base.py	Removes legacy generated model_base module (replaced by `_utils/model_base.py`).
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/_configuration.py	Updates default api_version docstring/default to `2025-07-01`.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/_client.py	Uses new internal operations mixin and updated api_version docs.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_client.py	Adds `out_content_type` kw-only param and wires it to generated client.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/init.py	Re-exports `ContentType` from generated models.
sdk/keyvault/azure-keyvault-secrets/azure/keyvault/init.py	Removes header comments; keeps namespace package path extension.
sdk/keyvault/azure-keyvault-secrets/azure/init.py	Removes header comments; keeps namespace package path extension.
sdk/keyvault/azure-keyvault-secrets/assets.json	Updates assets tag for recording/asset synchronization.
sdk/keyvault/azure-keyvault-secrets/apiview-properties.json	Adds APIView cross-language mapping metadata.
sdk/keyvault/azure-keyvault-secrets/_metadata.json	Adds generation metadata (apiVersion, spec commit, emitter version).
sdk/keyvault/azure-keyvault-secrets/MANIFEST.in	Adjusts included files (py.typed path, init.py).
sdk/keyvault/azure-keyvault-secrets/CHANGELOG.md	Adds 4.11.0 entry (currently placeholder text).
eng/tools/azure-sdk-tools/devtools_testutils/proxy_startup.py	Adds Windows ARM64 platform mapping for test-proxy startup.

Copilot · 2026-03-25T18:58:46Z

sdk/keyvault/azure-keyvault-secrets/setup.py

+    packages=find_packages(
+        exclude=[
+            "tests",
+            # Exclude packages that will be covered by PEP420 or nspkg
+            "azure",
+            "azure.keyvault",
+            "azure.keyvault.secrets",
+        ]


setup.py excludes the public package azure.keyvault.secrets, which would omit SecretClient and other public modules from the built distribution (only _generated would be packaged). Please align package discovery/excludes so the wheel includes the actual azure.keyvault.secrets package (and its subpackages) as shipped to customers.

Copilot · 2026-03-25T18:58:47Z

sdk/keyvault/azure-keyvault-secrets/setup.py

+PACKAGE_NAME = "azure-keyvault-secrets"
+PACKAGE_PPRINT_NAME = "Key Vault Secrets"
+PACKAGE_NAMESPACE = "azure.keyvault.secrets._generated"
+
+# a.b.c => a/b/c
+package_folder_path = PACKAGE_NAMESPACE.replace(".", "/")
+
+# Version extraction inspired from 'requests'
+with open(os.path.join(package_folder_path, "_version.py"), "r") as fd:
+    version = re.search(r'^VERSION\s*=\s*[\'"]([^\'"]*)[\'"]', fd.read(), re.MULTILINE).group(1)


setup.py pulls the package version from azure.keyvault.secrets._generated._version.py, but this repo’s pyproject uses azure.keyvault.secrets._version.VERSION for the published package version. This mismatch can lead to publishing a wheel with a different version depending on build path; align version sourcing between setup.py and pyproject.toml.

Copilot · 2026-03-25T18:58:47Z

sdk/keyvault/azure-keyvault-secrets/MANIFEST.in

 include *.md
 include LICENSE
-include azure/keyvault/secrets/py.typed
+include azure/keyvault/secrets/_generated/py.typed


The PEP 561 py.typed marker is only included for the _generated subpackage. Since azure.keyvault.secrets exposes typed public APIs, the type marker should be present/included for the azure/keyvault/secrets/ package itself as well; otherwise type checkers may treat the main package as untyped.

Suggested change

include azure/keyvault/secrets/_generated/py.typed

include azure/keyvault/secrets/_generated/py.typed

include azure/keyvault/secrets/py.typed

Copilot · 2026-03-25T18:58:47Z

sdk/keyvault/azure-keyvault-secrets/tests/test_secrets_client.py

+import base64
 import functools


base64 is imported but never used in this test module. Please remove the unused import to keep linting clean.

Copilot · 2026-03-25T18:58:48Z

sdk/keyvault/azure-keyvault-secrets/tests/test_secrets_client.py

+        from azure.keyvault.certificates import CertificateClient, CertificatePolicy
+
+        cert_client = self.create_client_from_credential(
+            CertificateClient,
+            credential=self.get_credential(CertificateClient),
+            vault_url=client.vault_url,
+        )


These new live tests import azure.keyvault.certificates at runtime. azure-keyvault-certificates is not listed in this package’s dev/test requirements, so running the secrets test suite in isolation will fail with ImportError. Consider using pytest.importorskip("azure.keyvault.certificates") and/or adding the certificates package to the test dependencies for this package.

Copilot · 2026-03-25T18:58:49Z

sdk/keyvault/azure-keyvault-secrets/CHANGELOG.md

+skip changelog generation for data-plane package and please add changelog manually.
+


The 4.11.0 changelog entry contains a generation placeholder rather than user-facing release notes. For a stable release, please replace this with a summary of the actual shipped changes (e.g., previous_version support and out_content_type/PFX→PEM retrieval).

Suggested change

skip changelog generation for data-plane package and please add changelog manually.

### Features Added

- Added support for a `previous_version` parameter, allowing callers to retrieve or operate on the version of a secret that was active immediately before the current version.

- Added support for specifying an `out_content_type` when retrieving secrets containing certificate material, enabling conversion of PFX-formatted secrets to PEM when requested.

### Bugs Fixed

- Improved handling of PFX secrets when converting to PEM using `out_content_type`, ensuring the returned content matches the requested output format.

### Other Changes

- Minor documentation and typing improvements.

Copilot · 2026-03-25T18:58:49Z

sdk/keyvault/azure-keyvault-secrets/tests/test_new_features.py

+from azure.core.pipeline.transport import HttpRequest
+from azure.keyvault.secrets import SecretClient, ContentType, SecretProperties


HttpRequest is imported but not used in this test file. Please remove the unused import to avoid lint failures.

Copilot · 2026-03-25T18:58:49Z

sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/models/_enums.py

    permanent deletion (i.e. purge). This level guarantees the recoverability of the deleted entity
    during the retention interval (90 days), unless a Purge operation is requested, or the
-    subscription is cancelled. System wil permanently delete it after 90 days, if not recovered"""
+    subscription is cancelled. System wil permanently delete it after 90 days, if not recovered."""
    RECOVERABLE = "Recoverable"
    """Denotes a vault state in which deletion is recoverable without the possibility for immediate
    and permanent deletion (i.e. purge). This level guarantees the recoverability of the deleted
    entity during the retention interval (90 days) and while the subscription is still available.
-    System wil permanently delete it after 90 days, if not recovered"""
+    System wil permanently delete it after 90 days, if not recovered."""


There are spelling errors in these docstrings (e.g., "System wil permanently delete..."). Please correct "wil" to "will" to avoid shipping typos in public API documentation.

Copilot · 2026-03-25T18:58:50Z

sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_generated/_configuration.py

+    :keyword api_version: The API version to use for this operation. Known values are "2025-07-01"
+     and None. Default value is "2025-07-01". Note that overriding this default value may result in
+     unsupported behavior.
    :paramtype api_version: str
    """

    def __init__(self, vault_base_url: str, credential: "TokenCredential", **kwargs: Any) -> None:
-        api_version: str = kwargs.pop("api_version", "7.6")
+        api_version: str = kwargs.pop("api_version", "2025-07-01")


The configuration docstring says the known api_version values are "2025-07-01" and None, but the client supports multiple versions (including preview/legacy versions) and None isn’t a meaningful API version. Please update the docstring to list the actual supported values (or remove the misleading "and None").

Copilot · 2026-03-25T18:58:50Z

sdk/keyvault/azure-keyvault-secrets/tsp-location.yaml

+additionalDirectories: 
+- specification/keyvault/data-plane/Secrets/common


There’s trailing whitespace after additionalDirectories: which can cause noisy diffs and some linters to fail. Please remove the extra space after the colon.

github-actions bot added the KeyVault label Mar 23, 2026

github-project-automation bot added this to Azure SDK for Key Vault Mar 23, 2026

github-project-automation bot moved this to Untriaged in Azure SDK for Key Vault Mar 23, 2026

rohitsinghal4u marked this pull request as ready for review March 25, 2026 18:48

rohitsinghal4u requested review from a team, mccoyp and scbedd as code owners March 25, 2026 18:48

Copilot AI review requested due to automatic review settings March 25, 2026 18:48

Copilot started reviewing on behalf of rohitsinghal4u March 25, 2026 18:50 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AutoPR azure-keyvault-secrets]-generated-from-SDK Generation - Python-6050879#45863

[AutoPR azure-keyvault-secrets]-generated-from-SDK Generation - Python-6050879#45863
azure-sdk wants to merge 2 commits intomainfrom
sdkauto/azure-keyvault-secrets-6050879

azure-sdk commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	include azure/keyvault/secrets/_generated/py.typed
	include azure/keyvault/secrets/_generated/py.typed
	include azure/keyvault/secrets/py.typed

		skip changelog generation for data-plane package and please add changelog manually.

-skip changelog generation for data-plane package and please add changelog manually.
+### Features Added
+- Added support for a `previous_version` parameter, allowing callers to retrieve or operate on the version of a secret that was active immediately before the current version.
+- Added support for specifying an `out_content_type` when retrieving secrets containing certificate material, enabling conversion of PFX-formatted secrets to PEM when requested.
+### Bugs Fixed
+- Improved handling of PFX secrets when converting to PEM using `out_content_type`, ensuring the returned content matches the requested output format.
+### Other Changes
+- Minor documentation and typing improvements.

		from azure.core.pipeline.transport import HttpRequest
		from azure.keyvault.secrets import SecretClient, ContentType, SecretProperties

		additionalDirectories:
		- specification/keyvault/data-plane/Secrets/common

Conversation

azure-sdk commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

API Change Check

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants