Bump UrlLib pin to include client-side-failure fixes#168
Merged
bkaradzic-microsoft merged 1 commit intoMay 14, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the UrlLib dependency pin in CMakeLists.txt to a newer commit that includes client-side-failure fixes (state reset between Open() calls, safer Unix PerformAsync exception handling, and non-throwing Apple Open for missing local files). It is a pin-bump only with no source changes in JsRuntimeHost itself.
Changes:
- Update the
UrlLibGIT_TAGinFetchContent_Declareto commit4452b7eded1e315a5f329c390db71ec863d3e3e8.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
UWP failures here (4 jobs) are a bug in #28 that wasn't caught by UrlLib's own CI: |
bkaradzic-microsoft
added a commit
to BabylonJS/UrlLib
that referenced
this pull request
May 14, 2026
…ON_DESKTOP (#29) Follow-up to #28: the unconditional `m_fileResponseBuffer.clear()` call added to `Open()` in `UrlRequest_Windows_Shared.h` references a member that only exists on Win32 desktop. UWP builds fail with: ``` UrlRequest_Windows_Shared.h(51,13): error C2065: 'm_fileResponseBuffer': undeclared identifier (compiling source file '../../_deps/urllib-src/Source/UrlRequest_UWP.cpp') ``` Spotted by [JsRuntimeHost #168](BabylonJS/JsRuntimeHost#168) CI (4 UWP build jobs failing: `UWP_x64_Chakra`, `UWP_x64_JSI`, `UWP_x64_V8`, `UWP_arm64_JSI`). The member declaration at line 150 of the same header is already gated by `#if WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP)`. The fix is to apply the same guard around the `clear()` call so it only fires on desktop. After this, `JsRuntimeHost #168` (UrlLib pin bump) goes green on UWP. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Picks up: - UrlLib BabylonJS#28: client-side-failure fixes (Unix worker thread no longer terminates on missing local files; Apple Open no longer throws synchronously on missing app:/// paths) plus per-request response state reset hoisted to ImplBase::ResetForOpen(). - UrlLib BabylonJS#29: UWP build fix (guard the new m_fileResponseBuffer.clear() call with WINAPI_PARTITION_DESKTOP). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bkaradzic-microsoft
force-pushed
the
bump-urllib-pin
branch
from
25f3345 to
b2802d6
Compare
bghgary
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up UrlLib #28 so consumers (including BabylonNative) get the client-side-failure fixes:
ImplBase::ResetForOpen()clearsm_statusCode,m_responseUrl,m_responseString,m_headersbetweenOpen()calls on all 5 platforms (Win32, UWP, Unix, Apple, Android).PerformAsyncno longer letscurl_checkexceptions escapestd::thread->std::terminate; falls back tostatus=0 + loadendlike Win32/UWP.Openno longer throws synchronously when[NSBundle pathForResource:]returns nil for missing local files; setsm_url = niland lets the existingSendAsyncbranch returnstatus=0.This is a pin-bump only: no source changes in JsRuntimeHost itself.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com