Merged
Conversation
nazarhussain
commented
Mar 25, 2026
Comment on lines
+4
to
+6
| .name = .zapi, | ||
| .version = "0.1.0", | ||
| .fingerprint = 0x86a418feef5ba28a, | ||
| .fingerprint = 0x77829ef951b38aac, |
Contributor
Author
There was a problem hiding this comment.
@wemeetagain should we do a major version bump because of this change?
Member
There was a problem hiding this comment.
Changing the name and fingerprint is akin to a major version bump, yeah?
Member
There was a problem hiding this comment.
But also once all the open PRs are marged, you might feel like this project has hit a "1.0" level of maturity
Member
There was a problem hiding this comment.
No stong opinion from me either way
Contributor
Author
There was a problem hiding this comment.
Then I will merge the current PR and will bump the version once all the currently open PRs are merged, specially #11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we decided to rename this project to
zapi, so I updated all references of old name tozapi.