Skip to content

Implement toolchain harvesting for cpp#46

Open
GuillaumeLagrange wants to merge 4 commits intomainfrom
cod-2414-implement-toolchain-harvesting-for-cpp
Open

Implement toolchain harvesting for cpp#46
GuillaumeLagrange wants to merge 4 commits intomainfrom
cod-2414-implement-toolchain-harvesting-for-cpp

Conversation

@GuillaumeLagrange
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange commented Mar 25, 2026

@GuillaumeLagrange GuillaumeLagrange changed the title Cod 2414 implement toolchain harvesting for cpp Implement toolchain harvesting for cpp Mar 25, 2026
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-2414-implement-toolchain-harvesting-for-cpp branch 2 times, most recently from 6a0a8ff to 9bd8f0b Compare March 25, 2026 16:33
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 25, 2026

Merging this PR will improve performance by 10.69%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 459 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation BM_memcpy[64] 301.9 ns 272.8 ns +10.69%

Comparing cod-2414-implement-toolchain-harvesting-for-cpp (af89417) with main (d6b4111)

Open in CodSpeed

@GuillaumeLagrange GuillaumeLagrange requested review from not-matthias and removed request for not-matthias March 25, 2026 16:37
@GuillaumeLagrange GuillaumeLagrange marked this pull request as ready for review March 25, 2026 16:38
Copy link
Member

@not-matthias not-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should ensure that the toolchain extraction is foolproof across different compilers + build systems

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-2414-implement-toolchain-harvesting-for-cpp branch 3 times, most recently from 140adfd to c2f701a Compare March 26, 2026 16:26
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-2414-implement-toolchain-harvesting-for-cpp branch from c2f701a to 1c7f3ec Compare March 26, 2026 16:28
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-2414-implement-toolchain-harvesting-for-cpp branch from 27c80e3 to af89417 Compare March 26, 2026 16:48
Copy link
Member

@not-matthias not-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants