Skip to content

Add support for experimental flags and add valgrind's --fair-sched#279

Merged
GuillaumeLagrange merged 3 commits intomainfrom
cod-2418-support-fair-sched-behind-an-unstable-flag
Mar 26, 2026
Merged

Add support for experimental flags and add valgrind's --fair-sched#279
GuillaumeLagrange merged 3 commits intomainfrom
cod-2418-support-fair-sched-behind-an-unstable-flag

Conversation

@GuillaumeLagrange
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange commented Mar 26, 2026

Fixes #90

$ codspeed run exec -m simulation --skip-upload --experimental-fair-sched -- ls -la

  ⚠ Experimental flags enabled: --experimental-fair-sched
  These may change or be removed without notice.
  Share feedback at https://github.com/CodSpeedHQ/codspeed/issues.


› Running the benchmarks

  ✓  ⚙ CPU Simulation - exec ls -la
    ╭─ 21 lines above ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
    │ drwxr-xr-x 1 guillaume users    268 Mar 26 11:27 .git                                                                                                                                                                                  │
    │ -rw-r--r-- 1 guillaume users    422 Feb 20 16:46 .gitattributes                                                                                                                                                                        │
    │ drwxr-xr-x 1 guillaume users     46 Mar  4 10:50 .github                                                                                                                                                                               │
    │ -rw-r--r-- 1 guillaume users     57 Jan 23 11:11 .gitignore                                                                                                                                                                            │
    │ -rw-r--r-- 1 guillaume users    180 Feb  9 09:20 .gitmodules                                                                                                                                                                           │
    │ -rw-r--r-- 1 guillaume users  10928 Nov 24 17:07 LICENSE-APACHE                                                                                                                                                                        │
    │ -rw-r--r-- 1 guillaume users   1090 Nov 24 17:07 LICENSE-MIT                                                                                                                                                                           │
    │ -rw-r--r-- 1 guillaume users     93 Mar 13 14:32 .mcp.json                                                                                                                                                                             │
    │ -rw-r--r-- 1 guillaume users   1063 Feb 20 16:46 .pre-commit-config.yaml                                                                                                                                                               │
    │ -rw-r--r-- 1 guillaume users   9461 Jan 28 17:02 README.md                                                                                                                                                                             │
    │ -rw-r--r-- 1 guillaume users     66 Jan 16 11:50 rust-toolchain.toml                                                                                                                                                                   │
    │ drwxr-xr-x 1 guillaume users     40 Mar 11 08:47 schemas                                                                                                                                                                               │
    │ drwxr-xr-x 1 guillaume users     60 Feb 22 20:56 scripts                                                                                                                                                                               │
    │ -rw-r--r-- 1 guillaume users   2627 Mar 25 18:47 Session.vim                                                                                                                                                                           │
    │ drwxr-xr-x 1 guillaume users     78 Mar 17 09:25 skills                                                                                                                                                                                │
    │ drwxr-xr-x 1 guillaume users    366 Mar 26 11:14 src                                                                                                                                                                                   │
    │ drwxr-xr-x 1 guillaume users    204 Mar 17 16:19 target                                                                                                                                                                                │
    │ drwxr-xr-x 1 guillaume users     16 Nov 24 17:07 testdata                                                                                                                                                                              │
    │ drwxr-xr-x 1 guillaume users     40 Mar 24 14:13 tests                                                                                                                                                                                 │
    │ drwxr-xr-x 1 guillaume users     56 Nov 24 17:07 .vscode                                                                                                                                                                               │
    ╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

Clap exits the process directly, disregarding the drop impl of other
structs, when invoked with --help for example.

The other implementation solution would be to rely on a libc unsafe hook
to execute code no matter what at process exit, which is a bit overkill
for our usecase here.
@GuillaumeLagrange GuillaumeLagrange marked this pull request as ready for review March 26, 2026 10:28
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 26, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks


Comparing cod-2418-support-fair-sched-behind-an-unstable-flag (bf8f770) with main (4860c11)

Open in CodSpeed

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-2418-support-fair-sched-behind-an-unstable-flag branch from d1a60fc to 995991b Compare March 26, 2026 11:05
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-2418-support-fair-sched-behind-an-unstable-flag branch from 995991b to bf8f770 Compare March 26, 2026 11:08
@GuillaumeLagrange GuillaumeLagrange merged commit bf8f770 into main Mar 26, 2026
18 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the cod-2418-support-fair-sched-behind-an-unstable-flag branch March 26, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pass --fair-sched to valgrind

2 participants