Conversation
…/github.com/Code-4-Community/ssf into jw/ssf-194-admin-pantry-management-frontend
amywng
left a comment
amywng
left a comment
There was a problem hiding this comment.
small things but lgtm after that!
sam-schu
left a comment
sam-schu
left a comment
There was a problem hiding this comment.
Further review pending clarification from Priya
| path: ROUTES.TEST_ADMIN_DASHBOARD, | ||
| element: ( | ||
| <ProtectedRoute> | ||
| <TestAdminDashboard /> |
There was a problem hiding this comment.
Why did you change the name here? this is the test admin dashboard, better to keep that clear
There was a problem hiding this comment.
On main this conatiner is exported as just AdminDashboard, did you want me to change that? I also rename it in my admin dashboard pr
sam-schu
left a comment
sam-schu
left a comment
There was a problem hiding this comment.
Received partial design clarification - clicking the pantry name should actually navigate to this page (please change PantryApplicationDetails into a component that supports the existing version for application review and this new version). I'm not certain yet where you need to click to access the assign volunteers modal, but for now let's say that anywhere in the assignee column for the pantry row works.
| import { useEffect, useState } from 'react'; | ||
| import { ApprovedPantryResponse, Assignments } from 'types/types'; | ||
| import { SearchIcon } from 'lucide-react'; | ||
| import { getInitials, USER_ICON_COLORS } from '@utils/utils'; |
There was a problem hiding this comment.
can we import ASSIGNEE_COLORS instead & rename it to USER_COLORS? it's the same list of color values except for blue.ssf vs blue.core
both arrays color users with the same logic, so using the same import list will make sure the volunteer's prof color is the same everywhere it appears
4 participants
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/browse/SSF-194
📝 Description
Frontend implementation for admin pantry management: http://localhost:4200/admin-pantry-management
Also implemented assign volunteers modal
✔️ Verification
Verified frontend matched figma design and proper assign volunteer functionality
🏕️ (Optional) Future Work / Notes
The view orders link currently doesn't go to anything, this functionality should be added later.