feat(tracking): honor DO_NOT_TRACK and COMFY_NO_TELEMETRY env vars#463
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds an env-var gate: ChangesEnvironment Variable Telemetry Opt-Out
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #463 +/- ##
==========================================
+ Coverage 83.22% 83.25% +0.02%
==========================================
Files 45 45
Lines 6791 6801 +10
==========================================
+ Hits 5652 5662 +10
Misses 1139 1139
🚀 New features to boost your workflow:
|
Short-circuits both the consent prompt and the per-event dispatch when either variable is set to a non-empty, non-zero value, per the consoledonottrack.com spec. Suppresses the non-TTY auto-enable path so no anonymous user_id is persisted before consent. Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
5b014ff to
2c73b8d
Compare
DO_NOT_TRACK(https://consoledonottrack.com/) andCOMFY_NO_TELEMETRYper consoledonottrack semantics: any value other than empty or0opts outuser_idpersistencetrack_event()defense-in-depth so no provider is dispatched