SPANISH TRANSLATION RAAAAAAAAAAAAHHHHHHHH#392
SPANISH TRANSLATION RAAAAAAAAAAAAHHHHHHHH#392TheParadoxBox wants to merge 38 commits intoComputerScienceHouse:developfrom
Conversation
…l as language switcher button
I need to remove the lang frontmatter because it's redundant lol so this needs to be committed now
This reverts commit b5d1af8.
Still have to figure out how to get title translations to work
…te.data[site.activa_lang][strings]" appears
This is what happens when you take a three month hiatus from a project
Got disappeared in the merge, oops
…PublicSite into translation-es
I'M FINALLY DONE WITH TRANSLATIONS!!!!!!!!!!!!!!
|
holy commits omg |
BigSpaceships
left a comment
BigSpaceships
left a comment
There was a problem hiding this comment.
Amazing work omg, a few things but if I said a dumb thing disregard but also copy-paste might be your friend here lol
| {% assign strings = site.data[site.active_lang][page.strings] %} | ||
|
|
There was a problem hiding this comment.
Okay lowkey I've never used a static site generator like this before so this is more me asking question than anything, but is it a bad idea to do something like this on all the other templates? site.data[site.active_lang] is really repetitive and I'm guessing could get annoying
| strings: "eboard" | ||
| --- | ||
| {% assign strings = site.data[site.active_lang][page.strings] %} | ||
|
|
There was a problem hiding this comment.
I think there's probably a better name for strings: "eboard" since we have multiple strings. If this is me being dumb and it's used in places it can't be changed ignore me but like I think having it be called page_name or something would make more sense and it seems like it's only used two lines down to assign the other strings
| <h2 class="header">{{ strings.email }}</h2> | ||
| <p class="long-form">{{ strings.email-evals }}</p> | ||
| <p class="long-form">{{ strings.email-chair }}</p> | ||
| <p class="long-form">{{ strings.email-webmaster }}</p> |
There was a problem hiding this comment.
This is hard because idk if there's a not clunky way to do it, but having the <a> tags inside the strings also feels weird and it would be cool if there was multiple strings and then the email link happened here instead of in the lang files
| Google search results) and in your feed.xml site description. | ||
| baseurl: "" # the subpath of your site, e.g. /blog | ||
| url: "https://pubsite.a.csh.rit.edu" # the base hostname & protocol for your site, e.g. http://example.com | ||
| url: "localhost:4000" # the base hostname & protocol for your site, e.g. http://example.com |
There was a problem hiding this comment.
Where is this used? I'm guessing it's when you run the Jekyll command to run locally right?
| RUN chown -R jekyll:jekyll /site | ||
| USER jekyll | ||
| RUN bundle config set --local path 'vendor/bundle' | ||
| RUN bundle install |
There was a problem hiding this comment.
Can installing the bundle be ran before we copy the contents? that way we can cache docker stages better
There was a problem hiding this comment.
(I say this as I'm patiently waiting for those dependencies to install)
| @@ -39,16 +36,16 @@ <h2 class="header">Current Students</h2> | |||
| <div class="col-12"> | |||
| <h2 class="header">Member Expectations</h2> | |||
There was a problem hiding this comment.
This one isn't translated
| <div class="row spaced" style="width: 100%;"> | ||
| <div class="col-12"> | ||
| <h2 class="header" id="tour-title">Dorm Room</h2> | ||
| <h2 class="header" id="tour-title">{{ strings.dorm }}</h2> | ||
| <p class="long-form" id="tour-description"> | ||
| Though the walls are the same as regular dorm rooms, our rooms usually look rather different than the standard RIT room layout. | ||
| </p> | ||
| </div> |
There was a problem hiding this comment.
Lowkey I have no clue, but the javascript uses variables under site so we might be able to translate this? if no disregard but we could maybe figure out a better way to implement this so we can translate
Line 6 in 7e9b3e9
There was a problem hiding this comment.
Update, I read and I see you exclude the assets directory from translation but there might be a way to make it so we don't need to do that. If you need help figuring it out lmk
2 participants
What
Adds a (mostly) fully functional Spanish version of the site, available through the added language switcher or by visiting https://csh.rit.edu/es.
Tour and blog posts do not have Spanish translations due to JS usage and workload, respectively.
Why
This improves accessibility for people who speak Spanish as their first language and English as their second, or prospective members whose parents only speak Spanish. Need I say more?
Test Plan
Viewed every page in both English and Spanish to check for errors
Env Vars
No
Checklist