Fix: 502 response caused by Function not found during alias updates (#7883) by dsotirho-ucsc · Pull Request #7923 · DataBiosphere/azul

dsotirho-ucsc · 2026-04-10T22:57:23Z

Linked issues: #7883

Checklist

Author

¹ when the issue title describes a problem, the corresponding PR
title is Fix: followed by the issue title

Author (partiality)

Added p tag to titles of partial commits
This PR is labeled partial _{or completely resolves all linked issues}
This PR partially resolves each of the linked issues _{or does not have the partial label}

Author (reindex)

Added r tag to commit title _{or the changes introduced by this PR will not require reindexing of any deployment}
This PR is labeled reindex:dev _{or the changes introduced by it will not require reindexing of dev}
This PR is labeled reindex:anvildev _{or the changes introduced by it will not require reindexing of anvildev}
This PR is labeled reindex:anvilprod _{or the changes introduced by it will not require reindexing of anvilprod}
This PR is labeled reindex:prod _{or the changes introduced by it will not require reindexing of prod}
This PR is labeled reindex:partial and its description documents the specific reindexing procedure for dev, anvildev, anvilprod and prod _{or requires a full reindex or carries none of the labels reindex:dev, reindex:anvildev, reindex:anvilprod and reindex:prod}

Author (mirror)

This PR is labeled mirror:dev _{or the changes introduced by it will not require mirroring of dev}
This PR is labeled mirror:anvildev _{or the changes introduced by it will not require mirroring of anvildev}
This PR is labeled mirror:anvilprod _{or the changes introduced by it will not require mirroring of anvilprod}
This PR is labeled mirror:prod _{or the changes introduced by it will not require mirroring of prod}
This PR is labeled mirror:partial and its description documents the specific mirroring procedure for dev, anvildev, anvilprod and prod _{or requires a full mirroring or carries none of the labels mirror:dev, mirror:anvildev, mirror:anvilprod and mirror:prod}

Author (API changes)

This PR and its linked issues are labeled API _{or this PR does not modify a REST API}
Added a (A) tag to commit title for backwards (in)compatible changes _{or this PR does not modify a REST API}
Updated REST API version number in app.py _{or this PR does not modify a REST API}

Author (upgrading deployments)

Ran make docker_images.json and committed the resulting changes _{or this PR does not modify azul_docker_images, or any other variables referenced in the definition of that variable}
Documented upgrading of deployments in UPGRADING.rst _{or this PR does not require upgrading deployments}
Added u tag to commit title _{or this PR does not require upgrading deployments}
This PR is labeled upgrade _{or does not require upgrading deployments}
This PR is labeled deploy:shared _{or does not modify docker_images.json, and does not require deploying the shared component for any other reason}
This PR is labeled deploy:gitlab _{or does not require deploying the gitlab component}
This PR is labeled deploy:runner _{or does not require deploying the runner image}

Author (hotfixes)

Added F tag to main commit title _{or this PR does not include permanent fix for a temporary hotfix}
Reverted the temporary hotfixes for any linked issues _{or the none of the stable branches (anvilprod and prod) have temporary hotfixes for any of the issues linked to this PR}

Author (before every review)

Rebased PR branch on develop, squashed fixups from prior reviews
Ran make requirements_update _{or this PR does not modify Dockerfile, environment, requirements*.txt, common.mk, Makefile or environment.boot}
Added R tag to commit title _{or this PR does not modify requirements*.txt}
This PR is labeled reqs _{or does not modify requirements*.txt}
make integration_test passes in personal deployment _{or this PR does not modify functionality that could affect the IT outcome}
PR is awaiting requested review from a peer
Status of PR is Review requested
PR is assigned to only the peer and the author

Peer reviewer (after approval)

Note that after requesting changes, the PR must be assigned to only the author.

~~Actually approved the PR~~
PR is not a draft
PR is awaiting requested review from system administrator
Status of PR is Review requested
PR is assigned to only the system administrator and the author

System administrator (after approval)

Actually approved the PR
Labeled linked issues as demo or no demo
Commented on linked issues about demo expectations _{or all linked issues are labeled no demo}
Decided if PR can be labeled no sandbox
A comment to this PR details the completed security design review
PR title is appropriate as title of merge commit
N reviews label is accurate
Status of PR is Approved
PR is assigned to only the operator and the author

Operator

Checked reindex:… labels and r commit title tag
Checked mirror:… labels
Checked that demo expectations are clear _{or all linked issues are labeled no demo}
Squashed PR branch and rebased onto develop
Sanity-checked history
Pushed PR branch to GitHub

Operator (deploy `.shared` and `.gitlab` components)

Ran _select dev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused _{or this PR is not labeled deploy:shared}
Ran _select dev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply _{or this PR is not labeled deploy:gitlab}
Ran _select anvildev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused _{or this PR is not labeled deploy:shared}
Ran _select anvildev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply _{or this PR is not labeled deploy:gitlab}
Checked the items in the next section _{or this PR is labeled deploy:gitlab}
PR is assigned to only the system administrator and the author _{or this PR is not labeled deploy:gitlab}

System administrator (post-deploy of `.gitlab` component)

Background migrations for dev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
Background migrations for anvildev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
PR is assigned to only the operator and the author

Operator (deploy runner image)

Ran _select dev.gitlab && make -C terraform/gitlab/runner _{or this PR is not labeled deploy:runner}
Ran _select anvildev.gitlab && make -C terraform/gitlab/runner _{or this PR is not labeled deploy:runner}

Operator (sandbox build)

Operator (merge the branch)

All status checks passed and the PR is mergeable
The title of the merge commit starts with the title of this PR
Added PR # reference to merge commit title
Collected commit title tags in merge commit title _{but only included p if the PR is also labeled partial}
Pushed merge commit to GitHub
Status of PR is Merged lower
Status of blocked issues is Triage _{or no issues are blocked on the linked issues}

Operator (main build)

Operator (reindex)

Operator (mirroring)

Started mirroring in dev _{or this PR is not labelled mirror:dev}
Started mirroring in anvildev _{or this PR is not labelled mirror:anvildev}
Checked for, triaged and possibly requeued messages in mirror fail queue in dev _{or this PR is not labelled mirror:dev}
Checked for, triaged and possibly requeued messages in mirror fail queue in anvildev _{or this PR is not labelled mirror:anvildev}
Emptied mirror fail queue in dev _{or this PR is not labelled mirror:dev}
Emptied mirror fail queue in anvildev _{or this PR is not labelled mirror:anvildev}

Operator

Propagated the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod, reindex:prod, mirror:partial, mirror:anvilprod and mirror:prod labels to the next promotion PRs _{or this PR carries none of these labels}
Propagated any specific instructions related to the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod, reindex:prod, mirror:partial, mirror:anvilprod and mirror:prod labels, from the description of this PR to that of the next promotion PRs _{or this PR carries none of these labels}
PR is assigned to no one

Shorthand for review comments

L line is too long
W line wrapping is wrong
Q bad quotes
F other formatting problem

codecov · 2026-04-10T23:09:48Z

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.03%. Comparing base (64ed456) to head (ace88c1).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/azul/lambdas.py	25.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7923      +/-   ##
===========================================
- Coverage    85.04%   85.03%   -0.02%     
===========================================
  Files          162      162              
  Lines        23303    23306       +3     
===========================================
  Hits         19819    19819              
- Misses        3484     3487       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coveralls · 2026-04-10T23:10:22Z

coverage: 85.119% (-0.01%) from 85.13% — issues/dsotirho-ucsc/7883-function-not-found into develop

dsotirho-ucsc · 2026-04-11T03:28:44Z

7923_IT_2026-04-10.txt

Prior to testing I created (and didn't delete) a few versions of my Lambda functions.
In the console log below, note

delete_older_function_versions.py --function-name azul-service-daniel-manifest --function-version 450 --buffer 1

and

Deleting function 'azul-service-daniel-manifest' versions older than 449

aws_lambda_function.service_manifest: Still modifying... [id=azul-service-daniel-manifest, 00m20s elapsed]
...
aws_lambda_function.service_manifest: Modifications complete after 21s [id=azul-service-daniel-manifest]
aws_lambda_runtime_management_config.service_manifest: Creating...
aws_lambda_runtime_management_config.service_manifest: Creation complete after 1s
aws_lambda_alias.service_manifest: Modifying... [id=arn:aws:lambda:us-east-1:122796619775:function:azul-service-daniel-manifest:active]
aws_lambda_alias.service_manifest: Modifications complete after 0s [id=arn:aws:lambda:us-east-1:122796619775:function:azul-service-daniel-manifest:active]
terraform_data.service_manifest: Creating...
terraform_data.service_manifest: Provisioning with 'local-exec'...
terraform_data.service_manifest (local-exec): Executing: ["/bin/sh" "-c" "python /Users/daniel/repo/azul2/scripts/delete_older_function_versions.py --function-name azul-service-daniel-manifest --function-version 450 --buffer 1"]
terraform_data.service_manifest (local-exec): 2026-04-10 19:36:54,607    INFO MainThread __main__: Deleting function 'azul-service-daniel-manifest' versions older than 449
terraform_data.service_manifest (local-exec): 2026-04-10 19:36:54,618    INFO MainThread botocore.credentials: Found credentials in shared credentials file: ~/.aws/credentials
terraform_data.service_manifest (local-exec): 2026-04-10 19:36:54,656    INFO MainThread azul.deployment: Allocated new Boto3 client for 'lambda' with ID 4484490176
terraform_data.service_manifest (local-exec): 2026-04-10 19:36:55,124    INFO MainThread azul.lambdas: Deleting version '446' of 'azul-service-daniel-manifest'
terraform_data.service_manifest (local-exec): 2026-04-10 19:36:55,359    INFO MainThread azul.lambdas: Deleting version '447' of 'azul-service-daniel-manifest'
terraform_data.service_manifest (local-exec): 2026-04-10 19:36:55,602    INFO MainThread azul.lambdas: Deleting version '448' of 'azul-service-daniel-manifest'
terraform_data.service_manifest: Creation complete after 2s [id=7252d78f-f737-b25a-bf00-6816d25057e8]

nadove-ucsc

Small formatting issue

nadove-ucsc · 2026-04-11T05:17:13Z

-    def delete_older_versions(self, function_name: str, keep_version: int) -> None:
+    def delete_older_versions(self,
+                              function_name: str,
+                              function_version: int) -> None:


Suggested change

function_version: int) -> None:

function_version: int

) -> None:

dsotirho-ucsc · 2026-04-13T17:45:35Z

7923_IT_2026-03-13.txt

hannes-ucsc · 2026-04-13T18:23:41Z

+    parser.add_argument('--buffer', '-b',
+                        type=int,
+                        default=0,
+                        help='Number of older versions to retain in addition '
+                             'to the specified version.')


Remove the --buffer argument.

hannes-ucsc · 2026-04-13T18:24:47Z

    args = parser.parse_args(argv)
+    assert args.buffer >= 0, R(
+        'The buffer size cannot be less than zero.', args.buffer)
+    retain_version = args.function_version - args.buffer


Move this calculation to functions.delete_older_versions and hardcode the 1 in the call of that function, not the TF config.

hannes-ucsc · 2026-04-13T18:25:01Z

+    assert args.buffer >= 0, R(
+        'The buffer size cannot be less than zero.', args.buffer)
+    retain_version = args.function_version - args.buffer
    log.info('Deleting function %r versions older than %r',


Move the logging to functions.delete_older_versions as well.

dsotirho-ucsc · 2026-04-13T21:29:50Z

7923_IT_2026-03-13.txt

hannes-ucsc · 2026-04-13T22:33:45Z

+                              function_name: str,
+                              function_version: int


This is what I meant in my previous review

Suggested change

function_name: str,

function_version: int

function_name: str,

function_version: int,

num_older_versions_to_keep: int = 0

hannes-ucsc · 2026-04-13T22:34:52Z

Also, please complete the peer review CL items.

dsotirho-ucsc · 2026-04-14T01:34:49Z

7923_IT_2026-04-13.txt

nadove-ucsc · 2026-04-14T18:30:39Z

+        :param function_version: The version of the function to retain, along
+                                 with the preceding one.


Suggested change

:param function_version: The version of the function to retain, along

with the preceding one.

:param function_version: The version of the function to retain.

dsotirho-ucsc · 2026-04-14T22:52:38Z

7923_IT_2026-04-14.txt

hannes-ucsc · 2026-04-15T02:34:50Z

+        :param num_older_versions_to_keep: The number of versions older than
+                                           `function_version` to also retain.
        """
+        assert num_older_versions_to_keep >= 0, num_older_versions_to_keep


This is a requirement, so R should be used.

hannes-ucsc · 2026-04-15T02:37:25Z

+                              function_name: str,
+                              function_version: int,
+                              *,
+                              num_older_versions_to_keep: int = 0


Decide if you want to use retain or keep for your variable and argument names, and documentation, but be consistent.

hannes-ucsc · 2026-04-15T02:41:28Z

+                        help='The version of the function to retain, along '
+                             'with the preceding one. All older versions will '
+                             'be deleted.')


Suggested change

help='The version of the function to retain, along '

'with the preceding one. All older versions will '

'be deleted.')

help='A numeric version of the Lambda function. The specified version will be kept, as will '

'the preceding one. All versions preceding those two versions will '

'be deleted.')

dsotirho-ucsc · 2026-04-15T22:04:07Z

7923_IT_2026-04-15.txt

hannes-ucsc · 2026-04-16T20:46:56Z

…7883)

nadove-ucsc

Pro-forma approval

dsotirho-ucsc linked an issue Apr 10, 2026 that may be closed by this pull request

502 response caused by Function not found during alias updates #7883

Open

dsotirho-ucsc self-assigned this Apr 10, 2026

dsotirho-ucsc force-pushed the issues/dsotirho-ucsc/7883-function-not-found branch 4 times, most recently from 485efd7 to 98e9995 Compare April 11, 2026 02:15

dsotirho-ucsc requested a review from nadove-ucsc April 11, 2026 03:29

dsotirho-ucsc assigned nadove-ucsc Apr 11, 2026

nadove-ucsc requested changes Apr 11, 2026

View reviewed changes

nadove-ucsc removed their assignment Apr 11, 2026

dsotirho-ucsc requested a review from nadove-ucsc April 13, 2026 17:45

dsotirho-ucsc assigned nadove-ucsc Apr 13, 2026

hannes-ucsc requested changes Apr 13, 2026

View reviewed changes

hannes-ucsc unassigned nadove-ucsc Apr 13, 2026

dsotirho-ucsc force-pushed the issues/dsotirho-ucsc/7883-function-not-found branch from 42ed1c3 to 5ac2d05 Compare April 13, 2026 20:47

dsotirho-ucsc requested a review from hannes-ucsc April 13, 2026 21:30

dsotirho-ucsc assigned hannes-ucsc Apr 13, 2026

hannes-ucsc requested changes Apr 13, 2026

View reviewed changes

hannes-ucsc removed their assignment Apr 13, 2026

dsotirho-ucsc force-pushed the issues/dsotirho-ucsc/7883-function-not-found branch 2 times, most recently from 4f84c55 to 8f3057e Compare April 14, 2026 01:12

dsotirho-ucsc assigned nadove-ucsc and unassigned nadove-ucsc Apr 14, 2026

nadove-ucsc reviewed Apr 14, 2026

View reviewed changes

dsotirho-ucsc marked this pull request as ready for review April 14, 2026 19:43

dsotirho-ucsc requested a review from hannes-ucsc April 14, 2026 19:44

dsotirho-ucsc assigned hannes-ucsc and unassigned hannes-ucsc Apr 14, 2026

dsotirho-ucsc force-pushed the issues/dsotirho-ucsc/7883-function-not-found branch from 8f3057e to e2c1194 Compare April 14, 2026 20:15

dsotirho-ucsc assigned hannes-ucsc Apr 14, 2026

hannes-ucsc requested changes Apr 15, 2026

View reviewed changes

hannes-ucsc added the 1 review [process] Lead requested changes once label Apr 15, 2026

hannes-ucsc removed their assignment Apr 15, 2026

dsotirho-ucsc force-pushed the issues/dsotirho-ucsc/7883-function-not-found branch from e2c1194 to b52455d Compare April 15, 2026 18:56

dsotirho-ucsc requested a review from hannes-ucsc April 15, 2026 22:04

dsotirho-ucsc assigned hannes-ucsc Apr 15, 2026

hannes-ucsc approved these changes Apr 16, 2026

View reviewed changes

hannes-ucsc removed their assignment Apr 16, 2026

Fix: 502 response caused by Function not found during alias updates (#…

ace88c1

…7883)

dsotirho-ucsc force-pushed the issues/dsotirho-ucsc/7883-function-not-found branch from b52455d to ace88c1 Compare April 17, 2026 03:03

dsotirho-ucsc added the sandbox [process] Resolution is being verified in sandbox deployment label Apr 17, 2026

nadove-ucsc self-requested a review April 17, 2026 04:42

nadove-ucsc approved these changes Apr 17, 2026

View reviewed changes

dsotirho-ucsc merged commit bb84990 into develop Apr 17, 2026
10 checks passed

dsotirho-ucsc deleted the issues/dsotirho-ucsc/7883-function-not-found branch April 17, 2026 05:33

dsotirho-ucsc removed their assignment Apr 17, 2026

	function_version: int) -> None:
	function_version: int
	) -> None:

		:param function_version: The version of the function to retain, along
		with the preceding one.

Conversation

dsotirho-ucsc commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Author

Author (partiality)

Author (reindex)

Author (mirror)

Author (API changes)

Author (upgrading deployments)

Author (hotfixes)

Author (before every review)

Peer reviewer (after approval)

System administrator (after approval)

Operator

Operator (deploy .shared and .gitlab components)

System administrator (post-deploy of .gitlab component)

Operator (deploy runner image)

Operator (sandbox build)

Operator (merge the branch)

Operator (main build)

Operator (reindex)

Operator (mirroring)

Operator

Shorthand for review comments

Uh oh!

codecov bot commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coveralls commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dsotirho-ucsc commented Apr 11, 2026

Uh oh!

nadove-ucsc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsotirho-ucsc commented Apr 13, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsotirho-ucsc commented Apr 13, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hannes-ucsc commented Apr 13, 2026

Uh oh!

dsotirho-ucsc commented Apr 14, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsotirho-ucsc commented Apr 14, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsotirho-ucsc commented Apr 15, 2026

Uh oh!

hannes-ucsc commented Apr 16, 2026

Security design review

Uh oh!

nadove-ucsc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

dsotirho-ucsc commented Apr 10, 2026 •

edited

Loading

Operator (deploy `.shared` and `.gitlab` components)

System administrator (post-deploy of `.gitlab` component)

codecov bot commented Apr 10, 2026 •

edited

Loading

coveralls commented Apr 10, 2026 •

edited

Loading