Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@ public static void init() {
ScriptEvent.registerScriptEvent(TNTPrimesScriptEvent.class);
}
ScriptEvent.registerScriptEvent(UnknownCommandScriptEvent.class);
if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_21)) {
ScriptEvent.registerScriptEvent(VaultChangeStateScriptEvent.class);
}
if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_19)) {
ScriptEvent.registerScriptEvent(WardenChangesAngerLevelScriptEvent.class);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
package com.denizenscript.denizen.paper.events;

import com.denizenscript.denizen.events.BukkitScriptEvent;
import com.denizenscript.denizen.objects.LocationTag;
import com.denizenscript.denizen.utilities.implementation.BukkitScriptEntryData;
import com.denizenscript.denizencore.objects.ObjectTag;
import com.denizenscript.denizencore.objects.core.ElementTag;
import com.denizenscript.denizencore.scripts.ScriptEntryData;
import io.papermc.paper.event.block.VaultChangeStateEvent;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;

public class VaultChangeStateScriptEvent extends BukkitScriptEvent implements Listener {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but the event is called changes and this says change.


// <--[event]
// @Events
// vault changes state
//
// @Plugin Paper
//
// @Group Block
//
// @Cancellable true
//
// @Location true
//
// @Triggers when a vault block state changes
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be block's or block changes state.
Also . at the end.

//
// @Context
// <context.location> returns the LocationTag of the vault block.
// <context.old_state> returns the vault state before the change.
// <context.new_state> returns the vault state after the change.
//
// @Player when the entity who triggered the change is a player.
//
// -->

public VaultChangeStateScriptEvent() {
registerCouldMatcher("vault changes state");
}

public LocationTag location;
public VaultChangeStateEvent event;

@Override
public boolean matches(ScriptPath path) {
if (!runInCheck(path, location)) {
return false;
}
return super.matches(path);
}

@Override
public ScriptEntryData getScriptEntryData() {
return new BukkitScriptEntryData(event.getPlayer());
}

@Override
public ObjectTag getContext(String name) {
return switch (name) {
case "old_state" -> new ElementTag(event.getCurrentState());
case "new_state" -> new ElementTag(event.getNewState());
case "location" -> location;
default -> super.getContext(name);
};
}

@EventHandler
public void onVaultChangeStateEvent(VaultChangeStateEvent event) {
location = new LocationTag(event.getBlock().getLocation());
this.event = event;
fire(event);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ public static void registerMainEvents() {
ScriptEvent.registerScriptEvent(BlockBurnsScriptEvent.class);
ScriptEvent.registerScriptEvent(BlockCooksSmeltsItemScriptEvent.class);
ScriptEvent.registerScriptEvent(BlockDestroyedByExplosionEvent.class);
if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_21)) {
ScriptEvent.registerScriptEvent(BlockDispenseLootScriptEvent.class);
}
ScriptEvent.registerScriptEvent(BlockDispensesScriptEvent.class);
ScriptEvent.registerScriptEvent(BlockEquipsItemScriptEvent.class);
ScriptEvent.registerScriptEvent(BlockExplodesScriptEvent.class);
Expand All @@ -80,8 +83,14 @@ public static void registerMainEvents() {
ScriptEvent.registerScriptEvent(BlockShearEntityScriptEvent.class);
ScriptEvent.registerScriptEvent(BlockSpreadsScriptEvent.class);
ScriptEvent.registerScriptEvent(BrewingStandFueledScriptEvent.class);
if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_19)) {
ScriptEvent.registerScriptEvent(BrewingStartsScriptEvent.class);
}
ScriptEvent.registerScriptEvent(BrewsScriptEvent.class);
ScriptEvent.registerScriptEvent(CauldronLevelChangeScriptEvent.class);
if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_21)) {
ScriptEvent.registerScriptEvent(CrafterCraftsScriptEvent.class);
}
ScriptEvent.registerScriptEvent(DragonEggMovesScriptEvent.class);
ScriptEvent.registerScriptEvent(FurnaceBurnsItemScriptEvent.class);
ScriptEvent.registerScriptEvent(FurnaceStartsSmeltingScriptEvent.class);
Expand All @@ -95,11 +104,10 @@ public static void registerMainEvents() {
ScriptEvent.registerScriptEvent(RedstoneScriptEvent.class);
ScriptEvent.registerScriptEvent(SpongeAbsorbsScriptEvent.class);
if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_19)) {
ScriptEvent.registerScriptEvent(BrewingStartsScriptEvent.class);
ScriptEvent.registerScriptEvent(TNTPrimesScriptEvent.class);
}
if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_21)) {
ScriptEvent.registerScriptEvent(CrafterCraftsScriptEvent.class);
ScriptEvent.registerScriptEvent(VaultDisplayItemScriptEvent.class);
}

// Entity events
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
package com.denizenscript.denizen.events.block;

import com.denizenscript.denizen.events.BukkitScriptEvent;
import com.denizenscript.denizen.objects.*;
import com.denizenscript.denizen.utilities.implementation.BukkitScriptEntryData;
import com.denizenscript.denizencore.objects.ObjectTag;
import com.denizenscript.denizencore.objects.core.ListTag;
import com.denizenscript.denizencore.scripts.ScriptEntryData;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockDispenseLootEvent;
import org.bukkit.inventory.ItemStack;

import java.util.ArrayList;
import java.util.List;

public class BlockDispenseLootScriptEvent extends BukkitScriptEvent implements Listener {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the class name usually matches the Denizen name over the bukkit name, so that it's easier to spot in code for us.


// <--[event]
// @Events
// loot dispenses from <block>
//
// @Group Block
//
// @Location true
//
// @Cancellable true
//
// @Player Always.
//
// @Triggers when a block dispenses loot containing multiple items.
//
// @Context
// <context.loot> returns a ListTag(ItemTag) of outcome items.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outcome here sounds a little weird imo? I'd just say loot items maybe, or something like items being dispensed if you want to be more explicit.

// <context.location> returns a LocationTag of the block that is dispensing the items.
//
// @Determine
// <ListTag(ItemTag)> to determine the new items that are outputted.
//
// -->

public BlockDispenseLootScriptEvent() {
registerCouldMatcher("loot dispenses from <block>");
this.<BlockDispenseLootScriptEvent, ListTag>registerDetermination(null, ListTag.class, (evt, context, input) -> {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in general, prefixed determinations (to match their context counterparts) are usually preferred as they're easier to understand in scripts & look cleaner if the event ever gets more than one determination.

List<ItemStack> items = new ArrayList<>();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but can initialize to input.size().

for (ItemTag item : input.filter(ItemTag.class, context)) {
items.add(item.getItemStack());
}
evt.event.setDispensedLoot(items);
});
}

public MaterialTag block;
public LocationTag location;
public BlockDispenseLootEvent event;

@Override
public boolean matches(ScriptPath path) {
if (!path.tryArgObject(3, block)) {
return false;
}
if (!runInCheck(path, location)) {
return false;
}
return super.matches(path);
}

@Override
public ScriptEntryData getScriptEntryData() {
return new BukkitScriptEntryData(new PlayerTag(event.getPlayer()), null);
}

@Override
public ObjectTag getContext(String name) {
return switch (name) {
case "loot" -> new ListTag(event.getDispensedLoot(), ItemTag::new);
case "location" -> location;
default -> super.getContext(name);
};
}

@EventHandler
public void onBlockLootDispense(BlockDispenseLootEvent event) {
block = new MaterialTag(event.getBlock().getType());
location = new LocationTag(event.getBlock().getLocation());
this.event = event;
fire(event);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
package com.denizenscript.denizen.events.block;

import com.denizenscript.denizen.events.BukkitScriptEvent;
import com.denizenscript.denizen.objects.ItemTag;
import com.denizenscript.denizen.objects.LocationTag;
import com.denizenscript.denizencore.objects.ObjectTag;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.VaultDisplayItemEvent;

public class VaultDisplayItemScriptEvent extends BukkitScriptEvent implements Listener {

// <--[event]
// @Events
// vault displays <item>
//
// @Group Block
//
// @Location true
//
// @Cancellable true
//
// @Triggers when a vault block displays an item.
//
// @Context
// <context.location> returns the LocationTag of the vault block.
// <context.item> returns the ItemTag being displayed.
//
// @Determine
// ItemTag to set the item being displayed.
//
// -->

public VaultDisplayItemScriptEvent() {
registerCouldMatcher("vault displays <item>");
this.<VaultDisplayItemScriptEvent, ItemTag>registerDetermination(null, ItemTag.class, (evt, context, item) -> {
this.item = item;
evt.event.setDisplayItem(item.getItemStack());
});
}

public LocationTag location;
public ItemTag item;
public VaultDisplayItemEvent event;

@Override
public boolean matches(ScriptPath path) {
if (!runInCheck(path, location)) {
return false;
}
if (!path.tryArgObject(2, item)) {
return false;
}
return super.matches(path);
}

@Override
public ObjectTag getContext(String name) {
return switch (name) {
case "item" -> item;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the same issue with the context potentially becoming outdated due to another plugin accessing it (e.g. if you - wait a bit in a script and then read it) - need to dynamically get the item here, but can keep the field for matches optimization.

case "location" -> location;
default -> super.getContext(name);
};
}

@EventHandler
public void onVaultDisplayItemEvent(VaultDisplayItemEvent event) {
location = new LocationTag(event.getBlock().getLocation());
item = new ItemTag(event.getDisplayItem());
this.event = event;
fire(event);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,9 @@ public static void registerMainProperties() {
PropertyParser.registerProperty(MaterialLightable.class, MaterialTag.class);
PropertyParser.registerProperty(MaterialMode.class, MaterialTag.class);
PropertyParser.registerProperty(MaterialNote.class, MaterialTag.class);
if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_21)) {
PropertyParser.registerProperty(MaterialOminous.class, MaterialTag.class);
}
PropertyParser.registerProperty(MaterialPersistent.class, MaterialTag.class);
PropertyParser.registerProperty(MaterialPower.class, MaterialTag.class);
PropertyParser.registerProperty(MaterialShape.class, MaterialTag.class);
Expand Down
Loading