DataGrid: Fix the banded Columns' vertical borders (T1318812) by Alyar666 · Pull Request #32802 · DevExpress/DevExtreme

Alyar666 · 2026-03-05T13:48:38Z

No description provided.

Copilot

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.

packages/devextreme/js/__internal/grids/grid_core/column_headers/m_column_headers.ts

packages/devextreme/js/__internal/grids/grid_core/sticky_columns/m_sticky_columns.ts

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 18 out of 159 changed files in this pull request and generated 4 comments.

packages/devextreme/js/__internal/grids/grid_core/column_headers/m_column_headers.ts

packages/devextreme/js/__internal/grids/grid_core/sticky_columns/m_sticky_columns.ts

packages/devextreme/js/__internal/grids/grid_core/column_headers/m_column_headers.ts

Copilot

Pull request overview

Copilot reviewed 25 out of 186 changed files in this pull request and generated 1 comment.

packages/devextreme/js/__internal/grids/grid_core/views/m_columns_view.ts

…iew (T1318812)

…lectors (T1318812)

Copilot

Pull request overview

Copilot reviewed 25 out of 188 changed files in this pull request and generated 2 comments.

packages/devextreme-scss/scss/widgets/material/gridBase/layout/cell.scss

e2e/testcafe-devextreme/tests/dataGrid/helpers/domUtils.ts

…rtical borders

- Remove needToUpdateFirstCellClasses check from adaptivity resizing - Remove showColumnLines gate from column headers _createCell - Remove needToUpdateFirstCellClasses method from ColumnsView

Copilot

Pull request overview

Copilot reviewed 27 out of 190 changed files in this pull request and generated 2 comments.

packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/adaptiveColumns.tests.js

packages/testcafe-models/dataGrid/headers/cell.ts

anna-shakhova · 2026-03-31T09:42:32Z

packages/devextreme-scss/scss/widgets/base/dataGrid/layout/cell.scss


+// (0,6,1)
+.dx-rtl > .dx-gridbase-container .dx-datagrid-content .dx-datagrid-table .dx-row > td.dx-datagrid-first-cell {
+  border-right: none;


suggestion: use where possible border-inline-start property and similar to avoid duplications for rtl and non-rtl styles

Yeah, makes sense 👍
Right now it would require quite a lot of refactoring, so probably not worth doing in this scope.

But agreed — we should switch to properties like border-inline-start in the future to avoid duplicating RTL/LTR styles.

…t (T1318812)

Copilot

Pull request overview

Copilot reviewed 28 out of 195 changed files in this pull request and generated 1 comment.

e2e/testcafe-devextreme/tests/dataGrid/helpers/domUtils.ts

e2e/testcafe-devextreme/tests/dataGrid/common/bandColumns/functional.ts

Raushen · 2026-03-31T18:04:38Z

packages/devextreme/js/__internal/grids/grid_core/adaptivity/m_adaptivity.ts

+
+    const oldIndices = new Set(oldHiddenColumns.map((col) => col.index));
+
+    return hiddenColumns.some((col) => !oldIndices.has(col.index));


Minor: looks like a util method areArraysEqual

…ress#32802) Co-authored-by: Alyar <>

Alyar666 self-assigned this Mar 5, 2026

Copilot AI review requested due to automatic review settings March 5, 2026 13:48

Alyar666 requested a review from a team as a code owner March 5, 2026 13:48

Alyar666 added skip-cache force all tests 26_1 labels Mar 5, 2026

Copilot started reviewing on behalf of Alyar666 March 5, 2026 13:49 View session

This comment was marked as outdated.

Sign in to view

Copilot AI review requested due to automatic review settings March 10, 2026 13:15

Alyar666 force-pushed the T1318812_26_1_attempt_3 branch from 88936f8 to ccd2691 Compare March 10, 2026 13:15

Copilot started reviewing on behalf of Alyar666 March 10, 2026 13:16 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Alyar666 force-pushed the T1318812_26_1_attempt_3 branch from ccd2691 to 2899a74 Compare March 16, 2026 09:55

Copilot AI review requested due to automatic review settings March 16, 2026 10:24

Copilot started reviewing on behalf of Alyar666 March 16, 2026 10:25 View session

This comment was marked as outdated.

Sign in to view

Alyar666 force-pushed the T1318812_26_1_attempt_3 branch from 77856d4 to d98ceff Compare March 17, 2026 09:24

Copilot AI review requested due to automatic review settings March 17, 2026 12:10

Copilot started reviewing on behalf of Alyar666 March 17, 2026 12:10 View session

This comment was marked as outdated.

Sign in to view

Alyar666 force-pushed the T1318812_26_1_attempt_3 branch from 04062b7 to a784fb8 Compare March 17, 2026 22:03

Copilot AI review requested due to automatic review settings March 17, 2026 22:03

Copilot started reviewing on behalf of Alyar666 March 17, 2026 22:04 View session

Copilot AI reviewed Mar 17, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 18, 2026 17:22

Copilot started reviewing on behalf of Alyar666 March 18, 2026 17:27 View session

Copilot AI reviewed Mar 18, 2026

View reviewed changes

Alyar added 3 commits March 19, 2026 01:15

Revert the fix for T1282595

74f3dfe

separate TestCafe tests into functional and visual tests

2062535

Move first-header class logic from sticky_columns to column_headers

486f91e

Copilot started reviewing on behalf of Alyar666 March 25, 2026 23:00 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

packages/devextreme/js/__internal/grids/grid_core/views/m_columns_view.ts Outdated Show resolved Hide resolved

Alyar added 3 commits March 26, 2026 03:59

Update etalons (part 6)

7b9216a

fix: clear stale first-cell classes before recalculating in columns v…

0e87a35

…iew (T1318812)

fix: exclude hidden and adaptive columns from banded header border se…

16b2b71

…lectors (T1318812)

Copilot AI review requested due to automatic review settings March 27, 2026 07:53

Copilot started reviewing on behalf of Alyar666 March 27, 2026 07:54 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

packages/devextreme-scss/scss/widgets/material/gridBase/layout/cell.scss Show resolved Hide resolved

e2e/testcafe-devextreme/tests/dataGrid/helpers/domUtils.ts Outdated Show resolved Hide resolved

Alyar added 6 commits March 27, 2026 16:22

DataGrid: exclude .dx-pointer-events-none cells from banded column ve…

3270dcb

…rtical borders

update first-cell classes on adaptive changes

2ea1f17

Fix QUnit tests

0bea190

Fix jest tests

0dd3810

Fix QUnit test (part 2)

b1c175a

DataGrid: simplify first-cell class update logic (T1318812)

7e9a51e

- Remove needToUpdateFirstCellClasses check from adaptivity resizing - Remove showColumnLines gate from column headers _createCell - Remove needToUpdateFirstCellClasses method from ColumnsView

Copilot AI review requested due to automatic review settings March 30, 2026 20:03

Copilot started reviewing on behalf of Alyar666 March 30, 2026 20:04 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/adaptiveColumns.tests.js Show resolved Hide resolved

packages/testcafe-models/dataGrid/headers/cell.ts Show resolved Hide resolved

anna-shakhova reviewed Mar 31, 2026

View reviewed changes

Alyar added 2 commits March 31, 2026 14:10

fix: update first-cell classes only after adaptive visibleWidth is se…

04f7ea1

…t (T1318812)

Fix QUnit test (part 3)

496e885

Copilot AI review requested due to automatic review settings March 31, 2026 12:46

Copilot started reviewing on behalf of Alyar666 March 31, 2026 12:47 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

e2e/testcafe-devextreme/tests/dataGrid/helpers/domUtils.ts Outdated Show resolved Hide resolved

Alyar added 2 commits March 31, 2026 17:04

small code refactoring

3c7f1e3

Fix copilot comments

6c66f96

Raushen reviewed Mar 31, 2026

View reviewed changes

e2e/testcafe-devextreme/tests/dataGrid/common/bandColumns/functional.ts Show resolved Hide resolved

Raushen reviewed Mar 31, 2026

View reviewed changes

Raushen approved these changes Mar 31, 2026

View reviewed changes

Alyar666 merged commit 7b5bc5d into DevExpress:26_1 Apr 1, 2026
150 of 151 checks passed

Alyar666 added a commit to Alyar666/DevExtreme that referenced this pull request Apr 1, 2026

DataGrid: Fix the banded Columns' vertical borders (T1318812) (DevExp…

bdeb93e

…ress#32802) Co-authored-by: Alyar <>


		const oldIndices = new Set(oldHiddenColumns.map((col) => col.index));

		return hiddenColumns.some((col) => !oldIndices.has(col.index));

Conversation

Alyar666 commented Mar 5, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

anna-shakhova Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Alyar666 Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Raushen Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants