feat(client): make rdpsnd-native an optional default-enabled dependency#1306
Closed
Copilot wants to merge 1 commit into
Closed
feat(client): make rdpsnd-native an optional default-enabled dependency#1306Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Extract rdpsnd support from PR #1289 into a dedicated PR as suggested in review. The native-rdpsnd feature is default-enabled so rdpsnd is always included unless explicitly opted out (e.g. by headless/agent consumers using --no-default-features). Ref: #1289 (review)
Copilot created this pull request from a session on behalf of
Benoît Cortier (CBenoit)
May 25, 2026 12:13
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts rdpsnd support from #1289 into a dedicated PR per review feedback.
ironrdp-rdpsnd-native(cpal audio backend) is now an optional dependency behind anative-rdpsndfeature, enabled by default. Downstream consumers like headless/agent crates can opt out viadefault-features = false.Cargo.toml:native-rdpsndfeature gatingdep:ironrdp-rdpsnd-native, added todefaultrdp.rs:#[cfg(feature = "native-rdpsnd")]oncpalimport andattach_static_channelcalls in bothconnectandconnect_wsThe
rdpsndPDU types from theironrdpumbrella crate remain unconditionally available — only the native audio backend is gated.