Skip to content

feat: add authz dependency injection#1539

Open
shree-iyengar-dls wants to merge 1 commit into
mainfrom
add_depedency_injection
Open

feat: add authz dependency injection#1539
shree-iyengar-dls wants to merge 1 commit into
mainfrom
add_depedency_injection

Conversation

@shree-iyengar-dls
Copy link
Copy Markdown
Contributor

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.33%. Comparing base (62353cd) to head (df5105c).

Files with missing lines Patch % Lines
src/blueapi/service/main.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1539      +/-   ##
==========================================
- Coverage   95.35%   95.33%   -0.02%     
==========================================
  Files          43       43              
  Lines        3205     3215      +10     
==========================================
+ Hits         3056     3065       +9     
- Misses        149      150       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shree-iyengar-dls shree-iyengar-dls marked this pull request as ready for review May 15, 2026 14:27
@shree-iyengar-dls shree-iyengar-dls requested a review from a team as a code owner May 15, 2026 14:27
Comment on lines +282 to +283
def submission_check(
opa: Annotated[OPAClient, Depends(get_opa_client)],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there will be multiple of these depends

  1. submit_task
  2. get tasks
  3. delete_tasks
    ....
    Basically most of the endpoint in the tasks group

and as we will have multiple of these we can move them closed to where OPAClient will be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants