Add error extensions to AuthError#275
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 76.35% 76.44% +0.08%
==========================================
Files 13 13
Lines 1937 1944 +7
==========================================
+ Hits 1479 1486 +7
Misses 458 458 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks good but could do with a couple of tests to make sure the errors look as expected. And numtracker doesn't use conventional commits |
|
Yup, just adding some tests now |
tpoliaw
left a comment
There was a problem hiding this comment.
Could we have a test (probably in graphql/mod.rs?) to check that the code is added to the extensions when the auth check is called via a graphql query? I think we need to be calling extend() somewhere so I'm not sure the extensions are doing anything yet.
Most of the other comments are code-style things - the change itself looks ok.
tpoliaw
left a comment
There was a problem hiding this comment.
Up to you if you want to change the tests
Improving numtracker auth error messages