Skip to content

pass symbol file path to svgs in the JsonMap for daedalus#219

Open
tomkane-dls wants to merge 1 commit into
mainfrom
pass-symbols
Open

pass symbol file path to svgs in the JsonMap for daedalus#219
tomkane-dls wants to merge 1 commit into
mainfrom
pass-symbols

Conversation

@tomkane-dls
Copy link
Copy Markdown
Collaborator

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.82%. Comparing base (2f86a73) to head (4864736).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
+ Coverage   94.77%   94.82%   +0.04%     
==========================================
  Files          10       10              
  Lines         861      869       +8     
==========================================
+ Hits          816      824       +8     
  Misses         45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@OCopping
Copy link
Copy Markdown
Collaborator

OCopping commented May 18, 2026

Worth noting that for symbol widgets that have multiple icons for different states (e.g. shutters) this will only return the icon at index 0. This means if shutters have different logic, there can be different symbols.
Examples from i19-services:

            "symbol": "techui-support/old-symbols/shutter-open.svg",
            "displayName": "EH2 Fast Shutter"
...
            "symbol": "techui-support/old-symbols/shutter-closed.svg",
            "displayName": "EH1 Fast Shutter"
...
            "symbol": "techui-support/old-symbols/shutter-fault.svg",
            "displayName": "FE Shutter"

(EDIT: the old-symbols/ is because i ran this after working with the new lucide icons from techui-support)

@tomkane-dls
Copy link
Copy Markdown
Collaborator Author

Worth noting that for symbol widgets that have multiple icons for different states (e.g. shutters) this will only return the icon at index 0. This means if shutters have different logic, there can be different symbols. Examples from i19-services:

            "symbol": "techui-support/old-symbols/shutter-open.svg",
            "displayName": "EH2 Fast Shutter"
...
            "symbol": "techui-support/old-symbols/shutter-closed.svg",
            "displayName": "EH1 Fast Shutter"
...
            "symbol": "techui-support/old-symbols/shutter-fault.svg",
            "displayName": "FE Shutter"

(EDIT: the old-symbols/ is because i ran this after working with the new lucide icons from techui-support)

Ah yes. Do you think to resolve this we should just standardise the order of symbols for a device, or do something more robust?

@OCopping
Copy link
Copy Markdown
Collaborator

OCopping commented May 18, 2026

Ah yes. Do you think to resolve this we should just standardise the order of symbols for a device, or do something more robust?

This would not be simple to standardise, as it is down to however the PV is programmed... So I'm not actually sure 🙃

EDIT: We could potentially solve this using rules tbh, but it would complicate things a bit. I'll have a go on i19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants