pass symbol file path to svgs in the JsonMap for daedalus#219
pass symbol file path to svgs in the JsonMap for daedalus#219tomkane-dls wants to merge 1 commit into
Conversation
…nMap for daedalus
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 94.77% 94.82% +0.04%
==========================================
Files 10 10
Lines 861 869 +8
==========================================
+ Hits 816 824 +8
Misses 45 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Worth noting that for symbol widgets that have multiple icons for different states (e.g. shutters) this will only return the icon at index 0. This means if shutters have different logic, there can be different symbols. "symbol": "techui-support/old-symbols/shutter-open.svg",
"displayName": "EH2 Fast Shutter"
...
"symbol": "techui-support/old-symbols/shutter-closed.svg",
"displayName": "EH1 Fast Shutter"
...
"symbol": "techui-support/old-symbols/shutter-fault.svg",
"displayName": "FE Shutter"
(EDIT: the |
Ah yes. Do you think to resolve this we should just standardise the order of symbols for a device, or do something more robust? |
This would not be simple to standardise, as it is down to however the PV is programmed... So I'm not actually sure 🙃 EDIT: We could potentially solve this using rules tbh, but it would complicate things a bit. I'll have a go on i19 |
No description provided.