Skip to content

Add Next features to Android sample#4

Open
morganchen12 wants to merge 5 commits intomainfrom
mc/subquery
Open

Add Next features to Android sample#4
morganchen12 wants to merge 5 commits intomainfrom
mc/subquery

Conversation

@morganchen12
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the data layer to utilize Firestore pipelines for dynamic aggregation of recipe ratings, like counts, and popular tags, while also introducing a new search capability. Review feedback identifies a critical bug where field("id") is incorrectly used to reference document IDs, which will likely result in null values. Additionally, the filtering logic is missing necessary dynamic field calculations required for UI consistency and popularity-based sorting, and an unused subquery for like counts was noted as an optimization opportunity.

@morganchen12 morganchen12 changed the title Mc/subquery Add Next features to Android sample Apr 20, 2026
@morganchen12 morganchen12 requested a review from marinacoelho May 4, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant