Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6949 +/- ##
==========================================
- Coverage 76.29% 76.29% -0.01%
==========================================
Files 403 403
Lines 20296 20302 +6
Branches 4881 4885 +4
==========================================
+ Hits 15485 15489 +4
- Misses 4811 4813 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Steve-Mcl I've had to remove 2 tests as there won't be a case of the URLs not being set anymore. Hopefully this is just temporary until https://github.com/FlowFuse/engineering/issues/6 is fixed, when suitable new tests can be added. |
Steve-Mcl
left a comment
There was a problem hiding this comment.
Should we not put the defaults in config/index.js so they are in one place and not repeated - or is there a subtlety i am missing?
Something like:
if (config.assistant?.enabled === true && !config.assistant.service?.url) {
config.assistant.service.url = 'https://expert.flowfuse/v1/openai'
}
if (config.expert?.enabled === true && !config.expert.service?.url) {
config.expert.service.url = 'https://expert.flowfuse/v4/expert'
}
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
fixes #6895
Description
Adds default URLs for assistant and expert using the new unified hostname
expert.flowfuse.com.NOT TO BE MERGED BEFORE: https://github.com/FlowFuse/CloudProject/pull/1224
Related Issue(s)
#6895
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel