Merge: Fix wrong player_parent logic leading to invalid type#75
Merged
Conversation
channels, duration were wrongly parsed as string instead of int. ``` PHP Fatal error: Uncaught TypeError: SimplePie\Enclosure::__construct(): Argument #12 ($duration) must be of type ?int, string given in simplepie/src/Enclosure.php:199 ``` And add tests (there were none for those attributes) Downstream issue: * FreshRSS/FreshRSS#8701
``` PHP Fatal error: Uncaught TypeError: SimplePie\Enclosure::__construct(): Argument #20 ($player) must be of type ?string, array given in /opt/freshrss/lib/simplepie/simplepie/src/Enclosure.php:199 ``` This happens when there is no`url` parameter. Example of feed: * https://feeds.feedburner.com/crunchyroll/rss/anime?lang=deDE Downstream issue: * FreshRSS/FreshRSS#8892
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happens when there is no
urlparameter.Example of feed:
Downstream issue:
Upstream PR: