Promote new fields in google_iam_workload_identity_pool to GA

[stevenyang72]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

iambeta: promoted `iam_policy` and fields `mode`, `inline_certificate_issuance_config`, `inline_trust_config` of   `google_iam_workload_identity_pool` resource to GA

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1574 insertions(+), 20 deletions(-))
google-beta provider: Diff ( 5 files changed, 15 insertions(+), 62 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 426 insertions(+), 1 deletion(-))
Open in Cloud Shell: Diff ( 8 files changed, 245 insertions(+))

[modular-magician]

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccIAMBetaWorkloadIdentityPoolIamBindingGenerated
• TestAccIAMBetaWorkloadIdentityPoolIamBindingGenerated_withAndWithoutCondition
• TestAccIAMBetaWorkloadIdentityPoolIamBindingGenerated_withCondition
• TestAccIAMBetaWorkloadIdentityPoolIamMemberGenerated
• TestAccIAMBetaWorkloadIdentityPoolIamMemberGenerated_withAndWithoutCondition
• TestAccIAMBetaWorkloadIdentityPoolIamMemberGenerated_withCondition
• TestAccIAMBetaWorkloadIdentityPoolIamPolicyGenerated
• TestAccIAMBetaWorkloadIdentityPoolIamPolicyGenerated_withCondition
• TestAccIAMBetaWorkloadIdentityPool_iamWorkloadIdentityPoolFullFederationOnlyModeExample
• TestAccIAMBetaWorkloadIdentityPool_iamWorkloadIdentityPoolFullTrustDomainModeExample

Tests analytics

Total tests: 37
Passed tests: 32
Skipped tests: 2
Affected tests: 3

Click here to see the affected service packages

• iambeta

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccIAMBetaWorkloadIdentityPool_full
• TestAccIAMBetaWorkloadIdentityPool_minimal
• TestAccIAMBetaWorkloadIdentityPool_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccIAMBetaWorkloadIdentityPool_full [Debug log]
TestAccIAMBetaWorkloadIdentityPool_minimal [Debug log]
TestAccIAMBetaWorkloadIdentityPool_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1704 insertions(+), 21 deletions(-))
google-beta provider: Diff ( 5 files changed, 18 insertions(+), 71 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 460 insertions(+), 1 deletion(-))
Open in Cloud Shell: Diff ( 12 files changed, 379 insertions(+))

[modular-magician]

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccIAMBetaWorkloadIdentityPoolIamBindingGenerated
• TestAccIAMBetaWorkloadIdentityPoolIamBindingGenerated_withAndWithoutCondition
• TestAccIAMBetaWorkloadIdentityPoolIamBindingGenerated_withCondition
• TestAccIAMBetaWorkloadIdentityPoolIamMemberGenerated
• TestAccIAMBetaWorkloadIdentityPoolIamMemberGenerated_withAndWithoutCondition
• TestAccIAMBetaWorkloadIdentityPoolIamMemberGenerated_withCondition
• TestAccIAMBetaWorkloadIdentityPoolIamPolicyGenerated
• TestAccIAMBetaWorkloadIdentityPoolIamPolicyGenerated_withCondition
• TestAccIAMBetaWorkloadIdentityPool_iamWorkloadIdentityPoolFullFederationOnlyModeExample
• TestAccIAMBetaWorkloadIdentityPool_iamWorkloadIdentityPoolFullTrustDomainModeExample
• TestAccIAMBetaWorkloadIdentityPool_iamWorkloadIdentityPoolFullTrustDomainModeWithDefaultSharedCaExample

Tests analytics

Total tests: 38
Passed tests: 33
Skipped tests: 2
Affected tests: 3

Click here to see the affected service packages

• iambeta

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccIAMBetaWorkloadIdentityPool_full
• TestAccIAMBetaWorkloadIdentityPool_minimal
• TestAccIAMBetaWorkloadIdentityPool_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccIAMBetaWorkloadIdentityPool_full [Debug log]
TestAccIAMBetaWorkloadIdentityPool_minimal [Debug log]
TestAccIAMBetaWorkloadIdentityPool_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[stevenyang72]

Hi @c2thorn, thanks for reviewing the code! May I ask should I be worried about the 🔴 Tests were added that are GA-only additions and require manual runs: findings above? Thanks!

[c2thorn]

Running GA TestAccIAMBetaWorkloadIdentityPool* tests in TC here

[c2thorn]

Running GA TestAccIAMBetaWorkloadIdentityPool* tests in TC here

It looks like TestAccIAMBetaWorkloadIdentityPoolIamPolicyGenerated failed, but looking at the test history in the Beta nightly tests, it is occasionally flakey with the exact same error message. It does not look verisoning-related to me.

[c2thorn]

LGTM after reviewing GA test run